From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Nguyen Date: Fri, 15 Apr 2022 13:53:20 -0700 Subject: [Intel-wired-lan] [PATCH net] ice: Protect vf_state check by cfg_lock in ice_vc_process_vf_msg() In-Reply-To: References: <20220413072259.3189386-1-ivecera@redhat.com> <20220415183845.51a326fe@ceranb> Message-ID: <9dfffc57-4733-37c9-5668-97b06a40a202@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On 4/15/2022 11:31 AM, Keller, Jacob E wrote: > >> -----Original Message----- >> From: Ivan Vecera >> Sent: Friday, April 15, 2022 9:39 AM >> To: Fijalkowski, Maciej >> Cc: netdev at vger.kernel.org; Fei Liu ; moderated list:INTEL >> ETHERNET DRIVERS ; mschmidt >> ; Brett Creeley ; open list >> ; Jakub Kicinski ; Paolo Abeni >> ; David S. Miller >> Subject: Re: [Intel-wired-lan] [PATCH net] ice: Protect vf_state check by cfg_lock in >> ice_vc_process_vf_msg() >> >> On Fri, 15 Apr 2022 13:55:02 +0200 >> Maciej Fijalkowski wrote: >> >>> On Wed, Apr 13, 2022 at 09:22:59AM +0200, Ivan Vecera wrote: >>>> Previous patch labelled "ice: Fix incorrect locking in >>>> ice_vc_process_vf_msg()" fixed an issue with ignored messages >>> tiny tiny nit: double space after " >>> Also, has mentioned patch landed onto some tree so that we could provide >>> SHA-1 of it? If not, then maybe squashing this one with the mentioned one >>> would make sense? >> Well, that commit were already tested and now it is present in Tony's queue >> but not in upstream yet. It is not problem to squash together but the first >> was about ignored VF messages and this one is about race and I didn't want >> to make single patch with huge description that cover both issues. >> But as I said, no problem to squash if needed. >> >> Thx, >> Ivan > I'm fine with either squashing or keeping them as separate changes. Either way sounds ok to me as they are different types of changes. Thanks, Tony