From: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
To: Matt Vollrath <tactii@gmail.com>, intel-wired-lan@osuosl.org
Cc: Kohei Enju <kohei@enjuk.jp>, stable@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2] i40e: Cleanup PTP pins on probe failure
Date: Tue, 14 Apr 2026 12:26:28 +0200 [thread overview]
Message-ID: <9efe2c87-fbe4-4adc-ae15-7acb3c8fe26a@linux.intel.com> (raw)
In-Reply-To: <20260407161447.43645-1-tactii@gmail.com>
On 2026-04-07 6:14 PM, Matt Vollrath wrote:
> PTP pin structs are allocated early in probe, but never cleaned up.
>
> Fix this by calling i40e_ptp_free_pins in the error path.
>
> To support this, i40e_ptp_free_pins is added to the header and
> pin_config is correctly nullified after being freed.
>
> This has been an issue since i40e_ptp_alloc_pins was introduced.
>
> Fixes: 1050713026a08 ("i40e: add support for PTP external synchronization clock")
> Reported-by: Kohei Enju <kohei@enjuk.jp>
> Cc: stable@vger.kernel.org
> Signed-off-by: Matt Vollrath <tactii@gmail.com>
> ---
Hey Matt,
I wrote a comment on your "[PATCH iwl-net v2] e1000e: Unroll PTP in
probe error handling" submission about the changelog positioning and
CCing stable.
For this patch right here I see the Cc: tag is added correctly to the
commit msg body, but the changelog is inserted in the same way as in the
submission I mentioned above.
Not a blocker by any means, but just wanted to let you know for future
submissions to take this into account.
Thanks
~Dawid
prev parent reply other threads:[~2026-04-14 10:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 16:14 [Intel-wired-lan] [PATCH iwl-net v2] i40e: Cleanup PTP pins on probe failure Matt Vollrath
2026-04-07 16:31 ` Paul Menzel
2026-04-08 6:36 ` Loktionov, Aleksandr
2026-04-08 12:40 ` Kohei Enju
2026-04-14 10:26 ` Dawid Osuchowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9efe2c87-fbe4-4adc-ae15-7acb3c8fe26a@linux.intel.com \
--to=dawid.osuchowski@linux.intel.com \
--cc=intel-wired-lan@osuosl.org \
--cc=kohei@enjuk.jp \
--cc=stable@vger.kernel.org \
--cc=tactii@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox