intel-wired-lan.osuosl.org archive mirror
 help / color / mirror / Atom feed
From: Cody Haas <chaas@riotgames.com>
To: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
	 przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch,
	davem@davemloft.net,  kuba@kernel.org, pabeni@redhat.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-next 1/1] ice: Fix persistent failure in ice_get_rxfh
Date: Fri, 12 Dec 2025 10:03:44 -0800	[thread overview]
Message-ID: <CAH7f-UKky3CCzDXB42eyCagBMLML-0isyQpf5iW0sFMoEE9Ymw@mail.gmail.com> (raw)
In-Reply-To: <fb53b7bf-9d4e-4492-9d99-90e7e8105205@linux.intel.com>

Thanks for the review, Dawid,

On Tue, Dec 9, 2025 at 12:51 AM Dawid Osuchowski
<dawid.osuchowski@linux.intel.com> wrote:
> typo s/iotctl/ioctl

Acked — I'll go ahead and fix this.

> punctuation: missing space after "For example,"

I'll fix this as well.

> nit: in function arguments "seed" appears first, maybe consider
> switching the order of the if statements so they appear in the same
> order as in function declaration? It would also match the i40e
> implementation then

Same with this one. Thanks for taking the time to review it.

Cody

      reply	other threads:[~2025-12-12 18:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-03 18:49 [Intel-wired-lan] [PATCH iwl-next 0/1] ice: Fix persistent failure in ice_get_rxfh Cody Haas
2025-12-03 18:49 ` [Intel-wired-lan] [PATCH iwl-next 1/1] " Cody Haas
2025-12-05 10:36   ` Przemek Kitszel
2025-12-10  0:57     ` Cody Haas
2025-12-09  8:51   ` Dawid Osuchowski
2025-12-12 18:03     ` Cody Haas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAH7f-UKky3CCzDXB42eyCagBMLML-0isyQpf5iW0sFMoEE9Ymw@mail.gmail.com \
    --to=chaas@riotgames.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=dawid.osuchowski@linux.intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).