[Intel-wired-lan] [PATCH] igb: reset the PHY before reading the PHY ID

[Matwey V. Kornilov <matwey@sai.msu.ru>]

2016-12-02 2:17 GMT+03:00 Chris Arges <carges@vectranetworks.com>:
> ________________________________________
> From: Aaron Sierra <asierra@xes-inc.com>
> Sent: Thursday, December 1, 2016 10:19 AM
> To: Chris Arges
> Cc: Jeffrey T Kirsher; Matwey V. Kornilov; Jochen Henneberg; intel-wired-lan
> Subject: Re: [PATCH] igb: reset the PHY before reading the PHY ID
>
> ----- Original Message -----
>> From: "Chris Arges" <carges@vectranetworks.com>
>> Sent: Wednesday, November 30, 2016 9:13:18 PM
>>
>> Hi,
>> I could not get this patch to fix the original issue I had.
>> The patch I submitted a while back fixed the issue for me:
>> https://patchwork.ozlabs.org/patch/690464/
>>
>> Let me know if there is something else I can get check here. To reproduce
>> I have to fully power off the server which contains this NIC.
>> --chris
>>
>
> Chris,
> Can you provide any more information about your environment than you
> already have? I've only found that you're using an I210. Is it embedded
> in the baseboard or an add-in device? Please share very verbose lspci
> output for this device:
>
>     lspci -vvv -n -s <[bus]:[device].[function]>
>
> What kernel version did you use in your testing? Did my patch apply
> cleanly or with "fuzz" reported by the patch command?
>
> -Aaron S.
>
> Aaron,
> I applied your patch cleanly against 4.4 (testing this on Ubuntu 16.04 fwiw) which I think didn't backport well. Using mainline 4.9rcX I was able to get your patch working. Would there be a recommended modification for a stable patch?
>

2a3cdead8b4083 ("igb: Remove GS40G specific defines/functions") has
been applied in 4.5 AFAIU. Why do you test fixing patch at 4.4?


> For completeness,
> $ lspci -vvv -n -s 07:00.0
> 07:00.0 0200: 8086:1533 (rev 03)
>         Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+
>         Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
>         Latency: 0, Cache Line Size: 128 bytes
>         Interrupt: pin A routed to IRQ 16
>         Region 0: Memory at 91200000 (32-bit, non-prefetchable) [size=512K]
>         Region 2: I/O ports at 3000 [size=32]
>         Region 3: Memory at 91280000 (32-bit, non-prefetchable) [size=16K]
>         Capabilities: <access denied>
>         Kernel driver in use: igb
>         Kernel modules: igb
>
> Thanks,
> --chris



-- 
With best regards,
Matwey V. Kornilov.
Sternberg Astronomical Institute, Lomonosov Moscow State University, Russia
119991, Moscow, Universitetsky pr-k 13, +7 (495) 9392382