From: "Rustad, Mark D" <mark.d.rustad@intel.com>
To: "Venkataramanan, Anirudh" <anirudh.venkataramanan@intel.com>
Cc: "intel-wired-lan@osuosl.org" <intel-wired-lan@osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH net-next v2] ice: Allow 100M speeds for some devices
Date: Thu, 11 Aug 2022 00:10:14 +0000 [thread overview]
Message-ID: <E98612EF-23CD-4FF2-9953-B4CD8815C1E1@intel.com> (raw)
In-Reply-To: <b7b6c6b8-58d3-2aed-7124-44ce585ef783@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 1068 bytes --]
> On Aug 8, 2022, at 10:44 AM, Anirudh Venkataramanan <anirudh.venkataramanan@intel.com> wrote:
>
>>> diff --git a/drivers/net/ethernet/intel/ice/ice_common.h b/drivers/net/ethernet/intel/ice/ice_common.h
>>> index a74df1d3a002..2734296bdd3b 100644
>>> --- a/drivers/net/ethernet/intel/ice/ice_common.h
>>> +++ b/drivers/net/ethernet/intel/ice/ice_common.h
>>> @@ -205,6 +205,7 @@ ice_aq_set_gpio(struct ice_hw *hw, u16 gpio_ctrl_handle, u8 pin_idx, bool value,
>>> int
>>> ice_aq_get_gpio(struct ice_hw *hw, u16 gpio_ctrl_handle, u8 pin_idx,
>>> bool *value, struct ice_sq_cd *cd);
>>> +bool ice_is_100m_speed_supported(struct ice_hw *hw);
>> I’d name it `is_100mbits_supported`.
>
> Naming is a bit subjective I suppose. As long as the function name is sensible and readable, it's fine.
>
> To each their own I suppose. :-)
It really is better to always have the driver prefix on symbols to avoid any possible namespace clashes. So, it is best as it was in this case.
--
Mark Rustad (he/him), Ethernet Products Group, Intel Corporation
[-- Attachment #1.2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 873 bytes --]
[-- Attachment #2: Type: text/plain, Size: 162 bytes --]
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2022-08-11 0:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 19:23 [Intel-wired-lan] [PATCH net-next v2] ice: Allow 100M speeds for some devices Mikael Barsehyan
2022-07-29 17:51 ` Tony Nguyen
2022-08-02 6:48 ` Paul Menzel
2022-08-08 17:44 ` Anirudh Venkataramanan
2022-08-11 0:10 ` Rustad, Mark D [this message]
2022-08-12 8:12 ` Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E98612EF-23CD-4FF2-9953-B4CD8815C1E1@intel.com \
--to=mark.d.rustad@intel.com \
--cc=anirudh.venkataramanan@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox