From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Intel Wired LAN <intel-wired-lan@lists.osuosl.org>,
Anthony Nguyen <anthony.l.nguyen@intel.com>
Subject: Re: [Intel-wired-lan] [net-next] ice: remove comment about not supporting driver reinit
Date: Tue, 28 Feb 2023 06:42:55 +0100 [thread overview]
Message-ID: <Y/2UX7qZoDaQgmqZ@localhost.localdomain> (raw)
In-Reply-To: <20230227221500.3692237-1-jacob.e.keller@intel.com>
On Mon, Feb 27, 2023 at 02:15:00PM -0800, Jacob Keller wrote:
> Since commit 31c8db2c4fa7 ("ice: implement devlink reinit action"), the ice
> driver does support driver re-initialization via devlink reload. Remove the
> stale comment indicating that the driver lacks this support from the
> ice_devlink_ops structure.
>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> Cc: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_devlink.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_devlink.c b/drivers/net/ethernet/intel/ice/ice_devlink.c
> index 05f216af8c81..bc44cc220818 100644
> --- a/drivers/net/ethernet/intel/ice/ice_devlink.c
> +++ b/drivers/net/ethernet/intel/ice/ice_devlink.c
> @@ -1254,7 +1254,6 @@ static const struct devlink_ops ice_devlink_ops = {
> .supported_flash_update_params = DEVLINK_SUPPORT_FLASH_UPDATE_OVERWRITE_MASK,
> .reload_actions = BIT(DEVLINK_RELOAD_ACTION_DRIVER_REINIT) |
> BIT(DEVLINK_RELOAD_ACTION_FW_ACTIVATE),
> - /* The ice driver currently does not support driver reinit */
> .reload_down = ice_devlink_reload_down,
> .reload_up = ice_devlink_reload_up,
> .port_split = ice_devlink_port_split,
>
> base-commit: f75ed9add58c1bca6a615609a0f7f148c257e3c7
> --
Thanks for fixing it.
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> 2.39.1.405.gd4c25cc71f83
>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
prev parent reply other threads:[~2023-02-28 5:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 22:15 [Intel-wired-lan] [net-next] ice: remove comment about not supporting driver reinit Jacob Keller
2023-02-28 5:42 ` Michal Swiatkowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/2UX7qZoDaQgmqZ@localhost.localdomain \
--to=michal.swiatkowski@linux.intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox