From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18A62C636D3 for ; Mon, 6 Feb 2023 20:22:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 9329A4088A; Mon, 6 Feb 2023 20:22:13 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 9329A4088A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1675714933; bh=P62GlqB6eV0oW6m+eEQS9KoynY13jA0hglIu5oh+Vh8=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=d5tB29sBtWQg3YiEkL+y8eGHhA3VYg1hhNFk405CE3EsxocqyiDuxTiCZJq3TZTz1 lBydlJVstJqNwFfkhCv31lnO/JEHnlwmiJGLFqOxdK2yaFlLXI/yhucJ0DVT8jf5f2 o5haabG8vT17pkaLodwDnY9hl1RJm9dlwfbc3vnhIwbP1I9efXWJPfrb58s2YoBZHw 7KhkDD0RkICEzmzgtCbPHc9WkJASIHUDKajNZX6EEa8ny2gc6w7iYUM85lrKjG4snB L0FZcJ3LNuWEPtkx33qjITV0eYgOFviMo9v9v0fT42NjXJFZGSWpn3vLoCSxYjGXHc fKYZrDTXf54/Q== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YrY81rMf3O7v; Mon, 6 Feb 2023 20:22:12 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 4B6144069B; Mon, 6 Feb 2023 20:22:12 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4B6144069B Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 811CB1BF328 for ; Mon, 6 Feb 2023 20:22:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 66D9A40119 for ; Mon, 6 Feb 2023 20:22:10 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 66D9A40119 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s5xADSKu6UiH for ; Mon, 6 Feb 2023 20:22:09 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 1679D400A4 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by smtp2.osuosl.org (Postfix) with ESMTPS id 1679D400A4 for ; Mon, 6 Feb 2023 20:22:09 +0000 (UTC) Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pP7zf-004EiV-Vm; Mon, 06 Feb 2023 21:21:39 +0100 Date: Mon, 6 Feb 2023 21:21:39 +0100 From: Andrew Lunn To: Oleksij Rempel Message-ID: References: <20230201145845.2312060-1-o.rempel@pengutronix.de> <20230204001332.dd4oq4nxqzmuhmb2@skbuf> <20230206054713.GD12366@pengutronix.de> <20230206141038.vp5pdkjyco6pyosl@skbuf> <20230206183706.GH12366@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230206183706.GH12366@pengutronix.de> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=UPMS4+GiWA1iXl0wn+OuZDqgqDg2WCg1eOAbQZg4o/A=; b=Ufqok60DPuutPt3mZYvVllAdpr vqgARf95i+7li7VXd+qCF+uMbh2gHzJVjuZA1Ce6sLoNVs+80/oC3ParNoDOi4sm4gnGfk6qLrOUI Nn399vQObd78Z/8hNeIDFWSJWioVLKXGC+qRO8fTJjjvr7UT+2XeZ/h4NqG7RhOC1EVM=; X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.a=rsa-sha256 header.s=20171124 header.b=Ufqok60D Subject: Re: [Intel-wired-lan] [PATCH net-next v4 00/23] net: add EEE support for KSZ9477 and AR8035 with i.MX6 X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Woojung Huh , Arun.Ramadoss@microchip.com, Florian Fainelli , "David S. Miller" , netdev@vger.kernel.org, Richard Cochran , linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com, Eric Dumazet , Paolo Abeni , Wei Fang , kernel@pengutronix.de, intel-wired-lan@lists.osuosl.org, Jakub Kicinski , Vladimir Oltean , Vivien Didelot , Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" > SmartEEE will be probably a bit more challenging. If MAC do not > advertise EEE support, SmartEEE can be enabled. But it would break PTP > if SmartEEE is active. Except SmartEEE capable PHY implements own PTP > support. In any case, user space will need extra information to > identify potential issues. If we have a MAC driver which does not implement the ethtool set_eee() and get_eee() ops, and a dev->phydev with the SmartEEE flag set, we could have net/ethtool/eee.c call direct into phylib. As for PTP and EEE, maybe we want the core PTP code to try calling get_eee() and at minimum issue a warning if it is enabled, if it thinks MAC PTP is being used? Andrew _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan