From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43416C61DA4 for ; Tue, 7 Feb 2023 00:54:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id D79EA81A33; Tue, 7 Feb 2023 00:54:51 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org D79EA81A33 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1675731291; bh=1QvLtvO6FLO/1K4LuBY+F61K6an6ONUdEMEk48hj7vk=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=7vnK50cM4Fbum+j3bEC3QvXLXLMwMABidvuloweved8zZVs9s+OWU8ZBgYkdBL+rt Xn4NJNT8Th/Uh9rJIJVTBqvTHkm8HGISRF1dNdt8IsM0bRB1i1C/jX0zhN2MwZbvs+ tHnKHmNpt9gfkN1ENaP9LVX0/uM49FCmlzA8n2EdJqJqaVYQoKd0W8oXJh5DD0wjlv qSikHSP+drIvkZzUsmsW7gNB+S/mGsDB0DQdWPiB3DS+EszpCgYbOogX2MqRpLUO0T mfwuuVCbi79/cHz+VAZkO1J91p70gMPM6gEVOy2V7mgmpnwjRVm6fB3y9LLuCvk9OW 56J2t1ZEzDEFA== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id p5B_4pm0__nJ; Tue, 7 Feb 2023 00:54:51 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id ED6FF81A39; Tue, 7 Feb 2023 00:54:50 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org ED6FF81A39 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 1548D1BF3F2 for ; Tue, 7 Feb 2023 00:54:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id EDFBD81A33 for ; Tue, 7 Feb 2023 00:54:48 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org EDFBD81A33 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SJ4PATl5UZzn for ; Tue, 7 Feb 2023 00:54:48 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 558F181A39 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by smtp1.osuosl.org (Postfix) with ESMTPS id 558F181A39 for ; Tue, 7 Feb 2023 00:54:48 +0000 (UTC) Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pPCFo-004FkA-DG; Tue, 07 Feb 2023 01:54:36 +0100 Date: Tue, 7 Feb 2023 01:54:36 +0100 From: Andrew Lunn To: Oleksij Rempel Message-ID: References: <20230206135050.3237952-1-o.rempel@pengutronix.de> <20230206135050.3237952-9-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230206135050.3237952-9-o.rempel@pengutronix.de> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=4CrvK76rrD+R3wcfuu8uheBctEOoX8lxcQWUqv+cAh0=; b=xqmzBiYavYtrBVnALt2wa6aAIu IbQWkl2TsFyF1xQp/cJFF2mlLS9i0yJRGAe3kHk6pumq66hiXIAjirEDVZXUHX6osgpjx8MU4lkZv nC8nU1226Ah229BaBzEyPTYF7Ayxfp20diFWAvDDdSiQbNMUmj0aLl70F2iXoriPhIMg=; X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.a=rsa-sha256 header.s=20171124 header.b=xqmzBiYa Subject: Re: [Intel-wired-lan] [PATCH net-next v5 08/23] net: phy: migrate phy_init_eee() to genphy_c45_eee_is_active() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Woojung Huh , Arun.Ramadoss@microchip.com, Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Vivien Didelot , UNGLinuxDriver@microchip.com, Eric Dumazet , Paolo Abeni , Wei Fang , kernel@pengutronix.de, intel-wired-lan@lists.osuosl.org, Jakub Kicinski , Vladimir Oltean , "David S. Miller" , Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Feb 06, 2023 at 02:50:35PM +0100, Oleksij Rempel wrote: > Reduce code duplicated by migrating phy_init_eee() to > genphy_c45_eee_is_active(). > > Signed-off-by: Oleksij Rempel This makes sense, but as i said in a different thread, i think the MAC/PHY API needs improving at some point, which could result in this function going away. But this patchset is big enough as it is. Reviewed-by: Andrew Lunn Andrew _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan