From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7B85C05027 for ; Tue, 7 Feb 2023 01:05:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 6CC3E405C2; Tue, 7 Feb 2023 01:05:59 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 6CC3E405C2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1675731959; bh=Kkoy7mlE60rayUVp/ghZ2wehiuTZM0TQ17bf5nKMgqg=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=kuoD9II3BEh9HWK3LhR1J3T7pvXOV1P0DWm/w4E0aXayAkjju5+k7Qv+KaxhqDjwV me5S1sxK2+HclBc/EUVvdQStDFrhytOOHU8cVWf4Nfr3o/alY8ST8diU9KcuV0OLKr vL02USZQw+0nykFB9yNmN7TpU7wax6SpFAeS3fb5EVYK7K5KaI0Di1IwD3k2MF+n44 36ReTjSlT4iQdr2fOSu+XryJ1nOgH+5TC515eqeJoKtl3GChMMqy26tyv/CfJd7SCi KeWseNoZ41vJqhXJKD4k5TIm97XfkuubDlrcmooVWP7krcvWLVvWzGEjwQ34gKRQeR BmkvcXLlcyHCw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uBlEbkYyc-rN; Tue, 7 Feb 2023 01:05:58 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 6A3B440494; Tue, 7 Feb 2023 01:05:58 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 6A3B440494 Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id B5BD31BF2BB for ; Tue, 7 Feb 2023 01:05:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 8D96660D56 for ; Tue, 7 Feb 2023 01:05:57 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8D96660D56 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EgHj05tjQVZN for ; Tue, 7 Feb 2023 01:05:57 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org DCBAF60BE1 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by smtp3.osuosl.org (Postfix) with ESMTPS id DCBAF60BE1 for ; Tue, 7 Feb 2023 01:05:56 +0000 (UTC) Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pPCQa-004Fla-MG; Tue, 07 Feb 2023 02:05:44 +0100 Date: Tue, 7 Feb 2023 02:05:44 +0100 From: Andrew Lunn To: Oleksij Rempel Message-ID: References: <20230206135050.3237952-1-o.rempel@pengutronix.de> <20230206135050.3237952-10-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230206135050.3237952-10-o.rempel@pengutronix.de> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=Kxgr1Z+G7gEE1M9r6++laPaamK40cZIEw/H+lncP1PM=; b=4zZHJVYQpVwmLV0hD9lEw5sI7O KoK+b2mWoTseGq6EWYfuQCXIX77rxAlXHVpdje7RWVRepY+yy/dptbfLpA4aiXgzQ4XWGKkEqrtqj Y+FBGh4lHoso5KiC3FcjN/iNk3l1GczFnCFBROM09n8MXQs2NvZwuPDjlGVydQcpK5DI=; X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.a=rsa-sha256 header.s=20171124 header.b=4zZHJVYQ Subject: Re: [Intel-wired-lan] [PATCH net-next v5 09/23] net: phy: start using genphy_c45_ethtool_get/set_eee() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Woojung Huh , Arun.Ramadoss@microchip.com, Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Vivien Didelot , UNGLinuxDriver@microchip.com, Eric Dumazet , Paolo Abeni , Wei Fang , kernel@pengutronix.de, intel-wired-lan@lists.osuosl.org, Jakub Kicinski , Vladimir Oltean , "David S. Miller" , Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Feb 06, 2023 at 02:50:36PM +0100, Oleksij Rempel wrote: > All preparations are done. Now we can start using new functions and remove > the old code. > > Signed-off-by: Oleksij Rempel This change looks correct, in that it just replaces code with other equivalent code. But looking at it, i started to wonder about locking. I don't see phydev->lock held anywhere. But it does access members of phydev, in particular speed and duplex. If the PHY state machine is running at the same time, and phy_read_status() is called, those members can contain invalid information. So i think another patch is needed to add locking to these two functions. Otherwise: Reviewed-by: Andrew Lunn Andrew _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan