From: Saeed Mahameed <saeed@kernel.org>
To: Shang XiaoJing <shangxiaojing@huawei.com>
Cc: intel-wired-lan@lists.osuosl.org, edumazet@google.com,
jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org,
kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH] ixgbevf: Fix resource leak in ixgbevf_init_module()
Date: Tue, 15 Nov 2022 12:48:15 -0800 [thread overview]
Message-ID: <Y3P7Dzw4OWDxb33S@x130.lan> (raw)
In-Reply-To: <20221114025758.9427-1-shangxiaojing@huawei.com>
On 14 Nov 10:57, Shang XiaoJing wrote:
>ixgbevf_init_module() won't destroy the workqueue created by
>create_singlethread_workqueue() when pci_register_driver() failed. Add
>destroy_workqueue() in fail path to prevent the resource leak.
>
>Similar to the handling of u132_hcd_init in commit f276e002793c
>("usb: u132-hcd: fix resource leak")
>
>Fixes: 40a13e2493c9 ("ixgbevf: Use a private workqueue to avoid certain possible hangs")
>Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Reviewed-by: Saeed Mahameed <saeed@kernel.org>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2022-11-15 20:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 2:57 [Intel-wired-lan] [PATCH] ixgbevf: Fix resource leak in ixgbevf_init_module() Shang XiaoJing
2022-11-15 20:48 ` Saeed Mahameed [this message]
2022-11-22 11:43 ` Jankowski, Konrad0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3P7Dzw4OWDxb33S@x130.lan \
--to=saeed@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shangxiaojing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox