From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BE21C4332F for ; Tue, 29 Nov 2022 08:25:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 54787416F5; Tue, 29 Nov 2022 08:25:08 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 54787416F5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1669710308; bh=Fzn1y4OUp31aWNqQ5gx02tgjkWdxfrJb7aQgO+ksgTc=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=j0XflqTok6GSaZfED/oYPCLJhDeos1BTX3bRTOhF5zHH2W2fjCguU8TFIdnQ1Vc4i icTwdwobscEXY1iqBBruwIy+crQPvX7B6dxnqPUMZ5+IdlJLY9YjjmeKmVc02A/+M4 TIP7yyB2NI0tLsqcuiPSdW2VMwJWa98MOhKcyigGo7hSpxUi6de0EEceltS/gnpQqi YXAKRPIOEI+dmyl3fI2p7qcgpDOIOOM0BtK9ExvArYX8z5ecLU/x5rjvsKldCblZT7 td3upursdbKHZOi63Kd3kZoEzhe9rFWaohfjCshwtF2+C7iJXaddJJo5ooe2tRpJy5 csK9SgzuvZePw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id F6icLW63JtT8; Tue, 29 Nov 2022 08:25:06 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id AAC4F41600; Tue, 29 Nov 2022 08:25:05 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org AAC4F41600 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 050001BF21A for ; Tue, 29 Nov 2022 08:25:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id D2A978145F for ; Tue, 29 Nov 2022 08:25:03 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org D2A978145F X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id boJePhfZU4zu for ; Tue, 29 Nov 2022 08:25:02 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 569F58145C Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by smtp1.osuosl.org (Postfix) with ESMTPS id 569F58145C for ; Tue, 29 Nov 2022 08:25:01 +0000 (UTC) Received: by mail-ej1-x629.google.com with SMTP id vp12so30631271ejc.8 for ; Tue, 29 Nov 2022 00:25:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Gzwrz5/bgJ69VQ8DIOQyNt2ySo14PkY0Tc1TJ/9BxtU=; b=KD73RbxPjmMpHkh6FfQ2Yn8lGQTGtQm8muO/mZwbc1UUyYkMWgBdnIczHDi6R0p7SW i7aWPbN2/X/nuN1SAgpbGMeV4h+zvhnW3xag0HoZW7oHrfwRehqCIGoG53CFtNgmv/4W 267hGAn91I8dL0xEoLfEfNf9/xndmmw978YIEqHCqauPmiuCcVrNaUChqcK4AkgzdRnC obC62iryLYmEWFTguF6ld7QXY2msVhEGhczBGXAlx2dRUM9a2WssSZiqpVijoii73KXQ YyKoDIBNPYEvxPzZJ7urXxb0QCQOH54jtDbJFVWw9O+Fk6IbXDNxYcu9JZFuccGcmrTX gmCg== X-Gm-Message-State: ANoB5pm7166HLl4895KKC2uTUkvneU9paz21YIoF9Kf9/UFoTZT7eb2s i0pOLX/+ShynKvjVZw6d27D+PQ== X-Google-Smtp-Source: AA0mqf5U6UpqaqLYePD0J8IkftyUluGt51ht3yzDWcsXRz6dM4R3R53yD09NYzQvvlp1i1fCn6EMtQ== X-Received: by 2002:a17:906:2645:b0:781:d0c1:4434 with SMTP id i5-20020a170906264500b00781d0c14434mr46698718ejc.756.1669710300002; Tue, 29 Nov 2022 00:25:00 -0800 (PST) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id sa21-20020a1709076d1500b007aec1b39478sm5874240ejc.188.2022.11.29.00.24.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Nov 2022 00:24:59 -0800 (PST) Date: Tue, 29 Nov 2022 09:24:58 +0100 From: Jiri Pirko To: Vincent Mailhol Message-ID: References: <20221129000550.3833570-1-mailhol.vincent@wanadoo.fr> <20221129000550.3833570-2-mailhol.vincent@wanadoo.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221129000550.3833570-2-mailhol.vincent@wanadoo.fr> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Gzwrz5/bgJ69VQ8DIOQyNt2ySo14PkY0Tc1TJ/9BxtU=; b=C3d56JtyuNmf974ceEZSavZ1C/FjLRkloGMeX8+h55kDGiXpMMFI1DD4u3feCh4QEE cHA8xuvglY036UQI7H2YQDycFuUAB+Ib26AaNO9jH79I+9iDbRng+Ef7bpZRqFL7xNvT SY8/h8Tq9x1BtXmeT4cenlPJaDiZZKqt7rUqubucGzlpVqsEFbubxrWdx8hjJGh9HFKI VWWvLBBFn5NGDr4OxwMmW2GFst9UcAyIQNWpvHjljD1grLS1hBIkQpasnV1Ykn1nRN8G mHEkyjZbboo827d2YV+/hiHg/UYb6Oq2UWQS3y69VPrqAzY4s2/UVC3JbUtvZ/MrgXD+ NTPQ== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=resnulli-us.20210112.gappssmtp.com header.i=@resnulli-us.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=C3d56Jty Subject: Re: [Intel-wired-lan] [PATCH net-next v5 1/4] net: devlink: let the core report the driver name instead of the drivers X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Shijith Thotton , Simon Horman , Kurt Kanzenbach , Eric Dumazet , Subbaraya Sundeep , Ioana Ciornei , drivers@pensando.io, Linu Cherian , Florian Fainelli , Herbert Xu , Leon Romanovsky , linux-rdma@vger.kernel.org, Shalom Toledo , Srujana Challa , Minghao Chi , Hao Chen , Guangbin Huang , Shannon Nelson , intel-wired-lan@lists.osuosl.org, Jakub Kicinski , Vadim Fedorenko , Paolo Abeni , Yisen Zhuang , Sunil Goutham , Ariel Elior , Ido Schimmel , Richard Cochran , Arnaud Ebalard , Jiri Pirko , Jiri Pirko , Michael Chan , Petr Machata , Salil Mehta , Dimitris Michailidis , Manish Chopra , Boris Brezillon , netdev@vger.kernel.org, oss-drivers@corigine.com, Vadim Pasternak , linux-kernel@vger.kernel.org, Geetha sowjanya , Taras Chornyi , hariprasad , linux-crypto@vger.kernel.org, Jonathan Lemon , Jerin Jacob , Vladimir Oltean , Saeed Mahameed , "David S . Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Tue, Nov 29, 2022 at 01:05:47AM CET, mailhol.vincent@wanadoo.fr wrote: >The driver name is available in device_driver::name. Right now, >drivers still have to report this piece of information themselves in >their devlink_ops::info_get callback function. > >In order to factorize code, make devlink_nl_info_fill() add the driver >name attribute. > >nla_put() does not check if an attribute already exists and >unconditionally reserves new space [1]. To avoid attribute >duplication, clean-up all the drivers which are currently reporting >the driver name in their callback. This para with the link below should be removed, no need for it. Otherwise, code looks fine. Reviewed-by: Jiri Pirko _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan