From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4133C4332F for ; Tue, 29 Nov 2022 08:26:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 765C540132; Tue, 29 Nov 2022 08:26:42 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 765C540132 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1669710402; bh=OHK6/TxWUB4Ica2JGc4k/NyRYZCm5nDCMJ9dp2EDBzk=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=r/xwHuce+apPzaO2sr4cnLlzLA5ZgJZ3PRZ9SXGbABqInNZuLUowx2J9SlAJiBhVB YArcKJxBcPLIe81fk6xXAqtnFD4P2kfzA0Mw9s9YLCW2Ve7M4BXXau8fuoASnvidG/ ZlsGMVHwtT72EDTm+/IusSPIQHK/wrNtwlvzUK5KHjEOe9vKp6Bm2NJz51gpoGQtA+ L40d3Kh7viR2wBajWAvRdV4Ul+qE6USjhJr2V9MCD9sDSxAH/Ps9spPBgRgksoXX2C gZrgU3P3TTlCf0Nv7pe9w9nj5Q0C8ycLVg3YP2gmfpILkoyTRIDLoRFMya6/sFgGmx XCs7sE2saFpzQ== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fgYnLHtD1v4t; Tue, 29 Nov 2022 08:26:41 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 83412402D0; Tue, 29 Nov 2022 08:26:41 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 83412402D0 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 524461BF2C6 for ; Tue, 29 Nov 2022 08:26:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 38119408E1 for ; Tue, 29 Nov 2022 08:26:40 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 38119408E1 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sxfObTvWTaCV for ; Tue, 29 Nov 2022 08:26:39 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 12E05408CE Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by smtp4.osuosl.org (Postfix) with ESMTPS id 12E05408CE for ; Tue, 29 Nov 2022 08:26:38 +0000 (UTC) Received: by mail-ed1-x530.google.com with SMTP id x2so18764602edd.2 for ; Tue, 29 Nov 2022 00:26:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pgrzkkklPcAQYmyQMmCpEE1o3a9ohgeq3WVDc+0vm08=; b=8I8dDoC6ZstF8Af9XVmN0xVwGKAqLVzdCGsLTsnMgPWe8BtDGBX/y3jkHUD20/bebG xCtAzhEcyW+C5uqjdWEeaHMDTnB85HILpvhafzbuhb7PRlWb2nE97EvXTcWU+K9YZgm/ O40UsoXzL6j949ZYjJ1/h1cMq17yWZ5OlVaKK0+TlMf007engZeJjugJUD+WzHLRy5c5 2c5jpXMvn/dupDVEQN+bnPqPEIKa7CoFcb+hwD1b+JXD0rGQaRSjyJB21yn/WFlnvD1/ yiz+X33wduoLMpiuAmTiIBwx81f8Bb/VZdk0HFHF3cNI1UJeqG9dPui++TvV2Py9EFf3 ypqg== X-Gm-Message-State: ANoB5pkHdFWcIfvjZcDpgSz2ikvsW+QzSRYyKFmXyiQCxK6By1Wpsc7k CaAnxaHOQFOq9i3bIABzWIEzFA== X-Google-Smtp-Source: AA0mqf6AhCTZUtOfuGYDhXfqaKP0HI3CcryljG1Et3fvW7wqzGVxjYaxttb++c6crBKvAOdrZVKVcw== X-Received: by 2002:a05:6402:1f14:b0:461:c7ef:b09e with SMTP id b20-20020a0564021f1400b00461c7efb09emr37432404edb.58.1669710397245; Tue, 29 Nov 2022 00:26:37 -0800 (PST) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id r9-20020a50aac9000000b00461c6e8453dsm6017247edc.23.2022.11.29.00.26.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Nov 2022 00:26:36 -0800 (PST) Date: Tue, 29 Nov 2022 09:26:35 +0100 From: Jiri Pirko To: Vincent Mailhol Message-ID: References: <20221129000550.3833570-1-mailhol.vincent@wanadoo.fr> <20221129000550.3833570-4-mailhol.vincent@wanadoo.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221129000550.3833570-4-mailhol.vincent@wanadoo.fr> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pgrzkkklPcAQYmyQMmCpEE1o3a9ohgeq3WVDc+0vm08=; b=XiAjLYS5j4RwLKJGZxfsDINusHr9CRwW/Y3flS/dZFlY4O60OTBiKSUQjxvGIX+3Rg dWAJ1ca2t+K0d+bi0hYAhKvXStoidmphxQ0TDLO6BSnIL0/DN3PnlJFDIMFRt3mXIa4g ZMPEl75jJykR9z7KbG5TQ2wepgiS9FlevG8+O0tg70kUd7KYg2ugRDQg84wgWnAptk9T NHGqa/dI8nJ2hDhtgvRxfieYv/2wyABK91GuDzW2R+fCWgqEG0yJvCUyqY3kdcbZmt0P gS7yCTuTDX6ORTNxuGB1qv1ErmB0M7sxgSP6i5oaQm/rCTvkHAkTwlvZFSa7282d1MRL RrTA== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=resnulli-us.20210112.gappssmtp.com header.i=@resnulli-us.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=XiAjLYS5 Subject: Re: [Intel-wired-lan] [PATCH net-next v5 3/4] net: devlink: make the devlink_ops::info_get() callback optional X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Shijith Thotton , Simon Horman , Kurt Kanzenbach , Eric Dumazet , Subbaraya Sundeep , Ioana Ciornei , drivers@pensando.io, Linu Cherian , Florian Fainelli , Herbert Xu , Leon Romanovsky , linux-rdma@vger.kernel.org, Shalom Toledo , Srujana Challa , Minghao Chi , Hao Chen , Guangbin Huang , Shannon Nelson , intel-wired-lan@lists.osuosl.org, Jakub Kicinski , Vadim Fedorenko , Paolo Abeni , Yisen Zhuang , Sunil Goutham , Ariel Elior , Ido Schimmel , Richard Cochran , Arnaud Ebalard , Jiri Pirko , Jiri Pirko , Michael Chan , Petr Machata , Salil Mehta , Dimitris Michailidis , Manish Chopra , Boris Brezillon , netdev@vger.kernel.org, oss-drivers@corigine.com, Vadim Pasternak , linux-kernel@vger.kernel.org, Geetha sowjanya , Taras Chornyi , hariprasad , linux-crypto@vger.kernel.org, Jonathan Lemon , Jerin Jacob , Vladimir Oltean , Saeed Mahameed , "David S . Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Tue, Nov 29, 2022 at 01:05:49AM CET, mailhol.vincent@wanadoo.fr wrote: >Some drivers only reported the driver name in their >devlink_ops::info_get() callback. Now that the core provides this >information, the callback became empty. For such drivers, just >removing the callback would prevent the core from executing >devlink_nl_info_fill() meaning that "devlink dev info" would not >return anything. > >Make the callback function optional by executing >devlink_nl_info_fill() even if devlink_ops::info_get() is NULL. > >N.B.: the drivers with devlink support which previously did not >implement devlink_ops::info_get() will now also be able to report >the driver name. > >Signed-off-by: Vincent Mailhol Reviewed-by: Jiri Pirko _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan