From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24916C4332F for ; Tue, 20 Dec 2022 07:50:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id A8DEE818C4; Tue, 20 Dec 2022 07:50:44 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org A8DEE818C4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1671522644; bh=Q1494joUkLjQwBWGYeycya3kPm+gr0KH24w8nss6HY4=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=7mnNacOS1LjpkeD6HLPnFa15/5VTbyWqNRy2P/NBwjxMGD0zAEdPHl4+KeVC2PjIH DB/brzqutHTEz4a5cYcPYN95qDsK3o8dQoQEoCp2hqlRJqnZ+ZR5e+76XRiYJVvMv5 C6ueSzRwSOOTxRytTfppCOHwW22S6H/jdPQ1tRY5XNUMyFl+7jhM1xkJnD4AVwXajE /ESRNA8XewcXyS+eCJAWuj2us2fbxge3i+12TTmECucR3sH95S1A7b2i5rydmQ9z+5 ziz9hrw0hjhZh4N8WjFi2RWBA0XcFmhTo+3WXDgC05hC+hLNEzsgvCmf6vzLI9NehX MGD3NPaqK3F5w== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2JfyA6Xm96Se; Tue, 20 Dec 2022 07:50:44 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id CAC2C818C9; Tue, 20 Dec 2022 07:50:43 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org CAC2C818C9 Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id A57F71BF300 for ; Tue, 20 Dec 2022 07:50:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 8C38A60AA0 for ; Tue, 20 Dec 2022 07:50:42 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8C38A60AA0 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TKBiFAVhsGVK for ; Tue, 20 Dec 2022 07:50:42 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org EF57E60A6A Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by smtp3.osuosl.org (Postfix) with ESMTPS id EF57E60A6A for ; Tue, 20 Dec 2022 07:50:41 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="405802824" X-IronPort-AV: E=Sophos;i="5.96,258,1665471600"; d="scan'208";a="405802824" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2022 23:50:41 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="739663471" X-IronPort-AV: E=Sophos;i="5.96,258,1665471600"; d="scan'208";a="739663471" Received: from unknown (HELO localhost.localdomain) ([10.237.112.144]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2022 23:50:38 -0800 Date: Tue, 20 Dec 2022 08:50:28 +0100 From: Michal Swiatkowski To: Daniil Tatianin Message-ID: References: <20221220063246.1593327-1-d-tatianin@yandex-team.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221220063246.1593327-1-d-tatianin@yandex-team.ru> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671522641; x=1703058641; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=y7kzW7wiQHNQKgWsYnF0m+caBPul5zY67fLc8pu5Ed0=; b=VlcdIWfxC4iflPYlY4W+zOn0vjR/B5n76OYcE5nbV2AvKHlbkxkiEtay XdZCLKJkR0tk0NUBhSyP743lwEIQFWCngCdgsua3dtml8Gwq5Em/KR2fY zyrGDGkpHwfgvU6f9kfQqApYqsillZ0i07SEigTu6VVrNZ7ho7CP3XK/5 HYU/ifgUMlc8CEb3+C+RcDEonf3S9xRp9Wzud3G5nVAvNAoJfodpG6wdq xEyKYSrgDu6MTRQYnAjHcFseciknfPJmizjKQtAmFBVGf7lTMbr8f/e1/ fMDwoi6XpeCJbb0r4NVH44LtfpfFfV6Eom9GOwKpNCJzmfYyKEfDyXwBx A==; X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=VlcdIWfx Subject: Re: [Intel-wired-lan] [PATCH v2] iavf/iavf_main: actually log ->src mask when talking about it X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-wired-lan@lists.osuosl.org, Jesse Brandeburg , linux-kernel@vger.kernel.org, Eric Dumazet , Tony Nguyen , Jeff Kirsher , netdev@vger.kernel.org, Jakub Kicinski , Paolo Abeni Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Dec 20, 2022 at 09:32:46AM +0300, Daniil Tatianin wrote: > This fixes a copy-paste issue where dev_err would log the dst mask even > though it is clearly talking about src. > > Found by Linux Verification Center (linuxtesting.org) with the SVACE > static analysis tool. > > Fixes: 0075fa0fadd0 ("i40evf: Add support to apply cloud filters") > Signed-off-by: Daniil Tatianin > --- > drivers/net/ethernet/intel/iavf/iavf_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c > index c4e451ef7942..adc02adef83a 100644 > --- a/drivers/net/ethernet/intel/iavf/iavf_main.c > +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c > @@ -3850,7 +3850,7 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter, > field_flags |= IAVF_CLOUD_FIELD_IIP; > } else { > dev_err(&adapter->pdev->dev, "Bad ip src mask 0x%08x\n", > - be32_to_cpu(match.mask->dst)); > + be32_to_cpu(match.mask->src)); > return -EINVAL; > } > } > -- > 2.25.1 Reviewed-by: Michal Swiatkowski It is good practise to include changelog in message when You send another version. For example: v1: * change fix tag to 12 chars _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan