From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73E38C3DA79 for ; Sun, 1 Jan 2023 08:32:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id E95CA60B26; Sun, 1 Jan 2023 08:32:31 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org E95CA60B26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1672561952; bh=CZ36ELY5A2MD1+/UYufxbyNVEftPLPXsIeojDjy3KPg=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=DJfbREZNhsGJfd/tXhUXio1+Ifze5JlcpQ33E0bBHAi6bxBxu5pfBof1cGkkHV4Sk vJ8cgPMgOJRbWrGPPnbObyAT2nGuAW/TJTntewjiOd+B4KCfInQm3VBqqjutMfExSJ 9tvwr0IVVP177oD4CWaCilVOlHRyjfN4EztmfgT5jGEO8pinPi31GdGsOHbmbl5sSr LWa3Ft/5QFNxh/vsBV743v6VbF4jDsT/lZgq2um40vvgQBSosRGSiATgJEAb+oKdzo n97R4y6CLFQRfRfhFcdP1OCMqTW7xvUAcXnquhYHljDEs3L5vZmJVrYJOWICkVhpsD LLdrMD+JaY0Ug== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xzJbki8tfKah; Sun, 1 Jan 2023 08:32:31 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 0398060B9F; Sun, 1 Jan 2023 08:32:31 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 0398060B9F Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 2934F1BF282 for ; Sun, 1 Jan 2023 08:32:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 008C6813A4 for ; Sun, 1 Jan 2023 08:32:30 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 008C6813A4 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VHDxWpcKPe2j for ; Sun, 1 Jan 2023 08:32:28 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 72C87813A2 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by smtp1.osuosl.org (Postfix) with ESMTPS id 72C87813A2 for ; Sun, 1 Jan 2023 08:32:28 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D254BB80951; Sun, 1 Jan 2023 08:32:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F767C433EF; Sun, 1 Jan 2023 08:32:21 +0000 (UTC) Date: Sun, 1 Jan 2023 10:32:17 +0200 From: Leon Romanovsky To: Rajat Khandelwal Message-ID: References: <20221229122640.239859-1-rajat.khandelwal@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221229122640.239859-1-rajat.khandelwal@linux.intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672561942; bh=bbsHjJ0JkS3AgnKxQQCuXwAIuU+mqpDxReBTV+i0EVQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lb1Jda9Ch4NFf6oW/o+yKMtS22KQjDd8sIZglOIIeHjAHBSoRgjIQieOngfEWoBt1 tYXKlNCB/+LIGPIZeF9lFVrh0gdnQhkWkEQT9Z3ZdpnsoNmPbFaFJ4IZmWc+MTEl9t Nd05ILknaYXnn9PIdn1tp5AgkhHWja478AIMlaxxCN2NHm6MP7TjVd5So0WUFvOKQG onh/YU2m+4Fhym24POumGF9ch6bGGmOCL7RA/8t75FgHV3lx3dAjnmLnmhLSuyRFgY AijLTnoC1Xv4HDhPX9IUo+PIaciN6XhbGyc102mkTnNebiubrLzwPf4AOrCWAAxJo6 jLdVw5YKdBMHQ== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Lb1Jda9C Subject: Re: [Intel-wired-lan] [PATCH] igc: Mask replay rollover/timeout errors in I225_LMVP X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-wired-lan@lists.osuosl.org, rajat.khandelwal@intel.com, jesse.brandeburg@intel.com, linux-kernel@vger.kernel.org, edumazet@google.com, anthony.l.nguyen@intel.com, netdev@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Dec 29, 2022 at 05:56:40PM +0530, Rajat Khandelwal wrote: > The CPU logs get flooded with replay rollover/timeout AER errors in > the system with i225_lmvp connected, usually inside thunderbolt devices. > > One of the prominent TBT4 docks we use is HP G4 Hook2, which incorporates > an Intel Foxville chipset, which uses the igc driver. > On connecting ethernet, CPU logs get inundated with these errors. The point > is we shouldn't be spamming the logs with such correctible errors as it > confuses other kernel developers less familiar with PCI errors, support > staff, and users who happen to look at the logs. > > Signed-off-by: Rajat Khandelwal > --- > drivers/net/ethernet/intel/igc/igc_main.c | 28 +++++++++++++++++++++-- > 1 file changed, 26 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c > index ebff0e04045d..a3a6e8086c8d 100644 > --- a/drivers/net/ethernet/intel/igc/igc_main.c > +++ b/drivers/net/ethernet/intel/igc/igc_main.c > @@ -6201,6 +6201,26 @@ u32 igc_rd32(struct igc_hw *hw, u32 reg) > return value; > } > > +#ifdef CONFIG_PCIEAER > +static void igc_mask_aer_replay_correctible(struct igc_adapter *adapter) > +{ > + struct pci_dev *pdev = adapter->pdev; > + u32 aer_pos, corr_mask; > + > + if (pdev->device != IGC_DEV_ID_I225_LMVP) > + return; > + > + aer_pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_ERR); > + if (!aer_pos) > + return; > + > + pci_read_config_dword(pdev, aer_pos + PCI_ERR_COR_MASK, &corr_mask); > + > + corr_mask |= PCI_ERR_COR_REP_ROLL | PCI_ERR_COR_REP_TIMER; > + pci_write_config_dword(pdev, aer_pos + PCI_ERR_COR_MASK, corr_mask); Shouldn't this igc_mask_aer_replay_correctible function be implemented in drivers/pci/quirks.c and not in igc_probe()? Thanks _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan