From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9A1AC38142 for ; Tue, 24 Jan 2023 06:27:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 3D19481BB0; Tue, 24 Jan 2023 06:27:07 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 3D19481BB0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1674541627; bh=Y2nwewcoawD8VWgzCQWSxVEra9+PwmqsY7r2eiX25SM=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=E6y6rdtZVxZWMbfnUQ58dobszAN2Z7yXPXUaso306qpowC+osy7LUnDcgQJWXHX3I J9rA+0gwAcojBpMhZmrCPIHarCoFrdIsQXUhRQzoarCt7ygFC6DSoTYYj2Gz5uGEhq FziYMYqDU6iRa0DpJTI6bDiyB0+sh9eC6xQ1ZsTGxBwyrQaQhct9KvtkeIwNX2lKiG i9yf7XsN0HbCTN3eJIMy3wp8v+LUKY9x3w6mLskP1gttZiHP1DCFv6BbBUcGI52i2z BA6RiuIwNOCN1JzVuJfkglmqKiRPzeV2+GXQUNaGfTsgsbnQMIfHyrwYeua3axzW/E 4Vw6WKuN8Pgzw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HurWNgXzqvdw; Tue, 24 Jan 2023 06:27:06 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 2B52581F6E; Tue, 24 Jan 2023 06:27:06 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2B52581F6E Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id BB68A1BF370 for ; Tue, 24 Jan 2023 06:27:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 9DC7E82041 for ; Tue, 24 Jan 2023 06:27:04 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9DC7E82041 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S1Ei71Gi2OlB for ; Tue, 24 Jan 2023 06:27:04 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org A92B681BB0 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by smtp1.osuosl.org (Postfix) with ESMTPS id A92B681BB0 for ; Tue, 24 Jan 2023 06:27:03 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 81096B810C2; Tue, 24 Jan 2023 06:27:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B04B8C433EF; Tue, 24 Jan 2023 06:26:58 +0000 (UTC) Date: Tue, 24 Jan 2023 08:22:33 +0200 From: Leon Romanovsky To: Jay Vosburgh Message-ID: References: <5064.1674514892@famine> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5064.1674514892@famine> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674541619; bh=0E4Oc7/Z2stBA8qPrvNH0kEWWPBwgaEO48l8pr7o85U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y0C8LuIeZXm8qzNM/0x9oaruuBIALECSGYaMY6JmMXHEt/4OO6fq6+06qZLWrY6i8 /YYXqNse4w2KUvniABDf9pA3W11MlsCChz5gJvaziaPWU5exQ10jdXHnq18ftwwENJ WFWPLGpiW20wYNKbJJEXOqd9nDmLzA81okfyPzqIWTVrb6JlllE262R87ggNDsSftd ILWr1fy2sGPKt1lW5713650iPtEhl5Bemos7Ul6Kw5aghe/uDMFQCr1TmgUCJPph8Z Xu57x2nxiwSFl/idayA3VSw1jJzKxozO5QYBFU7NORPZvlvN0aI9/owULgjlII7j/5 tcOXg3V17Py7Q== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Y0C8LuIe Subject: Re: [Intel-wired-lan] [PATCH net-next 09/10] bonding: fill IPsec state validation failure reason X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Steffen Klassert , Paolo Abeni , Ayush Sawal , Herbert Xu , Eric Dumazet , Jonathan Corbet , Tony Nguyen , netdev@vger.kernel.org, linux-doc@vger.kernel.org, Jesse Brandeburg , oss-drivers@corigine.com, Veaceslav Falico , Raju Rangoju , Simon Horman , Jakub Kicinski , intel-wired-lan@lists.osuosl.org, Saeed Mahameed , "David S . Miller" , Andy Gospodarek Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Jan 23, 2023 at 03:01:32PM -0800, Jay Vosburgh wrote: > Leon Romanovsky wrote: > > >From: Leon Romanovsky > > > >Rely on extack to return failure reason. > > > >Signed-off-by: Leon Romanovsky > >Signed-off-by: Leon Romanovsky > >--- > > drivers/net/bonding/bond_main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c > >index 686b2a6fd674..00646aa315c3 100644 > >--- a/drivers/net/bonding/bond_main.c > >+++ b/drivers/net/bonding/bond_main.c > >@@ -444,7 +444,7 @@ static int bond_ipsec_add_sa(struct xfrm_state *xs, > > if (!slave->dev->xfrmdev_ops || > > !slave->dev->xfrmdev_ops->xdo_dev_state_add || > > netif_is_bond_master(slave->dev)) { > >- slave_warn(bond_dev, slave->dev, "Slave does not support ipsec offload\n"); > >+ NL_SET_ERR_MSG_MOD(extack, "Slave does not support ipsec offload"); > > rcu_read_unlock(); > > return -EINVAL; > > } > > Why only this one, and not include the other similar > slave_warn() calls in the bond_ipsec_* functions? Which functions did you have in mind? The extack was added to XFRM .xdo_dev_state_add() call, which is translated to bond_ipsec_add_sa() with only one slave_warn() print. If you are talking about bond_ipsec_add_sa_all(), that function isn't directly connected to netlink and doesn't have extack pointer to fill. If you are talking about bond_ipsec_del_sai*() and slave_warn() there, it will be better to be deleted/changed to make sure what ipsec_list have only valid devices. Thanks > That would seem to make some failures show up in dmesg, > and others returned to the caller via extack. > > -J > > --- > -Jay Vosburgh, jay.vosburgh@canonical.com _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan