From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH] ice: double lock on adev_mutex
Date: Fri, 13 Jan 2023 16:48:54 +0100 [thread overview]
Message-ID: <Y8F9ZrcNc9lU4IpD@localhost.localdomain> (raw)
In-Reply-To: <4662dbfc-171e-cdc2-7558-137567e05c25@intel.com>
On Thu, Jan 12, 2023 at 05:11:04PM -0800, Jesse Brandeburg wrote:
> On 1/11/2023 3:01 AM, Michal Swiatkowski wrote:
> > Re: [Intel-wired-lan] [PATCH] ice: double lock on adev_mutex
>
> Looks good but title should always contain PATCH net-next or PATCH net. Also
> doesn't hurt especially for net fixes to use --base net/master (assuming
> your remote for netdev net tree is 'net')
>
>
Sure, sorry, I forgot to add net tag, it is in v2. Will remember,
thanks.
> > Call trace:
> > ice_set_channel() --> mutex_lock(adev_mutex)
> > ice_vsi_recfg_qs()
> > ice_pf_dcb_recfg()
> > ice_send_event_to_aux() --> another mutex_lock(adev_mutex)
>
> Ouch, didn't lockdep identify this? Let's hope it would find it if we turned
> it on.
>
I haven't got lockdep compiled into my kernel, probably I should start
adding it.
> >
> > This call trace is reached when user try to change queues amount using
> > ethtool:
> > $ ethtool -L enp24s0f0np0 tx 64 rx 32
> >
> > Avoid double lock by unlocking after checking if RDMA is active.
> >
> > Fixes: a49a2713f00e ("ice: Prevent set_channel from changing queues while RDMA active")
> > Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
>
> thanks for fixing this!
>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-01-13 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 11:01 [Intel-wired-lan] [PATCH] ice: double lock on adev_mutex Michal Swiatkowski
2023-01-13 1:11 ` Jesse Brandeburg
2023-01-13 15:48 ` Michal Swiatkowski [this message]
2023-01-19 9:43 ` G, GurucharanX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8F9ZrcNc9lU4IpD@localhost.localdomain \
--to=michal.swiatkowski@linux.intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox