From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C028C54E94 for ; Thu, 26 Jan 2023 07:28:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id B4C8461035; Thu, 26 Jan 2023 07:28:12 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org B4C8461035 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1674718092; bh=1D+x0yignGByGcCaC5IT0K27PFwf3P3OFz7A49CxiAw=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=1sB65amjf+gqM2x72mOMQ/5MiPW2+SdbfUjAJ/MeSBSmbq0+d89720TLwqB+jUoGa scOzDUlbOo+mnG3msRiDCWcoudpoM+lwbcqzuuGvfc+skRzf3ajC0+oepOxs91wIJd 8Q1rERWwJRhWa4EysOZpWLWG5wcFW6WrApBudSBCndACQ9RDYDTGmyULfaWgocJyoO rGeODlypg+/9Ye/56+C65V1y3XK0UD0rK7sPpVicOFPFpUaIGwQKoCVom4Q8ufp6+i MYs/fNCu5aSV/P6k1Dw08KTuMVxOpgkxp4fBcrOeymt4LIFnC/An4jVlcwmmTasjYh rexABQxfWoj2w== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8pKTVE9Rb4yC; Thu, 26 Jan 2023 07:28:12 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id C1CA260FEE; Thu, 26 Jan 2023 07:28:11 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org C1CA260FEE Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 765EA1BF4E7 for ; Thu, 26 Jan 2023 07:28:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 4AB5D40A0E for ; Thu, 26 Jan 2023 07:28:10 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 4AB5D40A0E X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M-tYE9UydFmG for ; Thu, 26 Jan 2023 07:28:09 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 8E96E409E7 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp2.osuosl.org (Postfix) with ESMTPS id 8E96E409E7 for ; Thu, 26 Jan 2023 07:28:09 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 85D9361752; Thu, 26 Jan 2023 07:28:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 386EBC433EF; Thu, 26 Jan 2023 07:28:05 +0000 (UTC) Date: Thu, 26 Jan 2023 09:28:02 +0200 From: Leon Romanovsky To: Jakub Kicinski Message-ID: References: <20230125110226.66dc7eeb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230125110226.66dc7eeb@kernel.org> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674718087; bh=FP9vuXTK892fNGc55uvufWHZKaEX/J0FjCpiBCeGi28=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ahanLAX1jHk2265b+uqA+hNuR4qWvgo2XQ8DgoPW1fhBpx3U/md7lhcB5uVvG2aBz ewBTvWBB0UFZvZQEs8a1Hox8blCimFkmeMveP+r3xVPULc68P7m3R/g6RI2OPtksIO oh5LM5BNVdd6OZoNY/gPsKVmW7WNU9IUpC7BzEDIpyKCcfwbVfdzhCmE4W58Z4L68P OGlEQpS1YmaKofixwlx3mHha+mbnTgXmsTPYx6s6BpCMruQsHKpn6z14eDmaEzh6AT 0QVOSED+Vn1VjoIR1g34IvH+sQHOEc0o/wYxbs+zJDd4VuU+0JIKUNJRpzILAukx31 9f2kVcePtzJcg== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=ahanLAX1 Subject: Re: [Intel-wired-lan] [PATCH net-next v1 01/10] xfrm: extend add policy callback to set failure reason X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Steffen Klassert , Veaceslav Falico , Herbert Xu , Jonathan Corbet , Jay Vosburgh , oss-drivers@corigine.com, linux-doc@vger.kernel.org, Raju Rangoju , Jesse Brandeburg , Eric Dumazet , netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Ayush Sawal , Simon Horman , Tony Nguyen , Paolo Abeni , Saeed Mahameed , "David S . Miller" , Andy Gospodarek Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, Jan 25, 2023 at 11:02:26AM -0800, Jakub Kicinski wrote: > On Tue, 24 Jan 2023 13:54:57 +0200 Leon Romanovsky wrote: > > - err = dev->xfrmdev_ops->xdo_dev_policy_add(xp); > > + err = dev->xfrmdev_ops->xdo_dev_policy_add(xp, extack); > > if (err) { > > xdo->dev = NULL; > > xdo->real_dev = NULL; > > xdo->type = XFRM_DEV_OFFLOAD_UNSPECIFIED; > > xdo->dir = 0; > > netdev_put(dev, &xdo->dev_tracker); > > - NL_SET_ERR_MSG(extack, "Device failed to offload this policy"); > > In a handful of places we do: > > if (!extack->msg) > NL_SET_ERR_MSG(extack, "Device failed to offload this policy"); > > in case the device did not provide the extack. > Dunno if it's worth doing here. Honestly, I followed devlink.c which didn't do that, but looked again and found that devlink can potentially overwrite messages :) For example in this case: 997 err = ops->port_fn_state_get(port, &state, &opstate, extack); 998 if (err) { 999 if (err == -EOPNOTSUPP) 1000 return 0; 1001 return err; 1002 } 1003 if (!devlink_port_fn_state_valid(state)) { 1004 WARN_ON_ONCE(1); 1005 NL_SET_ERR_MSG_MOD(extack, "Invalid state read from driver"); 1006 return -EINVAL; 1007 } So what do you think about the following change, so we can leave NL_SET_ERR_MSG_MOD() in devlink and xfrm intact? diff --git a/include/linux/netlink.h b/include/linux/netlink.h index 38f6334f408c..d6f3a958e30b 100644 --- a/include/linux/netlink.h +++ b/include/linux/netlink.h @@ -101,7 +101,7 @@ struct netlink_ext_ack { \ do_trace_netlink_extack(__msg); \ \ - if (__extack) \ + if (__extack && !__extack->msg) \ __extack->_msg = __msg; \ } while (0) @@ -111,7 +111,7 @@ struct netlink_ext_ack { #define NL_SET_ERR_MSG_FMT(extack, fmt, args...) do { \ struct netlink_ext_ack *__extack = (extack); \ \ - if (!__extack) \ + if (!__extack || __extack->msg) \ break; \ if (snprintf(__extack->_msg_buf, NETLINK_MAX_FMTMSG_LEN, \ "%s" fmt "%s", "", ##args, "") >= \ _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan