From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C91DFC63797 for ; Tue, 31 Jan 2023 05:17:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 54ED0400AF; Tue, 31 Jan 2023 05:17:59 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 54ED0400AF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1675142279; bh=pFxw9+QM5+OzUHlM1YCiCuO82axlomLV0lb2xpct1Vo=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=gmvIDfCc+Tjy/ARfhsQcl/Lx7XpI4tymFAl/CK3Ultb2vw4l4J7osd+MUSIWC0O2z Wfb4cmpfehMw6zdwEFli1B1uj0c8cOmNI0bUy8aS1th73x0fOREIKwmnkhuzQJNbFC GpwM9DY30HWMHIyHrJxjVrZamGJTJo1vQf+O4aP+NToQhCOEXSjJ9QvlPVa3rEZRF2 WR+xZcVtYZhN4h3Zq26U5HA//J8+NlDvLgwD4T0FTY1nShc9qgrObA8R5g8cW2gHxE iBHBVEA2sYH9PUlnYVoqKDDPde9rv2HkzGjTWIJ0xlqEMkpEma+1eYk3m1iwRKnef2 jYFVaydWrkhPg== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GNlq1Dcsj6Wj; Tue, 31 Jan 2023 05:17:58 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 48547400DC; Tue, 31 Jan 2023 05:17:58 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 48547400DC Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 27FF41BF38C for ; Tue, 31 Jan 2023 05:17:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 05236400DC for ; Tue, 31 Jan 2023 05:17:57 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 05236400DC X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WRQO1JJhOCTE for ; Tue, 31 Jan 2023 05:17:56 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 114B2400AF Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by smtp2.osuosl.org (Postfix) with ESMTPS id 114B2400AF for ; Tue, 31 Jan 2023 05:17:55 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 19712B819A4; Tue, 31 Jan 2023 05:17:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27574C433D2; Tue, 31 Jan 2023 05:17:52 +0000 (UTC) Date: Tue, 31 Jan 2023 06:17:49 +0100 From: Greg Kroah-Hartman To: Natalia Petrova Message-ID: References: <20230125141328.8479-1-n.petrova@fintech.ru> <20230130221106.19267-1-n.petrova@fintech.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230130221106.19267-1-n.petrova@fintech.ru> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675142272; bh=r1QHAE5CMl8j0BmAlptuDNAWDYIcrrh/o2sPtM6Hjy0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R/mf3WwpaV5fsu3TWYLp1Q7l9wmQIvSUP24s1OjzHzw2swhBCMqHQ6DjW89eTTJW9 Xz2sNGG2lXALXIIGf31/sza9eCol6tjosPjVaFJ9x0lGOrn4IqKUawpfNsOcdxfIuA 0434uycuN89kzLeT1DOg05GMKNn9Yb8WHtc8uaUY= X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=R/mf3Wwp Subject: Re: [Intel-wired-lan] [PATCH v2] i40e: Add checking for null for nlmsg_find_attr() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvc-project@linuxtesting.org, intel-wired-lan@lists.osuosl.org, Jesse Brandeburg , stable@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Dumazet , Tony Nguyen , netdev@vger.kernel.org, Jakub Kicinski , Paolo Abeni , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Jan 31, 2023 at 01:11:06AM +0300, Natalia Petrova wrote: > The result of nlmsg_find_attr() 'br_spec' is dereferenced in > nla_for_each_nested(), but it can take null value in nla_find() function, > which will result in an error. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: 51616018dd1b ("i40e: Add support for getlink, setlink ndo ops") > Signed-off-by: Natalia Petrova > Reviewed-by: Jesse Brandeburg > --- > v2: The remark about the error code by Simon Horman > was taken into account; return value -ENOENT was changed to -EINVAL. > drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++ > 1 file changed, 2 insertions(+) > This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan