[Intel-wired-lan] [PATCH net-next v2 00/12] Add switchdev driver model for ice driver

[Michal Swiatkowski <michal.swiatkowski@linux.intel.com>]

On Wed, Jun 23, 2021 at 07:48:29AM +0200, Paul Menzel wrote:
> Dear Michal,
> 
> 
> Am 22.06.21 um 23:21 schrieb Michal Swiatkowski:
> > The following patch series introduces basic switchdev model
> > support in ice driver. Implement the following blocks of
> > switchdev framework:
> > - VF port representors creation
> > - control plane VSI definition
> > - exception path (a. k. a. "slow-path") - to allow a virtual
> > switch or linux bridge to receive any packet that doesn't match
> > any hw filter
> > - link state management of virtual ports
> > - query virtual port statistics
> > 
> > Hardware offload support in switchdev mode is out of scope of
> > this patchset. Devlink interface is used to toggle between
> > switchdev and legacy (the default) modes of the driver.
> 
> These are great news. Could you please elaborate in the summary how to
> switch to the new mode of the driver? What are the benefits of switchdev in
> this case? Less maintenance or better performance?
> 
> Should the switchdev folks be involved in review?
> 

You can switch to new mode using devlink tool. Commands are described in
first patch. We are still working on readme with all information about
switchdev in ice. The main benefits is better performance. With
switchdev You will be able to offload specific kind of rules in hardware
using tc-tool (or OVS). This will be introduced in follow up patchset.

I think they should. Do You know anyone that I should add to CC?

> > Changelog:
> >   v2:
> >    * fix build issue in ice: setting and releasing switchdev environment
> >    by moving call of ice_vsi_setup to next patch which have definition
> >    for switchdev VSI
> > 
> > Grzegorz Nitka (5):
> >    ice: setting and releasing switchdev environment
> 
> It?d be great if you could use verbs in imperative mood.
>

I will fix this and try to use imperative mood.

> 
> Kind regards,
> 
> Paul
> 
> 
> >    ice: introduce new type of VSI for switchdev
> >    ice: enable/disable switchdev when managing VFs
> >    ice: rebuild switchdev when resetting all VFs
> >    ice: switchdev slow path
> > 
> > Michal Swiatkowski (5):
> >    ice: basic support for eswitch mode management
> >    ice: introduce VF port representor
> >    ice: allow process vf opcodes in different ways
> >    ice: manage VSI antispoof and destination override
> >    ice: allow changing lan_en and lb_en on dflt rules
> > 
> > Wojciech Drewek (2):
> >    ice: Move devlink port to PF/VF struct
> >    ice: add port representor ethtool ops and stats
> > 
> >   drivers/net/ethernet/intel/Kconfig            |  10 +
> >   drivers/net/ethernet/intel/ice/Makefile       |   4 +-
> >   drivers/net/ethernet/intel/ice/ice.h          |  48 +-
> >   drivers/net/ethernet/intel/ice/ice_base.c     |  37 +-
> >   drivers/net/ethernet/intel/ice/ice_devlink.c  | 109 ++-
> >   drivers/net/ethernet/intel/ice/ice_devlink.h  |   6 +-
> >   drivers/net/ethernet/intel/ice/ice_eswitch.c  | 656 ++++++++++++++++++
> >   drivers/net/ethernet/intel/ice/ice_eswitch.h  |  82 +++
> >   drivers/net/ethernet/intel/ice/ice_ethtool.c  |  32 +-
> >   drivers/net/ethernet/intel/ice/ice_fltr.c     |  80 +++
> >   drivers/net/ethernet/intel/ice/ice_fltr.h     |   7 +
> >   .../net/ethernet/intel/ice/ice_lan_tx_rx.h    |  43 ++
> >   drivers/net/ethernet/intel/ice/ice_lib.c      | 112 ++-
> >   drivers/net/ethernet/intel/ice/ice_lib.h      |  11 +
> >   drivers/net/ethernet/intel/ice/ice_main.c     |  47 +-
> >   drivers/net/ethernet/intel/ice/ice_repr.c     | 329 +++++++++
> >   drivers/net/ethernet/intel/ice/ice_repr.h     |  27 +
> >   drivers/net/ethernet/intel/ice/ice_switch.c   |   2 +-
> >   drivers/net/ethernet/intel/ice/ice_switch.h   |   6 +
> >   drivers/net/ethernet/intel/ice/ice_txrx.c     |   3 +
> >   drivers/net/ethernet/intel/ice/ice_txrx_lib.c |   4 +-
> >   drivers/net/ethernet/intel/ice/ice_type.h     |   1 +
> >   .../net/ethernet/intel/ice/ice_virtchnl_pf.c  | 196 +++++-
> >   .../net/ethernet/intel/ice/ice_virtchnl_pf.h  |  45 ++
> >   24 files changed, 1817 insertions(+), 80 deletions(-)
> >   create mode 100644 drivers/net/ethernet/intel/ice/ice_eswitch.c
> >   create mode 100644 drivers/net/ethernet/intel/ice/ice_eswitch.h
> >   create mode 100644 drivers/net/ethernet/intel/ice/ice_repr.c
> >   create mode 100644 drivers/net/ethernet/intel/ice/ice_repr.h
> >