From: Jiri Pirko <jiri@resnulli.us>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next] devlink: Make devlink_register to be void
Date: Tue, 21 Sep 2021 09:02:23 +0200 [thread overview]
Message-ID: <YUmDf3KdLS/4FwoT@nanopsycho> (raw)
In-Reply-To: <20210920133915.59ddfeef@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Mon, Sep 20, 2021 at 10:39:15PM CEST, kuba at kernel.org wrote:
>On Mon, 20 Sep 2021 17:41:44 +0300 Leon Romanovsky wrote:
>> From: Leon Romanovsky <leonro@nvidia.com>
>>
>> devlink_register() can't fail and always returns success, but all drivers
>> are obligated to check returned status anyway. This adds a lot of boilerplate
>> code to handle impossible flow.
>>
>> Make devlink_register() void and simplify the drivers that use that
>> API call.
>
>Unlike unused functions bringing back error handling may be
>non-trivial. I'd rather you deferred such cleanups until you're
>ready to post your full rework and therefore give us some confidence
>the revert will not be needed.
Well, that was the original reason why I made it to return int, so the
drivers are prepared. But truth is that given the time this is on and
the need to return int never really materialized, I tend to ack with the
cleanup.
prev parent reply other threads:[~2021-09-21 7:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 14:41 [Intel-wired-lan] [PATCH net-next] devlink: Make devlink_register to be void Leon Romanovsky
2021-09-20 20:39 ` Jakub Kicinski
2021-09-20 21:04 ` Jakub Kicinski
2021-09-21 2:19 ` Leon Romanovsky
2021-09-21 12:39 ` Jakub Kicinski
2021-09-22 8:55 ` Leon Romanovsky
2021-09-21 7:02 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUmDf3KdLS/4FwoT@nanopsycho \
--to=jiri@resnulli.us \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox