From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Date: Wed, 29 Sep 2021 18:24:44 +0300 Subject: [Intel-wired-lan] [PATCH net-next v1 4/5] net/mlx5: Register separate reload devlink ops for multiport device In-Reply-To: <20210929073551.16dd2267@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> References: <20210929065549.43b13203@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210929072631.437ffad9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210929073551.16dd2267@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Wed, Sep 29, 2021 at 07:35:51AM -0700, Jakub Kicinski wrote: > On Wed, 29 Sep 2021 17:31:04 +0300 Leon Romanovsky wrote: > > On Wed, Sep 29, 2021 at 07:26:31AM -0700, Jakub Kicinski wrote: > > > On Wed, 29 Sep 2021 17:16:28 +0300 Leon Romanovsky wrote: > > > > devlink_ops pointer is not constant at this stage, so why can't I copy > > > > reload_* pointers to the "main" devlink ops? > > > > > > > > I wanted to avoid to copy all pointers. > > > > > > Hm. I must be missing a key piece here. IIUC you want to have different > > > ops based on some device property. But there is only one > > > > > > static struct devlink_ops mlx5_devlink_ops; > > > > > > so how can two devlink instances in the system use that and have > > > different ops without a copy? > > > > No, I have two: > > * Base ops - mlx5_devlink_ops > > * Extra reload commands - mlx5_devlink_reload > > Still those are global for the driver, no? Ugh, yes > > What if you have multiple NICs or whatever. I missed it and always tested with one device L(. I'll add copy-all-ops code. Thanks