From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net] ice: fix adding different tunnels
Date: Mon, 22 Nov 2021 06:23:36 -0500 [thread overview]
Message-ID: <YZt9uAwNHeduZ4xo@localhost.localdomain> (raw)
In-Reply-To: <5ae646ac06ec21eeb82dda74b13c79f84709bcb4.camel@intel.com>
On Wed, Nov 17, 2021 at 11:59:19PM +0000, Nguyen, Anthony L wrote:
> On Tue, 2021-11-16 at 11:24 +0100, Michal Swiatkowski wrote:
> > Adding filters with the same values inside for VXLAN and geneve
> > causes hw
> > error, because it looks exactly the same. To choose between different
> > type of tunnels new recipe is needed. Add storing tunnel types in
> > creatig recipes function and start checking it in finding function.
> >
> > Change getting open tunnels function to return port on correct tunnel
> > type. This is needed to copy correct port to dummy packet.
> >
> > Block user from adding enc_dst_port via tc flower, because? VXLAN and
> > geneve filters can be created only with destination port which was
> > previously opened.
> >
> > Fixes: 8b032a55c1bd5 ("ice: low level support for tunnels")
> > Signed-off-by: Michal Swiatkowski
> > <michal.swiatkowski@linux.intel.com>
> > ---
> > ?.../net/ethernet/intel/ice/ice_ethtool_fdir.c?? |? 4 ++--
> > ?drivers/net/ethernet/intel/ice/ice_fdir.c?????? |? 2 +-
> > ?drivers/net/ethernet/intel/ice/ice_flex_pipe.c? |? 6 ++++--
> > ?drivers/net/ethernet/intel/ice/ice_flex_pipe.h? |? 3 ++-
> > ?drivers/net/ethernet/intel/ice/ice_switch.c???? | 17 ++++++++++++---
> > --
> > ?drivers/net/ethernet/intel/ice/ice_tc_lib.c???? |? 3 ++-
> > ?6 files changed, 23 insertions(+), 12 deletions(-)
>
> The added function parameters need to be documented:
>
> drivers/net/ethernet/intel/ice/ice_switch.c:3801: warning: Function
> parameter or member 'tun_type' not described in 'ice_find_recp'
> drivers/net/ethernet/intel/ice/ice_flex_pipe.c:2047: warning: Function
> parameter or member 'type' not described in 'ice_get_open_tunnel_port'
>
Sorry for late answer, I missed it. Thanks, will send corrected v2 soon.
next prev parent reply other threads:[~2021-11-22 11:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 10:24 [Intel-wired-lan] [PATCH net] ice: fix adding different tunnels Michal Swiatkowski
2021-11-17 23:59 ` Nguyen, Anthony L
2021-11-22 11:23 ` Michal Swiatkowski [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-11-16 9:36 Michal Swiatkowski
2021-11-17 5:33 ` Michal Swiatkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZt9uAwNHeduZ4xo@localhost.localdomain \
--to=michal.swiatkowski@linux.intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox