From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00692E77188 for ; Sun, 5 Jan 2025 01:16:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id ADF63406AA; Sun, 5 Jan 2025 01:16:49 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id ChVJj_Dbnfzr; Sun, 5 Jan 2025 01:16:47 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 66D5C4068F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1736039807; bh=/PXMx0aYm3p77AOabnQSJYxJRLSAjD5vIBHkByO2LPE=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=8J/5LQb5QrFXJWfrFJlbMRK49YjbrZK/zx+Aog/J+nMvmlOG3CyT69MOuN10K2sUe 89FOuRxrCosMFepBoIN4y4gftVvYPL6zZbVfKKh57koo/1+SBTjoLe+p2QrplRBBGq lLHY+2lD5euMHGIUIQXsBVeIYGgRl1hYb7MVhlVf3b7yHbtmKGHQ6keQT81Cym++Ic iEKj9Q+owLaXelgxcYNSkb2hd3huW67RYS/3XGqVnnYoEnlnszrkQ4vaqfo4VtEHSH wahMNrGsDlcouzM88UsohDmi1Uav0VG7PfX+dY8/TVut08VdJTChZb+7nHvQLqRe7R niSItbmfNNz0w== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 66D5C4068F; Sun, 5 Jan 2025 01:16:47 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists1.osuosl.org (Postfix) with ESMTP id 39A9FE0F for ; Sun, 5 Jan 2025 01:16:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 315B4400AC for ; Sun, 5 Jan 2025 01:16:45 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id eKoiapO-0XMf for ; Sun, 5 Jan 2025 01:16:44 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1098:5b::1; helo=mx.treblig.org; envelope-from=dg@treblig.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org A8019400DC DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org A8019400DC Received: from mx.treblig.org (mx.treblig.org [IPv6:2a00:1098:5b::1]) by smtp2.osuosl.org (Postfix) with ESMTPS id A8019400DC for ; Sun, 5 Jan 2025 01:16:43 +0000 (UTC) Received: from dg by mx.treblig.org with local (Exim 4.96) (envelope-from ) id 1tUFFn-008Bvs-2t; Sun, 05 Jan 2025 01:16:31 +0000 Date: Sun, 5 Jan 2025 01:16:31 +0000 From: "Dr. David Alan Gilbert" To: Jakub Kicinski Cc: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: References: <20250102174002.200538-1-linux@treblig.org> <20250104081532.3af26fa1@kernel.org> <20250104165440.080a9c7b@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20250104165440.080a9c7b@kernel.org> X-Chocolate: 70 percent or better cocoa solids preferably X-Operating-System: Linux/6.1.0-21-amd64 (x86_64) X-Uptime: 01:15:08 up 241 days, 12:29, 1 user, load average: 0.00, 0.00, 0.00 User-Agent: Mutt/2.2.12 (2023-09-09) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=Content-Type:MIME-Version:Message-ID:Subject:From:Date:From :Subject; bh=/PXMx0aYm3p77AOabnQSJYxJRLSAjD5vIBHkByO2LPE=; b=QhwkUx6HBWLdPZiN NJQpIbL3Y5K800+KUDVsQ6/0vN9x2SpA67PhsVrGt01RwFpEc48Jobbc5q7X4WmlRT6rTA5u3pc/h Zv+uUO3SmNCrfEIFiwA34S/QvIHG9+MaDjzxPBKIoTdrtEsO6JYDrYfGTtfAKqIy/e4fJui1sfVm9 6IeUtyYVelUU3Mwv9aLSa2c6hEW33PR0btxQv+6I6exqbKQRA2pPlG9WThFsZISxfZKizCy+MTZ1Q z9CIqnup2mUBY6wxOqcQwS7XFsygvZwUKFBNAFp7HqMSwHGI7bmi/R1xK09KgmdImTuQ3b7Dsos5d H0iWMZXPvWNi0udu5w==; X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=treblig.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=treblig.org header.i=@treblig.org header.a=rsa-sha256 header.s=bytemarkmx header.b=QhwkUx6H Subject: Re: [Intel-wired-lan] [PATCH net-next] ixgbevf: Remove unused ixgbevf_hv_mbx_ops X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" * Jakub Kicinski (kuba@kernel.org) wrote: > On Sat, 4 Jan 2025 21:56:24 +0000 Dr. David Alan Gilbert wrote: > > > This one doesn't apply, reportedly. > > > > Hmm, do you have a link to that report, or to which tree I should try > > applying it to. > > net-next, the tree in the subject prefix: > > $ git checkout net-next/main Thanks > $ wget 'https://lore.kernel.org/all/20250102174002.200538-1-linux@treblig.org/raw' > Saving 'raw' > $ git am raw > Applying: ixgbevf: Remove unused ixgbevf_hv_mbx_ops > error: patch failed: drivers/net/ethernet/intel/ixgbevf/ixgbevf.h:439 > error: drivers/net/ethernet/intel/ixgbevf/ixgbevf.h: patch does not apply > Patch failed at 0001 ixgbevf: Remove unused ixgbevf_hv_mbx_ops Oh I see, it's the e610 patch that crept in and just changed the context and moved the lines down a bit; not built it yet, but I'll cut a new version. See below. Dave diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h index 9b37f354d78c..4384e892f967 100644 --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h @@ -443,7 +443,6 @@ extern const struct ixgbevf_info ixgbevf_X540_vf_hv_info; extern const struct ixgbevf_info ixgbevf_X550_vf_hv_info; extern const struct ixgbevf_info ixgbevf_X550EM_x_vf_hv_info; extern const struct ixgbevf_info ixgbevf_e610_vf_hv_info; -extern const struct ixgbe_mbx_operations ixgbevf_hv_mbx_ops; /* needed by ethtool.c */ extern const char ixgbevf_driver_name[]; vs diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h index 130cb868774c..a43cb500274e 100644 --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h @@ -439,7 +439,6 @@ extern const struct ixgbevf_info ixgbevf_82599_vf_hv_info; extern const struct ixgbevf_info ixgbevf_X540_vf_hv_info; extern const struct ixgbevf_info ixgbevf_X550_vf_hv_info; extern const struct ixgbevf_info ixgbevf_X550EM_x_vf_hv_info; -extern const struct ixgbe_mbx_operations ixgbevf_hv_mbx_ops; /* needed by ethtool.c */ extern const char ixgbevf_driver_name[]; -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/