From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9447EC021A7 for ; Thu, 13 Feb 2025 06:58:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 347F6606F6; Thu, 13 Feb 2025 06:58:54 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 0I_77i-s00di; Thu, 13 Feb 2025 06:58:53 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 76D74608B4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1739429933; bh=4F5VANmPyXgvr1kxKrwCwoj+uCRsVNio33Ci9p3RiXM=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=k3FAeOAwYyIw1S9oFurnxbC+yTlipPmLLrHwsq+Fm15U/Zwiy9jL8Fq+ddiQw6tn0 92uom2E0LnfY4jxlEz1VAtBSum/4Ralc1M1fCySl1F+1Iv9GlOsuwR0uNtCT9TzwGI sQ+ToqEqJl1KDR3BzKWxg0+tmYXh+buMF6IMREhL1pE3mGPv9nf5nsugSVgveJ2ucy AFZH/5QExThtY2iE7k650mYqdnpE82XDjFRPJOJ48L8Kru3peDj0GDyhMlMSghtyOb VpIRiZQ9ghShlEkSqXOV6OmvVqtLDG8J257iGpDAJ/8T4cD6AAWpPEJZxvuuDmsWcv csAnodbvJseAg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 76D74608B4; Thu, 13 Feb 2025 06:58:53 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists1.osuosl.org (Postfix) with ESMTP id CCD0412D for ; Thu, 13 Feb 2025 06:58:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id BC56F608B4 for ; Thu, 13 Feb 2025 06:58:52 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 6kWZXc_ihec8 for ; Thu, 13 Feb 2025 06:58:52 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=198.175.65.20; helo=mgamail.intel.com; envelope-from=michal.swiatkowski@linux.intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org E01E1606F6 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org E01E1606F6 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by smtp3.osuosl.org (Postfix) with ESMTPS id E01E1606F6 for ; Thu, 13 Feb 2025 06:58:51 +0000 (UTC) X-CSE-ConnectionGUID: m8kb0SyJTuuD35K0xMO64w== X-CSE-MsgGUID: NML1lJO6TMKB35savesF5A== X-IronPort-AV: E=McAfee;i="6700,10204,11343"; a="39818277" X-IronPort-AV: E=Sophos;i="6.13,282,1732608000"; d="scan'208";a="39818277" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2025 22:58:49 -0800 X-CSE-ConnectionGUID: KUJW1hv9RVqsIDMDOXu40g== X-CSE-MsgGUID: Uu0E+VmgQ9e+/yLUUhvqhA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="150223547" Received: from mev-dev.igk.intel.com ([10.237.112.144]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2025 22:58:46 -0800 Date: Thu, 13 Feb 2025 07:55:12 +0100 From: Michal Swiatkowski To: Dan Carpenter Cc: Michal Swiatkowski , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Wojciech Drewek , Jacob Keller , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739429932; x=1770965932; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=IuDkSPusWTCLmutvKrUiCtONzQj5Xn2RbA/VhezuVxA=; b=SHVBOqRaLQEjouentecf0eiV2j3zV+hTODC9h4VCh21No3/c+MScuUtK /VKSw4cenwwFJh1bVE6r8r/hvC7d8TsMZQRYB7aadGOdy+z15SHi72d5y o4g9XttTDBg6VGfjt6bJQ6Jezr4ul6rwS4SmguYbfscpqVlGV2cmZbJna sYYFEEVjfjl2vJJRhTqxxRKdVCeOmdOEEtFijU430yDIvn0Bm6qtTu+LX cFIw8jpFDNx2kK4szvjcfp7N1WES5UYdFT+XgJA1fI6QT5+x0yVom4Ks6 Lio7JHf5lHHI7QWXuMQWS7W6j/x9yvbSszlMG5tkTGNv2VMZCwqJ1Hyba g==; X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=none (p=none dis=none) header.from=linux.intel.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=SHVBOqRa Subject: Re: [Intel-wired-lan] [PATCH v2 net-next] ice: Fix signedness bug in ice_init_interrupt_scheme() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Feb 13, 2025 at 09:31:41AM +0300, Dan Carpenter wrote: > If pci_alloc_irq_vectors() can't allocate the minimum number of vectors > then it returns -ENOSPC so there is no need to check for that in the > caller. In fact, because pf->msix.min is an unsigned int, it means that > any negative error codes are type promoted to high positive values and > treated as success. So here, the "return -ENOMEM;" is unreachable code. > Check for negatives instead. > > Now that we're only dealing with error codes, it's easier to propagate > the error code from pci_alloc_irq_vectors() instead of hardcoding > -ENOMEM. > > Fixes: 79d97b8cf9a8 ("ice: remove splitting MSI-X between features") > Signed-off-by: Dan Carpenter > --- > v2: Fix my scripts to say [PATCH net-next] > Propagate the error code. > > drivers/net/ethernet/intel/ice/ice_irq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/ice/ice_irq.c b/drivers/net/ethernet/intel/ice/ice_irq.c > index cbae3d81f0f1..30801fd375f0 100644 > --- a/drivers/net/ethernet/intel/ice/ice_irq.c > +++ b/drivers/net/ethernet/intel/ice/ice_irq.c > @@ -149,8 +149,8 @@ int ice_init_interrupt_scheme(struct ice_pf *pf) > > vectors = pci_alloc_irq_vectors(pf->pdev, pf->msix.min, vectors, > PCI_IRQ_MSIX); > - if (vectors < pf->msix.min) > - return -ENOMEM; > + if (vectors < 0) > + return vectors; > > ice_init_irq_tracker(pf, pf->msix.max, vectors); > Thanks, Reviewed-by: Michal Swiatkowski > -- > 2.47.2 >