From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A7AEC6FD1D for ; Mon, 20 Mar 2023 14:59:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2EEC980EEC; Mon, 20 Mar 2023 14:59:29 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2EEC980EEC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1679324369; bh=O/0/9pn5yQFC+h/wpEiB7okTTEjTOfkuJZUloInNaxw=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=F/kO5AWDuEmmUU8L7b0EprycNLs5U0yNgRfy50CQ7Ex9KD41kGq5UxajgJNu0P7zB vxmf6HFlFjPyT0FmMeOb/3p5rhdP6kQPJqxesxL3i/XhI1ByqzcK5J1fPa1q3kHR0M RiCrW7vZOi0SHSHbpHMIAAgwe7QgpG842iuVVLOQjyTjj1O4cOQwPa8ZJUjDH4mbqG weQEN+7tLQM2TNcu+my/VKQPVWj/1mpNY7MVOURMit6+Rp71WA3ys32ZmvjUv6pMpY FeB2OMFJ+gLsKhU8/kSkCm2d7zxZOqnD/iwmpAEOgmJCC1vke2Ovo+dg0lJKmviYmQ SYn5sJ/8bdnZw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TsVYQW1C76uX; Mon, 20 Mar 2023 14:59:28 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 2D1DB80BDA; Mon, 20 Mar 2023 14:59:28 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2D1DB80BDA Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id E6CF01BF21A for ; Mon, 20 Mar 2023 14:59:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id BE6EA41749 for ; Mon, 20 Mar 2023 14:59:26 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org BE6EA41749 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id d1-jTu1XmgOh for ; Mon, 20 Mar 2023 14:59:25 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 973454171C Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by smtp4.osuosl.org (Postfix) with ESMTPS id 973454171C for ; Mon, 20 Mar 2023 14:59:25 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6600,9927,10655"; a="322523380" X-IronPort-AV: E=Sophos;i="5.98,274,1673942400"; d="scan'208";a="322523380" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2023 07:59:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10655"; a="770219893" X-IronPort-AV: E=Sophos;i="5.98,274,1673942400"; d="scan'208";a="770219893" Received: from unknown (HELO localhost.localdomain) ([10.237.112.144]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2023 07:59:22 -0700 Date: Mon, 20 Mar 2023 15:59:14 +0100 From: Michal Swiatkowski To: Leon Romanovsky Message-ID: References: <20230320112347.117363-1-michal.swiatkowski@linux.intel.com> <20230320115117.GK36557@unreal> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230320115117.GK36557@unreal> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679324365; x=1710860365; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=TRbUmWHnSkE7D/lu5e7kw8nA2AMjXdu8/aiMJ3BeZxs=; b=QvqtP+B0bIWvNUmtWdGKEnCp1Tu1dbbKfdm2KmOjkiRW6lLTq78dD/I0 tCGQad7Nq6PVzdwzBNC9KAGEeEmLJJ7UL2GT/BQlgCvk2B/yGmrJTO2Ae QGZtDqfnwvGaaqtqQMuIyyrARARm0diVuNgREEDUV4QIqbIz4nBSW72HH akBK/utT67nil362zQ+lKjolVUGqMXIO9g3FctTuBUFOZsHu2JNT0dhGp HN5NMFQ74mGxj9N4rnwaceiPBlHLb8sIVhthDWAWkfWvyLHYdS1qu6LWJ dinYhgBeprvQz9/nf15KZhVbXVsF0bfxAIOl7Eg6UhJJT1d8MMeqTemme Q==; X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=QvqtP+B0 Subject: Re: [Intel-wired-lan] [PATCH net v2] ice: clear number of qs when rings are free X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Mar 20, 2023 at 01:51:17PM +0200, Leon Romanovsky wrote: > On Mon, Mar 20, 2023 at 12:23:47PM +0100, Michal Swiatkowski wrote: > > In case rebuild fails not clearing this field can lead to call trace. > > > > [ +0.009792] BUG: kernel NULL pointer dereference, address: 0000000000000000 > > [ +0.000009] #PF: supervisor read access in kernel mode > > [ +0.000006] #PF: error_code(0x0000) - not-present page > > [ +0.000005] PGD 0 P4D 0 > > [ +0.000009] Oops: 0000 [#1] PREEMPT SMP PTI > > [ +0.000009] CPU: 45 PID: 77867 Comm: ice-ptp-0000:60 Kdump: loaded Tainted: G S OE 6.2.0-rc6+ #110 > > [ +0.000010] Hardware name: Dell Inc. PowerEdge R740/0JMK61, BIOS 2.11.2 004/21/2021 > > [ +0.000005] RIP: 0010:ice_ptp_update_cached_phctime+0xb0/0x130 [ice] > > [ +0.000145] Code: fa 7e 55 48 8b 93 48 01 00 00 48 8b 0c fa 48 85 c9 74 e1 8b 51 68 85 d2 75 da 66 83 b9 86 04 00 00 00 74 d0 31 d2 48 8b 71 20 <48> 8b 34 d6 48 85 f6 74 07 48 89 86 d8 00 00 00 0f b7 b1 86 04 00 > > [ +0.000008] RSP: 0018:ffffa036cf7c7ea8 EFLAGS: 00010246 > > [ +0.000008] RAX: 174ab1a8ab400f43 RBX: ffff937cda2c01a0 RCX: ffff937cdca9b028 > > [ +0.000005] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 > > [ +0.000005] RBP: ffffa036cf7c7eb8 R08: 0000000000000000 R09: 0000000000000000 > > [ +0.000005] R10: 0000000000000080 R11: 0000000000000001 R12: ffff937cdc971f40 > > [ +0.000006] R13: ffff937cdc971f44 R14: 0000000000000001 R15: ffffffffc13f3210 > > [ +0.000005] FS: 0000000000000000(0000) GS:ffff93826f980000(0000) knlGS:0000000000000000 > > [ +0.000006] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > [ +0.000006] CR2: 0000000000000000 CR3: 00000004b7310002 CR4: 00000000007726e0 > > [ +0.000006] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > [ +0.000004] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > [ +0.000005] PKRU: 55555554 > > [ +0.000004] Call Trace: > > [ +0.000004] > > [ +0.000007] ice_ptp_periodic_work+0x2a/0x60 [ice] > > [ +0.000126] kthread_worker_fn+0xa6/0x250 > > [ +0.000014] ? __pfx_kthread_worker_fn+0x10/0x10 > > [ +0.000010] kthread+0xfc/0x130 > > [ +0.000009] ? __pfx_kthread+0x10/0x10 > > [ +0.000010] ret_from_fork+0x29/0x50 > > > > ice_ptp_update_cached_phctime() is calling ice_for_each_rxq macro, in > > case of rebuild fail the rx_ring is NULL and there is NULL pointer > > dereference. > > > > Also for future safety it is better to clear the size values for tx and > > rx ring when they are cleared. > > > > Fixes: 6624e780a577 ("ice: split ice_vsi_setup into smaller functions") > > Reported-by: Mateusz Palczewski > > Signed-off-by: Michal Swiatkowski > > --- > > v1 --> v2: > > * change subject to net and add fixes tag > > --- > > drivers/net/ethernet/intel/ice/ice_lib.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > It will be so great if all these ice_for_each_*(*, i) macros will go. > They do nothing except hide basic for-loop. Good point, I spent too much time searching which field is used there. Will try to propose sth. Thanks for review > > Thanks, > Reviewed-by: Leon Romanovsky _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan