Re: [Intel-wired-lan] [RFC PATCH iwl-next 2/6] ip_tunnel: convert __be16 tunnel flags to bitmaps

[Simon Horman <simon.horman@corigine.com>]

On Tue, Jun 06, 2023 at 03:17:47PM +0200, Alexander Lobakin wrote:
> From: Simon Horman <simon.horman@corigine.com>
> Date: Mon, 5 Jun 2023 11:23:34 +0200
> 
> > On Thu, Jun 01, 2023 at 03:19:25PM +0200, Marcin Szycik wrote:
> >> From: Alexander Lobakin <alexandr.lobakin@intel.com>
> 
> [...]
> 
> >>  net/ipv4/fou_bpf.c                            |   2 +-
> >>  net/ipv4/gre_demux.c                          |   2 +-
> >>  net/ipv4/ip_gre.c                             | 131 +++++++++++-------
> >>  net/ipv4/ip_tunnel.c                          |  51 ++++---
> >>  net/ipv4/ip_tunnel_core.c                     |  81 +++++++----
> >>  net/ipv4/ip_vti.c                             |  31 +++--
> >>  net/ipv4/ipip.c                               |  21 ++-
> >>  net/ipv4/udp_tunnel_core.c                    |   5 +-
> >>  net/ipv6/ip6_gre.c                            |  87 +++++++-----
> >>  net/ipv6/ip6_tunnel.c                         |  14 +-
> >>  net/ipv6/sit.c                                |   9 +-
> >>  net/netfilter/ipvs/ip_vs_core.c               |   6 +-
> >>  net/netfilter/ipvs/ip_vs_xmit.c               |  20 +--
> >>  net/netfilter/nft_tunnel.c                    |  45 +++---
> >>  net/openvswitch/flow_netlink.c                |  55 ++++----
> >>  net/psample/psample.c                         |  26 ++--
> >>  net/sched/act_tunnel_key.c                    |  39 +++---
> >>  net/sched/cls_flower.c                        |  27 ++--
> >>  40 files changed, 695 insertions(+), 392 deletions(-)
> > 
> > nit: this is a rather long patch
> I know, but you can't do anything with it. I'm changing the type of the
> fields from `__be16` to `unsigned long *` and they're accessed in a good
> ton of places around the kernel. This patch is atomic despite being
> huge, any separation would break compilation ¯\_(ツ)_/¯

Yes, I concede that it may well be the least worst option.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan