From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3566EB64D9 for ; Thu, 15 Jun 2023 14:43:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 4DF14400D8; Thu, 15 Jun 2023 14:43:50 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 4DF14400D8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1686840230; bh=Bp3sosaM8oTjG/CtYh3Sjo+xOEYyWcXnldJ/pxNowlY=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=Y9l4VQ3BtdyDNuO5j1bDK2D1RWVTYpFXT0ovYtvi+uGBeLbrn2btm1tuWSVKC0D1h X820x44VFFfCG/EW+elPGBNi+4ZIu7NLCa4B1PLS4V5IKbNjek7gWeMpz4ztr8r5iy +vDSZl2fNG3H6XtOZGgZYGGn5xFL1Wea/XvEgx3818skwkNBuVc8AFDjjh2au7xjwB qeaLWCF0K35tVHdbvXR1oDKCO0n5ZpqhmQ1F38o24ZifcTD6/hgz9NYG6zinyxJbX5 GsD70Tz3cJK8HsLrGnsgB0oeyCuTeJKq/BwCTNlpeHi6g8RD958nUhGs8QNMCPtUty E41VGCnpDwnmQ== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fBYd-AXGNUTY; Thu, 15 Jun 2023 14:43:49 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 5A1D04060D; Thu, 15 Jun 2023 14:43:49 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 5A1D04060D Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 998CD1BF263 for ; Thu, 15 Jun 2023 14:43:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 6C0DD41EBF for ; Thu, 15 Jun 2023 14:43:47 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 6C0DD41EBF X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vC-qR5LVLJ8m for ; Thu, 15 Jun 2023 14:43:46 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 446A841EB1 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by smtp4.osuosl.org (Postfix) with ESMTPS id 446A841EB1 for ; Thu, 15 Jun 2023 14:43:46 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6600,9927,10742"; a="356425078" X-IronPort-AV: E=Sophos;i="6.00,245,1681196400"; d="scan'208";a="356425078" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2023 07:43:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10742"; a="689797987" X-IronPort-AV: E=Sophos;i="6.00,245,1681196400"; d="scan'208";a="689797987" Received: from unknown (HELO localhost.localdomain) ([10.237.112.144]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2023 07:43:28 -0700 Date: Thu, 15 Jun 2023 16:43:24 +0200 From: Michal Swiatkowski To: Maciej Fijalkowski Message-ID: References: <20230615123830.155927-1-michal.swiatkowski@linux.intel.com> <20230615123830.155927-2-michal.swiatkowski@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686840226; x=1718376226; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=R7m6EwVSs6DhwY+ljeHN8KXcYvla1ddTVA4Uzy8YF9E=; b=IcRlOSwkr3IAVYQfoZI7a55HKhaM+isAGduWmd0dAlepYy9kakppqazW nvlVrFiU+j8nM3VoueHx8T47A/7AQsl243Gktwgci8RqRXmSqc6y5gInf uykKtZA6a7hH3jTNAHAJ+e6KMxWh1wQGNTCyV0vUtpHN1avqD3PJAPqzE eyohc5AN6kr+EHyY389iAgGsEtk2GfavbgMNdvm+X1ULxVdBYqoB1+b0j 5E+4cyQzYWa9CFNTeN7Z17ocRGcJYqO4uhgKKa2qVDi+1Z/WUhGG2eVkk yZ5bsWDDjbmEwyHGpiQZQNxUggry37fHlsXqmDhgqeW0/zKKrJe+MOqg5 g==; X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=IcRlOSwk Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 1/4] ice: implement num_msix field per VF X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, przemyslaw.kitszel@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Jun 15, 2023 at 04:22:35PM +0200, Maciej Fijalkowski wrote: > On Thu, Jun 15, 2023 at 02:38:27PM +0200, Michal Swiatkowski wrote: > > Store the amount of MSI-X per VF instead of storing it in pf struct. It > > is used to calculate number of q_vectors (and queues) for VF VSI. > > > > Calculate vector indexes based on this new field. > > Can you explain why? From a standalone POV the reasoning is not clear. > Maybe I should reword it. Previously we had pf->vf_msix - number of MSI-X on each VF. The number of MSI-X was the same on all VFs. After this changes user is allowed to change MSI-X per VF. We need new field in VF struct to track it. Calculation of queues / vector/ indexes is the same as it was, but the number can be different for each VF, so intead of baseing calculation on per VF MSI-X we have to base it on real VF MSI-X. Feel like I over complicated simple thing by this commit message. Calculation remainis the same, we have per VF field to store MSI-X instead of one field for all of the VFs. _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan