From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D040EB64DD for ; Wed, 21 Jun 2023 12:30:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C732C821AA; Wed, 21 Jun 2023 12:30:07 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C732C821AA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1687350607; bh=jZqHrQrTlLZGrlWcJrg2GVbKawBto1K4//96Docqqlg=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=8x1BtUg2Ia4mFhouumB/Z0NXwMXvcFRAmryczvp4gsZxO6Xf48jKLm8a5uTjVgmMU j9R/bVoQDSHjCJABld1Hd5Y1IIpaLlOrfYyfa4LhBI8iIJS9De47ee1XXD6IaknpCH qGw4fm6dTfHR5KY+zrTVR6je7fpt2C4kK+NWezPzYDBCkUUzwJPd5yMlzLn/N7U4sa t+8bB9nsXIUCYQLcbusAGoAsQm5OEWaVnzyOn5+nlH0CS0W7P1RxF4k8mZUH+/Nb4R 8AOfI4BNyqIxKfPlrPhM41F23HkA0u1mfjfWnN8hZmWpDfttezseJcc0FTr/IWAbeG jRFGgvPyGwZBw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YdQ5kcoa6zg6; Wed, 21 Jun 2023 12:30:07 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id D2D7E82151; Wed, 21 Jun 2023 12:30:06 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org D2D7E82151 Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 7237A1BF83A for ; Wed, 21 Jun 2023 12:30:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 42A9840BE4 for ; Wed, 21 Jun 2023 12:30:05 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 42A9840BE4 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KurN5-M22m2x for ; Wed, 21 Jun 2023 12:30:04 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 4F97840125 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by smtp2.osuosl.org (Postfix) with ESMTPS id 4F97840125 for ; Wed, 21 Jun 2023 12:30:03 +0000 (UTC) Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-4f640e48bc3so7831358e87.2 for ; Wed, 21 Jun 2023 05:30:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687350601; x=1689942601; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R9RGfJqgepIeBvJ1OfKk1XmicseQJBOqqkZjFv/Sa90=; b=hk1mOhzfhhN0P3s4+2uS4E6JYPWRAL7v5f3ko+BuMxu7b6PA/kLjNZ+Si4xuQ7jpTU rNn/HL+q1Py9/RkXs963bScTaQO/RSNei3z0odaJQ+//RCBTdDsrO7TZIN/qMDLI9N7j KDllJU0209AlapZl50ki8YB3h9Os6KterZdymbzrcHXTXF3C/JSLo1NWwWxGWlbKOPrD FddJv/I256+bJf8P5cOiOBu2jfB2OIzeh8d+kNHkMij+tdBHOcp+j1j80eZwiB/HxudR 6wyd3dxfLidr5IfmnTEMne4eM+rRpuayfj32PXYh4FLG13aub2Ec/ZLJR6vgtWHa9kFf me4A== X-Gm-Message-State: AC+VfDxWIjRiPrtZbzineJxyPXsDcNCGQAB4DbAtPikk0G0OsUWESdYe cfmpVoL49yg21Vi8/2nLIH+9lA== X-Google-Smtp-Source: ACHHUZ5n1us+Bo/SpNyVjWkH9hnrHLxyGkJ086GdwXI8vcD2bjT3FD19WznXfwbxPjwjeY65NzV9QQ== X-Received: by 2002:a19:7715:0:b0:4f9:5a87:1028 with SMTP id s21-20020a197715000000b004f95a871028mr998668lfc.30.1687350601263; Wed, 21 Jun 2023 05:30:01 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id x1-20020a5d4441000000b00311d8c2561bsm4376924wrr.60.2023.06.21.05.30.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jun 2023 05:30:00 -0700 (PDT) Date: Wed, 21 Jun 2023 14:29:59 +0200 From: Jiri Pirko To: "Kubalewski, Arkadiusz" Message-ID: References: <20230609121853.3607724-1-arkadiusz.kubalewski@intel.com> <20230609121853.3607724-9-arkadiusz.kubalewski@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1687350601; x=1689942601; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=R9RGfJqgepIeBvJ1OfKk1XmicseQJBOqqkZjFv/Sa90=; b=EkqoBWjMr87RPy89et6BGhuw9VAPZh7M+VK6jbsmEABD22QZZD6QcVmEmD0YKxTD3i NFifzn2AbhccQE8IS2d4oMw6SbNGIvnDgO3+FnbrVyacR7rd3gQ33x9OKxIFKXHFgQxU Bv7htOjEJeg2jVHoz1cAzYz1FCO+UYTGSokSdXVKZJ8oWzrEjoc6oosLLIGauk35oxeB fcRL7THnuGMfucqzTYbmGsnzDX2XCIVoqReAHk3Uu0S52nmlVnY90+BNjuqKXwsIKpxr xS6Q2JQnfzg+Hegrb/1bzxj5Tzo1AKsS3qAAnNufUJ1JsCy6SOsxkScjyFjut5bGuZF1 Omtg== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=resnulli-us.20221208.gappssmtp.com header.i=@resnulli-us.20221208.gappssmtp.com header.a=rsa-sha256 header.s=20221208 header.b=EkqoBWjM Subject: Re: [Intel-wired-lan] [RFC PATCH v8 08/10] ice: implement dpll interface to control cgu X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "geert+renesas@glider.be" , "mst@redhat.com" , "razor@blackwall.org" , "phil@nwl.cc" , "javierm@redhat.com" , "edumazet@google.com" , "benjamin.tissoires@redhat.com" , "Nguyen, Anthony L" , "netdev@vger.kernel.org" , "linux-clk@vger.kernel.org" , "lucien.xin@gmail.com" , "leon@kernel.org" , "corbet@lwn.net" , "linux-rdma@vger.kernel.org" , "masahiroy@kernel.org" , "linux-doc@vger.kernel.org" , "Brandeburg, Jesse" , "vadfed@meta.com" , "intel-wired-lan@lists.osuosl.org" , "airlied@redhat.com" , "vadfed@fb.com" , "pabeni@redhat.com" , "ricardo.canuelo@collabora.com" , "arnd@arndb.de" , "idosch@nvidia.com" , "richardcochran@gmail.com" , "claudiajkang@gmail.com" , "kuniyu@amazon.com" , "jacek.lawrynowicz@linux.intel.com" , "liuhangbin@gmail.com" , "kuba@kernel.org" , "nicolas.dichtel@6wind.com" , "linux-arm-kernel@lists.infradead.org" , "axboe@kernel.dk" , "sj@kernel.org" , "vadim.fedorenko@linux.dev" , "linux@zary.sk" , "gregkh@linuxfoundation.org" , "ogabbay@kernel.org" , "nipun.gupta@amd.com" , "linux-kernel@vger.kernel.org" , "andy.ren@getcruise.com" , "tzimmermann@suse.de" , "jonathan.lemon@gmail.com" , "M, Saeed" , "davem@davemloft.net" , "Olech, Milena" , "hkallweit1@gmail.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Mon, Jun 19, 2023 at 10:34:12PM CEST, arkadiusz.kubalewski@intel.com wrote: >>From: Jiri Pirko >>Sent: Saturday, June 10, 2023 6:37 PM >> >>Fri, Jun 09, 2023 at 02:18:51PM CEST, arkadiusz.kubalewski@intel.com wrote: >> >>[...] >> >> >>>+static int ice_dpll_mode_get(const struct dpll_device *dpll, void *priv, >>>+ enum dpll_mode *mode, >>>+ struct netlink_ext_ack *extack) >>>+{ >>>+ *mode = DPLL_MODE_AUTOMATIC; >> >>I don't understand how the automatic mode could work with SyncE. The >>There is one pin exposed for one netdev. The SyncE daemon should select >>exacly one pin. How do you achieve that? >>Is is by setting DPLL_PIN_STATE_SELECTABLE on the pin-netdev you want to >>select and DPLL_PIN_STATE_DISCONNECTED on the rest? >> >> >>[...] > >AUTOMATIC mode autoselects highest priority valid signal. >As you have pointed out, for SyncE selection, the user must be able to manually >select a pin state to enable recovery of signal from particular port. > >In "ice" case there are 2 pins for network PHY clock signal recovery, and both >are parent pins (MUX-type). There are also 4 pins assigned to netdevs (one per >port). Thus passing a signal from PHY to the pin is done through the MUX-pin, >by selecting proper state on pin-parent pair (where parent pins is highest prio >pin on dpll). Could you show me some examples please? > >Thank you! >Arkadiusz _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan