From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51E35EB64DA for ; Thu, 22 Jun 2023 07:06:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id B5D2560EA0; Thu, 22 Jun 2023 07:06:04 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org B5D2560EA0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1687417564; bh=sMJzb2w6qmSLbNMTPgO66Cwb9oxiwU1LW22UU+XqDIU=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=HdVJWIBfQaF68NPXwmAiNwSgh5LIaFEmCeozcy+mef4f/SL5F6op78ckNGmJxD/fH sGIm9qhysvRZuCvPTNQFCoRSW4a89QpStLAQ3XumUKnb4rgYp69fRHNtf6jVTTfbc0 Sn+olXzVeHEin/2LrlcrmR7V3PqKKxGREVcTiHV+FBXwaLAVSXqGXOqt9yS1LK7d+K NxB9NjJ6M7ZErYFSuRmy88UhIxxaKKFl3xojpE27lZ6Eq7rPMJzObt97D++lAg8ASn Z9rzTGs7WMJzfIEZ2rIt4w2SqxfO+OxRG/qr30z9IzdKCP+m5ETpEJiWCQKd94KnwK LLFiQj3Q0y30w== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LVz1mizL1ky0; Thu, 22 Jun 2023 07:06:03 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id A469E60A88; Thu, 22 Jun 2023 07:06:03 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org A469E60A88 Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 59EE81BF421 for ; Thu, 22 Jun 2023 07:06:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 321C5400CC for ; Thu, 22 Jun 2023 07:06:02 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 321C5400CC X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6omZwjsaHCWj for ; Thu, 22 Jun 2023 07:06:00 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 3DE2D400C7 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by smtp2.osuosl.org (Postfix) with ESMTPS id 3DE2D400C7 for ; Thu, 22 Jun 2023 07:05:59 +0000 (UTC) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-3fa7512e599so1356665e9.2 for ; Thu, 22 Jun 2023 00:05:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687417557; x=1690009557; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VIhSOYk52hVuqfcboW85OQLI0NHly7jy25hrkyJ2YAw=; b=QtWoh+NROIwzx1Vygi0BSV6ihYrzDczflqcG3ftFU1DukcKEuu3mmIr7CnaTmqonpy DckuCCpNe6veK6hUk29VEX6VEtuTwSC7NuNL4U2OK4tr6M7Ojwzihpx8TMV3AeOShrKn 1x6kPL8YRDKTN5A/mxTfEM2hgSA8ks8cTdHCW8vZlJCzgxIth/74Pg8KsPrwO5lPmd3P H5qGUyilaonXfryHzACSNS/DccSWUo8GKoanbyhB8mPkF2hkJ+1DRDzhK5zBKfMfnPs5 2bTEkHGACCu/5XIH83slLeqAN+NduYTRHosEaFTy1JG6YEpxrakcqXyz4X0lUdU0TYMV 0hgQ== X-Gm-Message-State: AC+VfDzgGyqLSNc6tzNI+LaldtVnKFvYRD3/39ADrhUx9fRofcoBpHij FCzlmqxqyL6X9CeohrpnXSsY8Q== X-Google-Smtp-Source: ACHHUZ47nqUaHErWDVz/sLK5UcH8SW19SUG16keT/oe5Rk5/giZmsiFYSgziHOgHrlK6XzxNNrCLiA== X-Received: by 2002:a1c:7415:0:b0:3fa:77c8:6724 with SMTP id p21-20020a1c7415000000b003fa77c86724mr51349wmc.10.1687417557595; Thu, 22 Jun 2023 00:05:57 -0700 (PDT) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id 17-20020a05600c231100b003f8ec58995fsm6919930wmo.6.2023.06.22.00.05.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 00:05:57 -0700 (PDT) Date: Thu, 22 Jun 2023 09:05:56 +0200 From: Jiri Pirko To: "Kubalewski, Arkadiusz" Message-ID: References: <20230609121853.3607724-1-arkadiusz.kubalewski@intel.com> <20230609121853.3607724-4-arkadiusz.kubalewski@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1687417557; x=1690009557; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VIhSOYk52hVuqfcboW85OQLI0NHly7jy25hrkyJ2YAw=; b=WZQ2qdOUncD9AsxUeqky0Sv9plZI/2WtRmFLj/vUPrLspAKtFdJAjDNBfRiM90Wl6l Bu52No9UiIMeNp5vJfqV4tdzKNy4gqSSkZZgdTA2tEhX9UhJ0VFvTD1WUjcyZjBnxsqM CY6kI+W0r2aC0t58Ot4ae4EkJpbEUxEO+qU0IzQugmgTpIX9f4Vdc6bAsBsmzf0/VZPu oMD/OCT9ypK+CBaNDZaMdjjZbvVgK6KKjigdSYdUY6tPiNMyp/u8BcNpj7C6Q76VkPqd cFeXbCEhZGKbNKcefxvBWXoomyu9ZEWY69AGbsxFJ97j4shY74xka5Cdz8D7NjEiYYcZ YJOw== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=resnulli-us.20221208.gappssmtp.com header.i=@resnulli-us.20221208.gappssmtp.com header.a=rsa-sha256 header.s=20221208 header.b=WZQ2qdOU Subject: Re: [Intel-wired-lan] [RFC PATCH v8 03/10] dpll: core: Add DPLL framework base functions X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "geert+renesas@glider.be" , "mst@redhat.com" , "razor@blackwall.org" , "phil@nwl.cc" , "javierm@redhat.com" , "edumazet@google.com" , "benjamin.tissoires@redhat.com" , "Nguyen, Anthony L" , "netdev@vger.kernel.org" , "linux-clk@vger.kernel.org" , "lucien.xin@gmail.com" , "leon@kernel.org" , "corbet@lwn.net" , "linux-rdma@vger.kernel.org" , "masahiroy@kernel.org" , "linux-doc@vger.kernel.org" , "Brandeburg, Jesse" , "vadfed@meta.com" , "intel-wired-lan@lists.osuosl.org" , "airlied@redhat.com" , "vadfed@fb.com" , "pabeni@redhat.com" , "ricardo.canuelo@collabora.com" , "arnd@arndb.de" , "idosch@nvidia.com" , "richardcochran@gmail.com" , "claudiajkang@gmail.com" , "kuniyu@amazon.com" , "jacek.lawrynowicz@linux.intel.com" , "liuhangbin@gmail.com" , "kuba@kernel.org" , "nicolas.dichtel@6wind.com" , "linux-arm-kernel@lists.infradead.org" , "axboe@kernel.dk" , "sj@kernel.org" , "vadim.fedorenko@linux.dev" , "linux@zary.sk" , "gregkh@linuxfoundation.org" , "ogabbay@kernel.org" , "nipun.gupta@amd.com" , "linux-kernel@vger.kernel.org" , "andy.ren@getcruise.com" , "tzimmermann@suse.de" , "jonathan.lemon@gmail.com" , "M, Saeed" , "davem@davemloft.net" , "Olech, Milena" , "hkallweit1@gmail.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Wed, Jun 21, 2023 at 08:55:35PM CEST, arkadiusz.kubalewski@intel.com wrote: >>From: Jiri Pirko >>Sent: Saturday, June 10, 2023 7:38 PM >> >>Fri, Jun 09, 2023 at 02:18:46PM CEST, arkadiusz.kubalewski@intel.com wrote: >>>From: Vadim Fedorenko >>> >>>DPLL framework is used to represent and configure DPLL devices >>>in systems. Each device that has DPLL and can configure inputs >>>and outputs can use this framework. >>> >>>Implement core framework functions for further interactions >>>with device drivers implementing dpll subsystem, as well as for >>>interactions of DPLL netlink framework part with the subsystem >>>itself. >>> >>>Co-developed-by: Milena Olech >>>Signed-off-by: Milena Olech >>>Co-developed-by: Michal Michalik >>>Signed-off-by: Michal Michalik >>>Signed-off-by: Vadim Fedorenko >>>Co-developed-by: Arkadiusz Kubalewski >>>Signed-off-by: Arkadiusz Kubalewski >>>--- >>> drivers/dpll/dpll_core.c | 953 +++++++++++++++++++++++++++++++++++++++ >>> drivers/dpll/dpll_core.h | 104 +++++ >> >>Overall, looks very good! I pinpointed couple of nits below, nothing big. >>General question: Why do you put documentation comment to every static >>function? Does not make any sense to me. Even for non-exported functions >>I think it is overkill. Most of them (if not all) give the reader no >>additional information and only make the code a bit harder to read. >>Care to drop them? >> > >I forgot to respond here.. I would rather leave it, but if the others think >the same way, we could remove them. Could you explain what is the benefit of leaving them? What are they good for. From what I see, they are obvious and only add blank LOC. _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan