From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26576C6FA8F for ; Wed, 30 Aug 2023 15:26:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id BC6A441693; Wed, 30 Aug 2023 15:26:04 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org BC6A441693 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1693409164; bh=p0/m6Fpoo3aMK9ASlnr8KQOwyVTc0gpRcuwSWU/KiPk=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=a8/VDZYbCXgMfaozlrfpwBpH+ieD9eX41iyXuLTpQ3xdkJIXa7xa/RdIX7J3lVJBX Wnwb/yW3MEeTbd9fTjvixieSrHLlCCXrfES0IC2DNvkqWAgQOgcqIT6dOWRYhgKzTB jr00SlX+W7XJ0kWe2Z7s14B+sruwb7my5EzP6fHv6Z9ksxUZXuC8ks31PUskk3vWR8 NOeeNtro5YbeP9kp4Rug8sfEGjkay++KvRgc1viF5wZ1cxUXsNyeo/dtd97RJ3vXS7 WrBYYsoYr+uzj6PJZMPInXh664mdMt6sAnxoPxLkgY2hQIRsJSc12yhi6uV7E4RSkb rhSNYFN0DA4Ug== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EdQHhooGPRZA; Wed, 30 Aug 2023 15:26:04 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id D693E4177B; Wed, 30 Aug 2023 15:26:03 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org D693E4177B Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 44C701BF30D for ; Wed, 30 Aug 2023 15:26:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 028EE419D3 for ; Wed, 30 Aug 2023 15:26:02 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 028EE419D3 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Nubk6LKSW2F3 for ; Wed, 30 Aug 2023 15:26:01 +0000 (UTC) X-Greylist: delayed 504 seconds by postgrey-1.37 at util1.osuosl.org; Wed, 30 Aug 2023 15:26:00 UTC DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org CD2A640243 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by smtp4.osuosl.org (Postfix) with ESMTPS id CD2A640243 for ; Wed, 30 Aug 2023 15:26:00 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id DED465C0109; Wed, 30 Aug 2023 11:17:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 30 Aug 2023 11:17:32 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudefkedgkeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcu ufgthhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrth htvghrnhepvddufeevkeehueegfedtvdevfefgudeifeduieefgfelkeehgeelgeejjeeg gefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepih guohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Aug 2023 11:17:31 -0400 (EDT) Date: Wed, 30 Aug 2023 18:17:27 +0300 From: Ido Schimmel To: "Drewek, Wojciech" Message-ID: References: <20230824085459.35998-1-wojciech.drewek@intel.com> <20230824083201.79f79513@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1693408652; x=1693495052; bh=0qPtmyyUpQSLN Odgbtpe33Gx+tXIvgjJ/8JvU5B4E+8=; b=tO8IWeumdcaoWkBD1zxdBSwvMjxxP PHIEn/o6KClMduHCafpD68S7ggy5J1waZd0ekscD0ItsBl4qPfE7EzlTacdcqCF/ 20VBZ7ybnIlF+YU058eza/9QPlzh4KNs6WLCSnik040m1haqRaof4lEIgM9CpC9X bMi7KmumX9JQrgS4YlotjofumsgNDBd6zBKbEjmoI3GK6EfIxu/COrjrSPBRQwqr 7ET7GyXZRr6uBAiPTtv9fpjTeXeoirTwWNSvx0VqYBNjtRw/+LwaP+V2mCjvFjS6 Uce4ivRaFX2+uO522UwCaTybnCSOdKm2KlqN2hjHSxK6OQPQgOPDL/mzg== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm1 header.b=tO8IWeum Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Disable Cage Max Power override X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jakub Kicinski , "idosch@nvidia.com" , "intel-wired-lan@lists.osuosl.org" , "Kitszel, Przemyslaw" , "netdev@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Aug 29, 2023 at 09:12:22AM +0000, Drewek, Wojciech wrote: > In some cases users are trying to use media with power exceeding max allowed value. > Port split require system reboot so it feels natural to me to restore default settings. I don't believe it's the kernel's responsibility to undo changes done by external tools. Given that the tool is able to change this setting, I assume it can also restore it back to default. Moreover, it doesn't sound like port split won't work without this change, so placing this change there only because we assume that a reboot will follow seems random. I think the best way forward is to extend ethtool as was already suggested. It should allow you to avoid the split brain situation where the hardware is configured by both the kernel and an external tool. _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan