From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49165CD494F for ; Thu, 21 Sep 2023 12:09:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 5650940912; Thu, 21 Sep 2023 12:09:34 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 5650940912 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1695298174; bh=VXbZsDDdUaPZ0skWVfOM5J6zUWQ8kf6J8K7EH0ASgUM=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=RZ3Crvnx33desJ6ZyQSwAnzS/TpYUp/ylTgj5GburBdL4wkKjjA90dy1HSZIDmLMu 9O6F0cffpt878vVtY/rga5dD7IK1QEXvxAxpEoq95+kATFw40hpsnL2vAwNfFN63ZK +H7f6GgUMOx7Z7xKxXCDyhZ/vKNvl87loL713j9M/0paRwzmuNJeXi+MZYFca9eXSC CQ1Bu+zXdFnM3ZPcRt0ofTFer1wXGFAak8QG4uMA47Lypa6RTxVFbHIKQviAkKYniC YQytYgMslPgKD1qh/NjmVGfyWE8G4M3hISodXqeYjz4JD3WqE+MO0W0ku+Y+/BSW/f 5FlFTiMuk7AAA== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KctTuvCJHMUM; Thu, 21 Sep 2023 12:09:33 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 4B002409BD; Thu, 21 Sep 2023 12:09:33 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 4B002409BD Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 5454A1BF3AD for ; Thu, 21 Sep 2023 12:09:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 0CDCF80DB2 for ; Thu, 21 Sep 2023 12:09:31 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0CDCF80DB2 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C0zS__xzuxQ1 for ; Thu, 21 Sep 2023 12:09:30 +0000 (UTC) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by smtp1.osuosl.org (Postfix) with ESMTPS id 5ACB380D37 for ; Thu, 21 Sep 2023 12:09:30 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 5ACB380D37 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id E7EEE32009ED; Thu, 21 Sep 2023 08:09:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 21 Sep 2023 08:09:29 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudekiedggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcu ufgthhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrth htvghrnhepvddufeevkeehueegfedtvdevfefgudeifeduieefgfelkeehgeelgeejjeeg gefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepih guohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 21 Sep 2023 08:09:26 -0400 (EDT) Date: Thu, 21 Sep 2023 15:09:22 +0300 From: Ido Schimmel To: "Drewek, Wojciech" Message-ID: References: <20230824085459.35998-1-wojciech.drewek@intel.com> <20230824083201.79f79513@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1695298168; x=1695384568; bh=j9l1iUgC0pIY3 8j8kkS173GVTz7E0Zg5FtYlimNdc1Q=; b=BXAL3cftBayzpsqFv5k/MafAFDkzx kVCen8ISvlHaatt0bZVZ2+L4HGXWrIS8j4t6BjYaPHDYC3YMecCkVp7eo6KI/nAZ mGHdVBvyEw891k9zrRe1P4c1lhQZTmbokmYunY07TVO12NT4KoOt+Usd15znsdXP PMA+bDPT+VbSZi7eOzDUQf46Yx+dS6s96AInMBL39VoJewulTJrv0yu2aEBJRLpF Cpi0k3x83kU/zLqM82mr1QgUMsQsc7iFsTJxxSGlK5IBhQPl92Bq5F5ql7NaKCvl c5eBH81J0GAkNvGEFcNICuzoxniqcP1bJye8dsMbneKnttYsPdr1C5pSg== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=BXAL3cft Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Disable Cage Max Power override X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jakub Kicinski , "idosch@nvidia.com" , "intel-wired-lan@lists.osuosl.org" , "Kitszel, Przemyslaw" , "netdev@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, Sep 15, 2023 at 01:15:01PM +0000, Drewek, Wojciech wrote: > In ice driver port split works per device not per port. According to > /Documentation/networking/devlink/ice.rst, section "Port split": > The "ice" driver supports port splitting only for port 0, as the FW has > a predefined set of available port split options for the whole device. > And if you look at available port options (same file) you'll see that in case of "Split count" 1 > only quad 1 is working. And in case of "Split count" 2 the second quad might be used. So, if we > increase max_pwr in the first quad in case of "Split count" 1 and then switch to "Split count" 2, > the second quad might end up with no link (because it will have decreased max_pwr). But there's also an option where the second cage isn't actually used. Anyway, my suggestion is to allow user space to set / get the max power using ethtool and give user space visibility about link down reason via the ethtool extended state. _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan