From: Pawel Chmielewski <pawel.chmielewski@intel.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
lukasz.czapnik@intel.com, intel-wired-lan@lists.osuosl.org,
Liang-min Wang <liang-min.wang@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: Reset VF on Tx MDD event
Date: Tue, 24 Oct 2023 14:18:13 +0200 [thread overview]
Message-ID: <ZTe2BSNEJeeb9PgK@baltimore> (raw)
In-Reply-To: <71c02ebc-77f0-4b7d-9a1c-b2ed638f2757@molgen.mpg.de>
Dear Paul,
Thank you for your review!
> > From: Liang-min Wang <liang-min.wang@intel.com>
>
> Should min start with a capital letter Liang-Min?
That's right, I'll correct it.
> > In cases when VF sends malformed packets that are classified as malicious,
> > sometimes it causes Tx queue to freeze. This frozen queue can be stuck
> > for several minutes being unusable.
>
> Did you analyze the cause for this. Why does it freeze only sometimes? Are
> you able to reproduce it?
Yes, we could re-produce the issue using a user space application, testpmd,
from DPDK
>
> > When MDD event occurs, perform graceful VF reset to quickly bring VF
> > back to operational state.
>
> I’d spell out Malicious Driver Detection.
Will do.
>
> Please mention, that a new log message is added.
I'll add this information.
>
> It look like, a patch could be added ahead to factor these parts in a
> separate function.
Which parts (lines) do you have in mind?
Regards,
Pawel
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-10-24 12:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 11:29 [Intel-wired-lan] [PATCH iwl-next] ice: Reset VF on Tx MDD event Pawel Chmielewski
2023-10-24 11:41 ` Paul Menzel
2023-10-24 12:18 ` Pawel Chmielewski [this message]
2023-10-24 13:12 ` Michal Swiatkowski
2023-10-24 16:21 ` Pawel Chmielewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTe2BSNEJeeb9PgK@baltimore \
--to=pawel.chmielewski@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=liang-min.wang@intel.com \
--cc=lukasz.czapnik@intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox