From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9F5CC00A8F for ; Tue, 24 Oct 2023 13:38:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 9882484904; Tue, 24 Oct 2023 13:38:07 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9882484904 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1698154687; bh=X6plavl/SVQgm6gy72Atl02UQEeLjz0HgOT13+BFuoU=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=xJZxCCDmf20VfLN9Z3iGyXdb8fS7GkI8vUWjtpNPQ01FKhC7lviG32PWlycCX50IR le00Y+Hol/v90uYIeloHVYsGChHR8QpQjIwShi2J3euGzTFC13sWRaIPB4/V3fptd/ zf7BNpLIZOVe/SjOwjHtFDfTYU3KU8xaizvFntc/p079E0wSo1auASVRre7pD/rVYh fsmAe9LLSDk8LGPAeK2oCaE4SNwBPnpZVKwkwQ4nd5IK0eQUsZLZDoH7EnjUKozQOS qcfuZ92pXnp0Zx6guwpBytAJ/bTAELMA8qQrqYWlWKb9+n6QTAeYB2pNaRnH0n+OIw lkGpU0TwGdTeg== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VJrLDxwELYgG; Tue, 24 Oct 2023 13:38:06 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 83F4A84912; Tue, 24 Oct 2023 13:38:06 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 83F4A84912 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id CA3151BF377 for ; Tue, 24 Oct 2023 13:38:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id AF25184904 for ; Tue, 24 Oct 2023 13:38:04 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org AF25184904 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e1LzvDtrN26j for ; Tue, 24 Oct 2023 13:38:04 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by smtp1.osuosl.org (Postfix) with ESMTPS id CD3FE84901 for ; Tue, 24 Oct 2023 13:38:03 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org CD3FE84901 X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="367282539" X-IronPort-AV: E=Sophos;i="6.03,247,1694761200"; d="scan'208";a="367282539" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2023 06:38:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="787786624" X-IronPort-AV: E=Sophos;i="6.03,247,1694761200"; d="scan'208";a="787786624" Received: from wasp.igk.intel.com (HELO wasp) ([10.102.20.192]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2023 06:38:01 -0700 Date: Tue, 24 Oct 2023 15:12:54 +0200 From: Michal Swiatkowski To: Pawel Chmielewski Message-ID: References: <20231024112912.1811594-1-pawel.chmielewski@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231024112912.1811594-1-pawel.chmielewski@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698154683; x=1729690683; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=QIgqv1zy6de6ySpoMeSvp9+xL+aseEWSVZkQRUp9/Lc=; b=XyuTJ4C1wdR99/VBEvoYt8JxAyPi50P53IJ+OsVuUxbFQYntmc/2FbXY WWw1rB2eyFmeTglptwWSM1r8bWxBOyEMdXIg+NflCuKEjTPdqUK5mqjxC wEGFbfTJexDYUd0sJUPuKsp3JtwL270a4Hla4f0pluIw/WO6y1UrOVPUq KUjnLVv6ViMf6svyKk1zKvskE7414eWCnqcHF/PryEfYNf5W6N5ITYpPw EYuQPOb6NANdkyV/NF6p9IMPzdcoasev+yeQr4LCSHxWI2km0rs2vf76c /QFXJXmNKvxtMC1+fJMMTAV5IEUcySEhCeQGD+ov/5hZpetLDNdo1Xhq3 Q==; X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=XyuTJ4C1 Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: Reset VF on Tx MDD event X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lukasz.czapnik@intel.com, intel-wired-lan@lists.osuosl.org, Liang-min Wang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Oct 24, 2023 at 01:29:12PM +0200, Pawel Chmielewski wrote: > From: Liang-min Wang > > In cases when VF sends malformed packets that are classified as malicious, > sometimes it causes Tx queue to freeze. This frozen queue can be stuck > for several minutes being unusable. > > When MDD event occurs, perform graceful VF reset to quickly bring VF > back to operational state. > > Signed-off-by: Liang-min Wang > Signed-off-by: Pawel Chmielewski > Reviewed-by: Michal Swiatkowski > --- > drivers/net/ethernet/intel/ice/ice_main.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c > index 66095e9b094e..cf9fd1f168f7 100644 > --- a/drivers/net/ethernet/intel/ice/ice_main.c > +++ b/drivers/net/ethernet/intel/ice/ice_main.c > @@ -1836,8 +1836,13 @@ static void ice_handle_mdd_event(struct ice_pf *pf) > vf->mdd_tx_events.count++; > set_bit(ICE_MDD_VF_PRINT_PENDING, pf->state); > if (netif_msg_tx_err(pf)) > - dev_info(dev, "Malicious Driver Detection event TX_TCLAN detected on VF %d\n", > + dev_info(dev, > + "Malicious Driver Detection event TX_TCLAN detected on VF %d\n", > vf->vf_id); > + dev_info(dev, > + "PF-to-VF reset on VF %d due to Tx MDD TX_TCLAN event\n", > + vf->vf_id); > + ice_reset_vf(vf, ICE_VF_RESET_NOTIFY); > } > > reg = rd32(hw, VP_MDET_TX_TDPU(vf->vf_id)); > @@ -1846,8 +1851,13 @@ static void ice_handle_mdd_event(struct ice_pf *pf) > vf->mdd_tx_events.count++; > set_bit(ICE_MDD_VF_PRINT_PENDING, pf->state); > if (netif_msg_tx_err(pf)) > - dev_info(dev, "Malicious Driver Detection event TX_TDPU detected on VF %d\n", > + dev_info(dev, > + "Malicious Driver Detection event TX_TDPU detected on VF %d\n", > vf->vf_id); > + dev_info(dev, > + "PF-to-VF reset on VF %d due to Tx MDD TX_TCLAN event\n", > + vf->vf_id); You forgot to change TX_TCLAN to TX_TDPU. > + ice_reset_vf(vf, ICE_VF_RESET_NOTIFY); > } > > reg = rd32(hw, VP_MDET_RX(vf->vf_id)); > -- > 2.37.3 > _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan