From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D90A4C4167B for ; Thu, 2 Nov 2023 20:21:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 8F6B270789; Thu, 2 Nov 2023 20:21:45 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8F6B270789 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1698956505; bh=SIJbKlU2DsORrIzE1LKnTWRtS+VFgqZYR5rksZPhU5A=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=dINfP6M5ZHn7A3tVp/kXNu9n9fNPeBjoYlNRV2xeN38GWoRr/SssUcRHLAQOMKJhK fzSN9PhWgubA/ATGWweRW6XyCvTlaiSHa4F5Yz9SCvGibFgYBvxurg8wB0vxJy2ilJ MWbXFUWWwykE8bbpM8MwhLVQyavdqNXpNgEi08txWSyoCDQ5/sgJ51OXhVKnX28hiz Fnd1k7F1rIhhNOvPqLLcMC8qQ6a37aVT5Gl+37DDdrcooGU11BLN0s/ioJveY3VtOY j/n7tvsTz6xkQe+JEbST9StZxqCh+5M1T/oemFMdrz8hTEKYiRT/ZoRXup3RShuxMe K3tO1yJmHF6CA== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GzuIrHdO90Ka; Thu, 2 Nov 2023 20:21:41 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 5F76170771; Thu, 2 Nov 2023 20:21:41 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5F76170771 Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id A2F881BF29C for ; Thu, 2 Nov 2023 19:32:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 0E5247067F for ; Thu, 2 Nov 2023 19:32:45 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 0E5247067F X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hSM201v1cbfp for ; Thu, 2 Nov 2023 19:32:40 +0000 (UTC) X-Greylist: delayed 535 seconds by postgrey-1.37 at util1.osuosl.org; Thu, 02 Nov 2023 19:32:40 UTC DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 12BF27062E Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by smtp3.osuosl.org (Postfix) with ESMTPS id 12BF27062E for ; Thu, 2 Nov 2023 19:32:39 +0000 (UTC) Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:38784) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qydGj-0004u7-19; Thu, 02 Nov 2023 19:22:17 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qydGY-0007YK-66; Thu, 02 Nov 2023 19:22:06 +0000 Date: Thu, 2 Nov 2023 19:22:06 +0000 From: "Russell King (Oracle)" To: Justin Stitt Message-ID: References: <20231102-ethtool_puts_impl-v4-0-14e1e9278496@google.com> <20231102-ethtool_puts_impl-v4-1-14e1e9278496@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231102-ethtool_puts_impl-v4-1-14e1e9278496@google.com> X-Mailman-Approved-At: Thu, 02 Nov 2023 20:21:28 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=GukiPnfP3Xe/TCueOvIoJT0OZefLfRkX+nqu8Htn41o=; b=wd8/C0aoENJPmgNQ8TeNa+MmYG pSMEdo/P+Z0QSaJHP/bMvwGnGVMqcS+OeNG69bQepqX5ysUypXD7SovHC+GJ00PLmtmZelmOy8nvk ZrRLMS9Z28fHf/QTaSOvJYdLMPCd3HKNqv4eUAQUIlKNjautWB33QlLRWR98IIqUX0hnEPRi7T5q9 XnARcEGsrnG7AFikIYM4Y5CIR/aSgienYfitnY2PEKtu6LduA6Cix18Ne6qNA+8A0Azxiw7VJfZ/F wTk5UuGHldo8zXv5MoY9qnspZYB9g/mvvPxGYezIUdPAZAAdTtrIZkfnL8Vqw1dEVbB5F1xvdQA46 ZtJdbomw==; X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.a=rsa-sha256 header.s=pandora-2019 header.b=wd8/C0ao Subject: Re: [Intel-wired-lan] [PATCH net-next v4 1/3] ethtool: Implement ethtool_puts() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , linux-hyperv@vger.kernel.org, Brett Creeley , Ronak Doshi , VMware PV-Drivers Reviewers , John Fastabend , Linus Walleij , Alexei Starovoitov , linux-kernel@vger.kernel.org, Matthias Brugger , Eric Dumazet , Vladimir Oltean , Tony Nguyen , Mengyuan Lou , netdev@vger.kernel.org, Arthur Kiyanovski , Jesper Dangaard Brouer , Louis Peens , Wei Liu , Florian Fainelli , Daniel Borkmann , Steen Hegelund , Dexuan Cui , Jesse Brandeburg , Noam Dagan , Heiner Kallweit , Shenwei Wang , Clark Wang , NXP Linux Team , Jakub Kicinski , Paolo Abeni , Yisen Zhuang , Landen Chao , Shay Agroskin , Daniel Machon , Alvin =?utf-8?Q?=C5=A0ipraga?= , Hauke Mehrtens , Haiyang Zhang , Sean Wang , Nathan Chancellor , Joe Perches , Jiawen Wu , Wei Fang , Lukas Bulwahn , Andy Whitcroft , drivers@pensando.io, intel-wired-lan@lists.osuosl.org, Lars Povlsen , AngeloGioacchino Del Regno , linux-arm-kernel@lists.infradead.org, Salil Mehta , GR-Linux-NIC-Dev@marvell.com, DENG Qingfang , Kees Cook , =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Rasesh Mody , David Arinzon , oss-drivers@corigine.com, Nick Desaulniers , Daniel Golle , "David S. Miller" , Dwaipayan Ray , Saeed Bishara , linux-mediatek@lists.infradead.org, bpf@vger.kernel.org, Dimitris Michailidis , Sudarsana Kalluru , UNGLinuxDriver@microchip.com, Shannon Nelson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Nov 02, 2023 at 06:55:42PM +0000, Justin Stitt wrote: > +/** > + * ethtool_puts - Write string to ethtool string data > + * @data: Pointer to a pointer to the start of string to update > + * @str: String to write > + * > + * Write string to *data. Update *data to point at start of > + * next string. A minor nit... Sorry to jump in a bit late in this, but... concerning the use of "puts" the userspace stdio version adds a trailing newline. Thus, to avoid any confusion, I think the kerneldoc for this should explicitly state that this does not add a newline. * Write string to *data without a trailing newline. Update *data to * point at the start of the next string. This shouldn't be an issue, but it makes the behaviour of it plainly obvious to the reader. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan