From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01AE4C4167B for ; Wed, 29 Nov 2023 14:41:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 8E04F60B53; Wed, 29 Nov 2023 14:41:40 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8E04F60B53 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1701268900; bh=tixl+I4OvfuOulaKLpXBDW/99L5BPYD34qfoylc9gLM=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=K2ZyUoyJaGreBvgkwEe6a1lmo4RP1BtfHLAe2IM7lt0uBAQuwKsBLflvFYZ8ea9qF 1Ny5Ibe6Xz5+mgmoGF1IHmyn2aI+jGxd8GmESg9NH40XZgIN9Rwiu6omMK5+TyBxFm ZOKaCSM6tCH35oXJQwUAhZiEnsJzOAVNQxCUARuLO0mFItk2wlV53Z7evHXPtJF/8o NYn0Bnc/20l2ZHTivlrVYcO4nTewxDUpqm6z8pAj+MrCtgB7CLCSeQvjM+gjXGmMq0 oad6iEmUYaNtZq0FDM9F9Gky2yPlWNMoR6mWofkuS0a4XrVkcoZgBemSOH0bSeg3Re xD7Wcayh0uWHQ== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5vaV6IUEbnK6; Wed, 29 Nov 2023 14:41:39 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 814BC614DB; Wed, 29 Nov 2023 14:41:39 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 814BC614DB Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 814461BF371 for ; Wed, 29 Nov 2023 14:41:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 61D71614DB for ; Wed, 29 Nov 2023 14:41:37 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 61D71614DB X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ybXR-1AOptv3 for ; Wed, 29 Nov 2023 14:41:36 +0000 (UTC) Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by smtp3.osuosl.org (Postfix) with ESMTPS id D905360B53 for ; Wed, 29 Nov 2023 14:41:35 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org D905360B53 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-5488bf9e193so9237397a12.2 for ; Wed, 29 Nov 2023 06:41:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701268893; x=1701873693; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yyYsrVXR9VfHQeLrjs7Rji7raTyh+wNRCcIFYzXejwI=; b=b1Q2nSoXwQaKlmxoyCBC/rbezKaHXjzlZnPa5KDgHkvcXnKJJlsvXy0TH/Yd4vYIVi EvEygOgba9J+DDY3vXAQu1J33X8PPOjF5V+7P1DWt26mqibnDyIaCLJaIt8rZJ/vXSbj O6ZKg79iXTQXhFpljwyXkasbbBs0R1RYH6DX3Qqlt0Rvya+0EwcRual2YufdPV6n1EMG 4pRQMQNksImVc0kHe5u1AS3iDI+yn/kYB/bsgZQwILLnY1UqYDbdWe163Sv81zP1OWdc QZoUwjcIGMK9nQL/7fF4APzEvE8m5SjonnFXiAR45Rq6eAMgXhUQcxvgN+eQNf0Gj8dg 4Qlw== X-Gm-Message-State: AOJu0YwfqHaLUV6vTI4JPujUKGOcwcpW9QSTK6V7jXYVN2fcl6O7DO6U pYRSNDmvZrmE70lU79cZtxAdmQ== X-Google-Smtp-Source: AGHT+IHbWCQjyNsC/fDqwswBwuL8Ht4forXS21KOSAiBuCRNt8Yv7qu5c2eiDsLfudjMrXbWoHZ7aw== X-Received: by 2002:a50:cd9d:0:b0:54b:5243:f7d6 with SMTP id p29-20020a50cd9d000000b0054b5243f7d6mr7475815edi.32.1701268893292; Wed, 29 Nov 2023 06:41:33 -0800 (PST) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id o24-20020aa7c7d8000000b005432f45bee9sm7311740eds.19.2023.11.29.06.41.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 06:41:32 -0800 (PST) Date: Wed, 29 Nov 2023 15:41:31 +0100 From: Jiri Pirko To: "Bahadur, Sachin" Message-ID: References: <20231127060512.1283336-1-sachin.bahadur@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1701268893; x=1701873693; darn=lists.osuosl.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yyYsrVXR9VfHQeLrjs7Rji7raTyh+wNRCcIFYzXejwI=; b=RYU4KI+3o0K01Vy8l0HsnQF6d2NWB29zyP0CIN4V4WNDN6LT3Utjw8KQBN0v60PpH6 RcxWUJam3FkeTCbTYQehs3vHqezAWr5S0R2c5sY2X1mQeP2+XgV491k5Es9y2BuubjYg 7KRbOxUhzvqtqll8HY7sBxGdXH+vzpcHcsfnq8N8Xz49wSyZzs11I+bBILp48LVEr5Ry aIazTV5taBj83g6xtgkzmJLTGvVpv/Moxhhj7QapHlngb7n3JT297s54NF84psedI7FJ UsuJPSJiVshT4hhl6E1ccON+CKJgZ2RoorV6LctF6Br1oPAEg1aj2wfKvC7/nhs5EBCK fRVA== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=RYU4KI+3 Subject: Re: [Intel-wired-lan] [PATCH iwl-net v4] ice: Block PF reinit if attached to bond X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "netdev@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Tue, Nov 28, 2023 at 06:45:47PM CET, sachin.bahadur@intel.com wrote: > > >> From: Jiri Pirko >> Sent: Monday, November 27, 2023 11:38 PM >> To: Bahadur, Sachin >> Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux- >> kernel@vger.kernel.org >> Subject: Re: [PATCH iwl-net v4] ice: Block PF reinit if attached to bond >> >> Mon, Nov 27, 2023 at 05:23:55PM CET, sachin.bahadur@intel.com wrote: >> > >> >> Nack. Remove the netdev during re-init, that would solve your issue. >> >> Looks like some checks are needed to be added in devlink code to make >> >> sure drivers behave properly. I'm on in. >> > >> >Sure. This fix should apply to all drivers. Adding it in devlink makes >> >more sense. I am not a devlink expert, so I hope you or someone else >> >can help with it. >> >> No, you misunderstood. I'll just add a check-warn in devlink for case when port >> exists during reload. You need to fix it in your driver. > > >What should be fixed in my driver. Can you clarify ? >And are suggesting I add the check-warn in devlink code ? Remove the netdev during re-init. > > >> > >> >> >> >> >> >> >+ return -EBUSY; >> >> >+ } >> >> > ice_unload(pf); >> >> > return 0; >> >> > case DEVLINK_RELOAD_ACTION_FW_ACTIVATE: >> >> >-- >> >> >2.25.1 >> >> > >> >> > _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan