From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D1E2C4829E for ; Thu, 15 Feb 2024 16:29:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 1B7F881882; Thu, 15 Feb 2024 16:29:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WGahBfEBLJnc; Thu, 15 Feb 2024 16:29:50 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0F54C81769 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1708014590; bh=ZaEmdsULx3dq76m8EVpwHagNpl3Fq6DzCap5jgabFsQ=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=L7Mon/a0UfVNfKFpN64wZicZEBjlJdCib9yYZFHdsC/R6JJBtzPu2OHptsZMRimcW 0t2+6dUVfgi8vk3arrMrUrKECcpNLo29Tedo0bhuFCmOgUfW3SHLakEnpbJmCYYVqj 4oaWNv7rCsVzayOu8NkmTOZn233+yBvVHWqiOJfE7MevlAhJmwxazwU6kD3A3HcQac 7xGD3zX6AVOLw3O445oqHFIC4l7vaZvn0Ibx8S8WZxNnYkZiIW6g3v6x4HVVmZLKSV RJmyAfOs7n8M5sheNm+nasRdSnU4Wy/Yc8DaLoY/QqLB9X3ySyv19xSzsMhXh6lWRE QwyQS/RbzHZ5A== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 0F54C81769; Thu, 15 Feb 2024 16:29:50 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 5EA351BF340 for ; Thu, 15 Feb 2024 16:29:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 4AF0D81760 for ; Thu, 15 Feb 2024 16:29:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4Psp9D_GHpNt for ; Thu, 15 Feb 2024 16:29:47 +0000 (UTC) X-Greylist: delayed 428 seconds by postgrey-1.37 at util1.osuosl.org; Thu, 15 Feb 2024 16:29:47 UTC DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 1889F8149D DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 1889F8149D Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.15; helo=mgamail.intel.com; envelope-from=maciej.fijalkowski@intel.com; receiver= Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by smtp1.osuosl.org (Postfix) with ESMTPS id 1889F8149D for ; Thu, 15 Feb 2024 16:29:46 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6600,9927,10985"; a="2238590" X-IronPort-AV: E=Sophos;i="6.06,162,1705392000"; d="scan'208";a="2238590" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2024 08:22:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,162,1705392000"; d="scan'208";a="41064437" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Feb 2024 08:22:36 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 15 Feb 2024 08:22:36 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 15 Feb 2024 08:22:35 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 15 Feb 2024 08:22:35 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 15 Feb 2024 08:22:34 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M8itc5RlBZnr2pphyzSot+xXUXq3geqwGqqou4+36O530b2BvnyUJgAdY4LNcuDtz5wvDlwgLCNwo1ws1PD29Gps85A3Wih/euqO7aN+dhEW64PCFZpJteULZtOh4qam3v4gtEi6vZseqFEOPLiL/1/k9dbo/lgCWhEpAhGWiDuLApmcUF/SnspT3jwVyU7TRLwUk6q+9ihkWs733hbY79RvLKcFbgfRfUbgRf4IrDKdWkw0NSweHIUyGj6o8cqUvCQM7UaoXpl5Ytt4ujPFHw1z+yKH60T7KSjGgFm6W4yYgC/cM+L/wQy0LBmur38HhSa6Ivnq2B1wthe8pSkNMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZaEmdsULx3dq76m8EVpwHagNpl3Fq6DzCap5jgabFsQ=; b=TwmFCPO7ulslygZyBhUUmXxGn594uw22ETS7MGKuTF3UnATvsCm0lWlQbWnZbzYWabinxhfzUSr3DItO9rC5zs1K2pEk5ewS8GwLhr+x1p1uP+wz8RGL3zEoUsRf0g4dTUPmuyl/smbPbD19HxYGGZ1wMJ7epkAEKaOhjthsUCXAuHbk9rvANRE3wd5ZYWnqb5Xo1RcvAjUrboTABE6Kh4/5yGp3wSX6KuGLdiWYzxs+66W5ejx42VPDzdTDDxWxaUEroemF1VBKOv7eSkwr/cwxREEpvTekfj8fYF5mLvYvv0u4Xz4dyCm1L32IZn0EQr2BZ7dF/w0E9bdxtx0TnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB6117.namprd11.prod.outlook.com (2603:10b6:8:b3::19) by CO1PR11MB4964.namprd11.prod.outlook.com (2603:10b6:303:9e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.31; Thu, 15 Feb 2024 16:22:29 +0000 Received: from DM4PR11MB6117.namprd11.prod.outlook.com ([fe80::ccab:b5f4:e200:ee47]) by DM4PR11MB6117.namprd11.prod.outlook.com ([fe80::ccab:b5f4:e200:ee47%6]) with mapi id 15.20.7292.029; Thu, 15 Feb 2024 16:22:29 +0000 Date: Thu, 15 Feb 2024 17:22:24 +0100 From: Maciej Fijalkowski To: "Loktionov, Aleksandr" Message-ID: References: <20240120072806.8554-1-suresh2514@gmail.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: FR0P281CA0177.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b4::16) To DM4PR11MB6117.namprd11.prod.outlook.com (2603:10b6:8:b3::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6117:EE_|CO1PR11MB4964:EE_ X-MS-Office365-Filtering-Correlation-Id: b06ceab6-95af-47bb-4267-08dc2e424e39 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kFGaTclkSSUb8XyrEgg2kN/hmTAFsEzSKS+a8L5YJBt/hXLw+mGxyASvybIjM7sQSHsT6ge+RdfDn8lR6vuGY+7z/DaPLq/kMpvTeG4PBxrRAvJJ8dY4OJkSZqEVqM7n9NM7aNWT/E2q4RvIy5d/Q3+Dn2Ydfgzm5OqjhrBJ97AFxJ1FCo5/wJGfsGSon0ma9kvr0dW+4xLkUOjL0bs9HBqzFVlB6loy/wBf76/Jmz9Gn+LoUROnuXMCHY0K7BAoeMhzbevVIW72pYegJfETT6T/vclo/sgaE9GSyunGpBZ7dgurND7th/vrMXAAuixNgy5FAK70YUSM2JDv0U6C1yUezlsE0ZyiPyQH8WjKjjpSfTbwv/eUWq9ZqgFTHzUX3xzCegOBopHQC74kdrcOBSJVrCVgQA4FiDPCntiCNKmf3cNtIOOQ2mT4LVaPnQ4yDnOj8MtIk0LdJnzGvzrHtZgGlt9PUGSAjyHtUEWlAJCF5rTcSx4jC341MI3yql+RMJXzNIIop5Tquof7+it7cJNPWx9Cwcu09gv50MldOXo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6117.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(7916004)(366004)(346002)(39860400002)(396003)(136003)(376002)(230922051799003)(186009)(451199024)(1800799012)(64100799003)(33716001)(82960400001)(5660300002)(44832011)(2906002)(38100700002)(4326008)(6862004)(26005)(6636002)(66476007)(8676002)(66946007)(66556008)(54906003)(6666004)(316002)(8936002)(966005)(9686003)(6506007)(6486002)(478600001)(53546011)(6512007)(86362001)(41300700001)(83380400001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PzVF3Kqjih6LfI2bhugCvZsQVwyYF2NNFzIvTnVFkWCI70rCcF+7q26WJpbo?= =?us-ascii?Q?KoiXc6QiNV+N7ibsoC4yI6GDP3Q74JKc7HezjFs6YfQuOK/6Sb51IS8Ra2Re?= =?us-ascii?Q?bBmV0YK2FVVTp6kzLhgKyMvOzWamfudsj4sd+YxuFP9D/5tQ0llouBbYDuVC?= =?us-ascii?Q?C5Ct9QoYhwzwr2FOF8cgqrBKQqRygAioL0cE4XxsR01ebJVAJ9UbmrOLsgjl?= =?us-ascii?Q?VRgiv1IilfhzIVgmbzZQHcm3kixGgbEohuMDBiBP1vG+8pOhmkRvABdf51I8?= =?us-ascii?Q?NmNhFrC6qT8ReWplM5hWJpmYqb0bs3k3H3lW4t5dMHjxRGO9oP6D32F++h0B?= =?us-ascii?Q?str/hU3Vvja0kxlwG8bIgQmtz+ES0gQdZXVRLkdnj82c/HnvVZnKsKnHiKG2?= =?us-ascii?Q?5IIB2khA54PCVv+/Roxm5IIdUaEd1ISQpnfG3U5h/gHxV5QNvMxxAXOQPQMF?= =?us-ascii?Q?YRHyvzTSWzOKagWrLYdOBQA1Ib0apljRVdv0VMq0BYnE2Duaz2IB2hX0ShKt?= =?us-ascii?Q?uQTHrL0UChmNcZxL67PNnUuJy4n8gvp+nqbEdd4xyoeWC64auWwtUFqShkWI?= =?us-ascii?Q?114r6NNwPJPzwpyuPOKbG5/IYBdUjqYsCU00JgsGxtW5Ah35J/Qug6SRul+o?= =?us-ascii?Q?pgXqaJ1inOZm5ojuYr93z6Wyqaq38/tfZY8WOBXP0baZuLtL/qetyPdEhXtO?= =?us-ascii?Q?zheJVw2FH7bXAmE46yuqO4WFzCKxt37O+44OdBhp8VuDTrM5zqy0X8rCL7OL?= =?us-ascii?Q?p0XPvXzMO9iDoFgiwC96RK6uvKsK+nKN6ll9DHb0nS+5uKcS91bi5tP3yGbW?= =?us-ascii?Q?275U0CtQzpCg0kHjXtq2z9RJUx/owhukR6eFNcHx6Z6MPEb/fqsiqZdUfwQ1?= =?us-ascii?Q?HFxjC+kzB2kVTx7H+E/iadyY4AoqNL9hGYRPbwhO8V/7rgSXAlJ03iEDa+pY?= =?us-ascii?Q?1Z8gpLL6x1P8Nj2qKI6nhcZWEuEBNbGbfOISQr6CIarSI0fhWBOJyfHfFVRN?= =?us-ascii?Q?81YX0yleqdiEEdfGuta2D3hqwayPH7iGK2PocquTxy8vjY0V1ta1T0Xi/71n?= =?us-ascii?Q?E5kIKYKEIWQeCZZ2DVoPhgDPTZDYqucwy6+TVEJ/a3jBtda05vWk4Qey7sJR?= =?us-ascii?Q?ZgpnPdZmd1uFN+UFIeKsRXMQQ9mly9hIWaoF8YatbXBIWMv2w43L2P6Ua7kb?= =?us-ascii?Q?dwuQf/V5KuIEhJKyDG0decRR90ETcXpM4ermh3rTfzAwW4iqGaiP7bm294Bj?= =?us-ascii?Q?I6xbstEZZWjpLysy72IE5Ivgw0p7lFCJqbQdWMHfsjmJ9xxB+FgyEMl/dzaD?= =?us-ascii?Q?vmRSJVqAObs52IpIJf0j2t8P6HTbGJwYbPwJfY/dBI5HUmLaF8U3ZhSCq/Ti?= =?us-ascii?Q?sPMR1qc/ZhcDlkRNY+qVBbmQ46ESYlD4UFa4pAXl9OkZiBwWalmh6VgkmueW?= =?us-ascii?Q?JJzU+wzHfwNBG+AeiIVsX6GP/acgEhZdxlYFv16zglFmM05jMpBc9NlvRw0m?= =?us-ascii?Q?kQqb+y2GVFVu2zG8QQn+LhFZC8yrRf6o1+QBTxKOG0lfKQrQWgOyG4jRfXYh?= =?us-ascii?Q?iLy+HfBUgByWuOp+551NwTOXnPzvh3SbGNhUk0WBeNpLN8XDTq25MLWZIeWi?= =?us-ascii?Q?lw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: b06ceab6-95af-47bb-4267-08dc2e424e39 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2024 16:22:29.6983 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GMSC8aMgoOXjF6wRZyxXuC1xJJmN2Sg4gWDsVOA/i6RQAIWHJ71lQjQSRgZaY+qnpt3BQaZaqH0TKHUgqKCiHtB8E8xQJscY1FZ90mOVv4c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4964 X-OriginatorOrg: intel.com X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708014587; x=1739550587; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=q2CIOf1GztNLWfsKwqMOSncSskTbnAgV4jkW3zoW83o=; b=LxFK4NX0Vnu+sUu42seoLWewXQYCCLXg7ygKhzj5orAgzQA1e82QhKZN 22o93X3Mx9vCf+KUh3fQUgNUDHFI8GYHX1Yw5xmLqZNgUpM6jyOM+hFVw hECEMjQ0ee6Umn/xn1BUQaUY+p/ce+Ms4ZObR62jyDFMNIMJVQWFElOq7 1Eda6ivm299Hso4U0XBs8yqA+OIVJ01FmOh3i2Br28s5KzFzdEMfxBN8J Tt8C7o9GOFqVhaPnNefpoi9mInGXLTE1/BOnuV29F6NH+CF6oserIIaSm mqjXxZSKJbRVviONP5Hkhr3gsotteEzl8eTDiO7iKdiDwOZ3st0Rl+O0O A==; X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=intel.com X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=LxFK4NX0 X-Mailman-Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Subject: Re: [Intel-wired-lan] [PATCH iwl v2] i40e: print correct hw max rss count in kernel ring buffer X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Kitszel, Przemyslaw" , "Brandeburg, Jesse" , "linux-kernel@vger.kernel.org" , "edumazet@google.com" , "netdev@vger.kernel.org" , "Nguyen, Anthony L" , "intel-wired-lan@lists.osuosl.org" , "kuba@kernel.org" , Suresh Kumar , "pabeni@redhat.com" , "davem@davemloft.net" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Jan 30, 2024 at 08:33:43AM +0000, Loktionov, Aleksandr wrote: > > -----Original Message----- > > From: Kitszel, Przemyslaw > > Sent: Tuesday, January 30, 2024 9:26 AM > > To: Loktionov, Aleksandr > > Subject: Fwd: [PATCH iwl v2] i40e: print correct hw max rss count Subject should be iwl-net and you should have Fixes: tag. I also would like you to go through https://docs.kernel.org/process/submitting-patches.html or any other document that would prepare you for your first submission. > > in kernel ring buffer > > > > FWD to Alex > > > > > > -------- Forwarded Message -------- > > Subject: [PATCH iwl v2] i40e: print correct hw max rss count in > > kernel ring buffer > > Date: Sat, 20 Jan 2024 12:58:06 +0530 > > From: Suresh Kumar > > To: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, > > davem@davemloft.net, edumazet@google.com, kuba@kernel.org, > > pabeni@redhat.com, intel-wired-lan@lists.osuosl.org, > > netdev@vger.kernel.org, linux-kernel@vger.kernel.org > > CC: Suresh Kumar > > > > pf->rss_size_max is hardcoded and always prints max rss count as > > 64. > > > > Eg: > > kernel: i40e 0000:af:00.1: User requested queue count/HW max RSS > > count: 104/64 > > > > whereas ethtool reports the correct value from "vsi- > > >num_queue_pairs" > > > > Channel parameters for eno33: > > Pre-set maximums: > > RX: n/a > > TX: n/a > > Other: 1 > > Combined: 104 > > Current hardware settings: > > RX: n/a > > TX: n/a > > Other: 1 > > Combined: 104 <------- > > > > and is misleading. > > > > Change it to vsi->num_queue_pairs > > Please reject this patch, it breaks driver logging. > The massage clearly states that it dumps max rss queues number that f/w supports. ...which would imply that you would be able to work with anything more than 64 queues. From a quick glance rss_size_max comes from early i40e days and if that would be the limit indeed then driver allowing 104 queues would be a disaster, no? > > Thank you > > > Signed-off-by: Suresh Kumar > > --- > > drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c > > b/drivers/net/ethernet/intel/i40e/i40e_main.c > > index d5519af34657..f5c1ec190f7e 100644 > > --- a/drivers/net/ethernet/intel/i40e/i40e_main.c > > +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c > > @@ -12524,7 +12524,7 @@ int i40e_reconfig_rss_queues(struct i40e_pf > > *pf, int queue_count) > > i40e_pf_config_rss(pf); > > } > > dev_info(&pf->pdev->dev, "User requested queue count/HW max > > RSS > > count: %d/%d\n", > > - vsi->req_queue_pairs, pf->rss_size_max); > > + vsi->req_queue_pairs, vsi->num_queue_pairs); IMHO this should be vsi->alloc_queue_pairs instead. > > return pf->alloc_rss_size; > > } > > -- 2.43.0 > > >