From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35732C4828F for ; Thu, 8 Feb 2024 11:27:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C0D1E85164; Thu, 8 Feb 2024 11:27:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jJEwl6MCF1pn; Thu, 8 Feb 2024 11:27:01 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org BF1C085168 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1707391621; bh=ENe6a0MGhFAYwxbIJ6WLGpev+wUMn3WNP3NeinQqkpk=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=bOc9Rhe82xtu/fgxkKFe7RXFutiw8YT+tqDD6ORXhRDBYnxQrZbRkpOJlFEAgF3u4 h82C8oTTVJMoj498zYb6VEyvh4zUEaVvnBPeVwPCTLTrYmsop7rXg/JUHWF+jnzNeG H5sCQ2EXZ8Vf3grT0qcaV0GG5OFO8nRShptO4qiirn7OOaQHH95PQD6hQ4h/cxxRE1 3gSsEwWyVUSBjSNWt8XQ4BK27oaoEnCyp/xqb54V+OYIV/L+XCp6OTpsk3R1Nzhkkd kc7Q88KsX4x6U1+zNqGqOvQRPlYhZSUpfo/Tdtut5No0/2o4vuSvaxtdGkF4qFoT/M /5OQKNBdHyD1w== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id BF1C085168; Thu, 8 Feb 2024 11:27:01 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 1E4481BF267 for ; Thu, 8 Feb 2024 11:27:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 0925961683 for ; Thu, 8 Feb 2024 11:27:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hsD8XzWXNdNy for ; Thu, 8 Feb 2024 11:26:57 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::32a; helo=mail-wm1-x32a.google.com; envelope-from=jiri@resnulli.us; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 5A967615EB DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5A967615EB Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by smtp3.osuosl.org (Postfix) with ESMTPS id 5A967615EB for ; Thu, 8 Feb 2024 11:26:55 +0000 (UTC) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-41001c6e19aso4512495e9.1 for ; Thu, 08 Feb 2024 03:26:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707391613; x=1707996413; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ENe6a0MGhFAYwxbIJ6WLGpev+wUMn3WNP3NeinQqkpk=; b=Wlzi+ncqa4hELRMlbyIUX69lOq/epptNjFrDaqkCHHBRn6e+n6q1hHas84o6xZoy2I Bvec/DnkmM3STvCXTwAhKMYEozIXvvVTCgk2eWNLMlFEor33TSAUpDgu3TCawTQWfdi/ Zsy7OJ5pTI8aPz5s3IaQT2bWbCBHTphr9IT1UlDk81xtsGnxXgnzWvXK6ua4FtSuoXiZ breXDNmL53GeK0yUIcznOqkSgbxyapiJImsWYnQrQnA8gvBt+/UL2Rhi63zI7ZOF+wU9 LIIu1YvIO5iMZpXLlFdA0xdcxzOiffSu/TvpoMOwawv98tJlyJ5zbZ+V9U5NcvpItpsv AG7Q== X-Forwarded-Encrypted: i=1; AJvYcCUIVYc3hBzguw9b4/xnSurV4qFFUsFJcHoD1+8dj8UU1mw7ZAXG9Oyn6HtP0JhCi9NvkRUMcOrfhTXNNVUUmSQmSnnqFPEtn2iFbrDpdlEkjw== X-Gm-Message-State: AOJu0YzPgMVw0ZUx0NvMMwXafJ9KR56cLyVwZRSdDvx4N1PBmBzIvGpm FFayfAuvDxO5b55IRPuqxMWhKi8TujozmB+6lc1k62MvyVJt5f90CGJAU+uRqt4= X-Google-Smtp-Source: AGHT+IFynlbwaELVo7GaJVr7oESUnpHbKAXacrmgWYI4W/2zafauLyOMJtviUIiHO9Q94lIKXOCKWg== X-Received: by 2002:a05:600c:4f85:b0:40f:cb0d:4de6 with SMTP id n5-20020a05600c4f8500b0040fcb0d4de6mr1845639wmq.5.1707391613110; Thu, 08 Feb 2024 03:26:53 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVW2Sm7rwhnabfFI7IcIwsENsKhtSUWvyRauqFuYAvoIjG/4y7F+DfxNyxTxHGb0FC7lUWC4P8zebZuakFqVkSGmy2Yf/jd/UpReDdaGbvflchYAAZqAUuYSnAIDb2VJU2exvpPCNWGfX2rGUvgE8rBkOfGX+SRTzea9Mg2OFLwmhDGjQuMhoQNRQLKfwM5JwuqEKHczoxOdTo0cYNaOJo07RAeuo4yVky/5el9GY65WyIYI4jHfigrA5/+qnQUEicm1joLlowjxL8S4j3o3hiLwa315369rc07YXFhdQFksLjg9ME1WwIXXleVHWjXFGIyWpCSxam41nkLM1WNFia6/bmOSvC6hy5GTymBQ9kxL2tcgGXyM/tF/lZZRyXWFnBNJCa1g8dxOg87xmjUo5suYF9sEHQGpBQqXhMOWXaptvauVU8xFzdYoNUqQ88m+UIewxzPCoN7PC/+QzPPI2VT89k3Yrnz/Jioj/mE9Ef8IHWVyf2w0BAlWd9auzfvdA16rHTJ/dAQFDm5SKTOtSo= Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id fb12-20020a05600c520c00b004103bd6f21dsm1181908wmb.35.2024.02.08.03.26.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 03:26:52 -0800 (PST) Date: Thu, 8 Feb 2024 12:26:51 +0100 From: Jiri Pirko To: Karthik Sundaravel Message-ID: References: <20240208082455.66726-1-ksundara@redhat.com> <20240208082455.66726-2-ksundara@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240208082455.66726-2-ksundara@redhat.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1707391613; x=1707996413; darn=lists.osuosl.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ENe6a0MGhFAYwxbIJ6WLGpev+wUMn3WNP3NeinQqkpk=; b=Oj+M3jgq6SdqFDkRkuEaBI0SYw370dwjCxYxdh64m/i7XHfTXKK3ylSg7yzWGIOqI+ 7YsTZIHYXvmp/jo9f+0p4YshkuwX9VPOqXjS8hhfxEkm+wWq8WmmHYAlLpVFlZmCigwX qYDKLfRM9aNYB2n+q8WW9s28RSkYD2wUoJgIpDmRDOTEJOMKgmNupJ+fxB4dUh4LgyYK 7HT/F7gcx6UAOxykmPQwqnOGgdhPJ40XFQzrD6GcRsdx9u6Qb6haUvfiPcS5vRhwwzox G1sajGFhH9YjTYmbOc/OxDU8wXJ98qNCOWj2Edq+RzUnxcsPz9bcb/nvkssZoLgEA8Zy 7elA== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=none (p=none dis=none) header.from=resnulli.us X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=Oj+M3jgq Subject: Re: [Intel-wired-lan] [PATCH v2] ice: Add get/set hw address for VFs using devlink commands X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pmenzel@molgen.mpg.de, aharivel@redhat.com, michal.swiatkowski@linux.intel.com, cfontain@redhat.com, intel-wired-lan@lists.osuosl.org, jesse.brandeburg@intel.com, linux-kernel@vger.kernel.org, edumazet@google.com, anthony.l.nguyen@intel.com, vchundur@redhat.com, netdev@vger.kernel.org, kuba@kernel.org, rjarry@redhat.com, pabeni@redhat.com, davem@davemloft.net Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Thu, Feb 08, 2024 at 09:24:55AM CET, ksundara@redhat.com wrote: >Changing the MAC address of the VF ports are not available >via devlink. Add the function handlers to set and get >the HW address for the VF ports. "VFs". Avoid the word "port" here, as it may falsely indicate you are talking about the eswitch representor port. > >Signed-off-by: Karthik Sundaravel >--- > drivers/net/ethernet/intel/ice/ice_devlink.c | 89 +++++++++++++++++++- > 1 file changed, 88 insertions(+), 1 deletion(-) > >diff --git a/drivers/net/ethernet/intel/ice/ice_devlink.c b/drivers/net/ethernet/intel/ice/ice_devlink.c >index 80dc5445b50d..8455fa94a687 100644 >--- a/drivers/net/ethernet/intel/ice/ice_devlink.c >+++ b/drivers/net/ethernet/intel/ice/ice_devlink.c >@@ -1576,6 +1576,92 @@ void ice_devlink_destroy_pf_port(struct ice_pf *pf) > devlink_port_unregister(&pf->devlink_port); > } > >+/** >+ * ice_devlink_port_get_vf_mac_address - .port_fn_hw_addr_get devlink handler >+ * @port: devlink port structure >+ * @hw_addr: MAC address of the port >+ * @hw_addr_len: length of MAC address >+ * @extack: extended netdev ack structure >+ * >+ * Callback for the devlink .port_fn_hw_addr_get operation >+ * Return: zero on success or an error code on failure. >+ */ >+ >+static int ice_devlink_port_get_vf_mac_address(struct devlink_port *port, >+ u8 *hw_addr, int *hw_addr_len, >+ struct netlink_ext_ack *extack) >+{ >+ struct devlink *devlink = port->devlink; >+ struct ice_pf *pf = devlink_priv(devlink); >+ struct device *dev = ice_pf_to_dev(pf); >+ struct devlink_port_attrs *attrs = &port->attrs; >+ struct devlink_port_pci_vf_attrs *pci_vf; >+ int vf_id; >+ struct ice_vf *vf; Reverse xmas tree: https://www.kernel.org/doc/html/v6.7/process/maintainer-netdev.html#tl-dr >+ >+ if (attrs->flavour == DEVLINK_PORT_FLAVOUR_PCI_VF) { >+ pci_vf = &attrs->pci_vf; >+ vf_id = pci_vf->vf; >+ } else { >+ dev_err(dev, "Unable to get the vf id for PF %d\n", pf->hw.pf_id); Fill the extack message instead. >+ return -EADDRNOTAVAIL; >+ } >+ vf = ice_get_vf_by_id(pf, vf_id); >+ if (!vf) { >+ dev_err(dev, "Unable to get the vf for PF %d\n", pf->hw.pf_id); Fill the extack message instead. >+ return -EINVAL; >+ } >+ ether_addr_copy(hw_addr, vf->dev_lan_addr); >+ *hw_addr_len = ETH_ALEN; >+ return 0; >+} >+ >+/** >+ * ice_devlink_port_set_vf_mac_address - .port_fn_hw_addr_set devlink handler >+ * @port: devlink port structure >+ * @hw_addr: MAC address of the port >+ * @hw_addr_len: length of MAC address >+ * @extack: extended netdev ack structure >+ * >+ * Callback for the devlink .port_fn_hw_addr_set operation >+ * Return: zero on success or an error code on failure. >+ */ >+static int ice_devlink_port_set_vf_mac_address(struct devlink_port *port, >+ const u8 *hw_addr, >+ int hw_addr_len, >+ struct netlink_ext_ack *extack) >+{ >+ struct devlink *devlink = port->devlink; >+ struct ice_pf *pf = devlink_priv(devlink); >+ struct device *dev = ice_pf_to_dev(pf); >+ struct net_device *netdev = port->type_eth.netdev; >+ struct devlink_port_attrs *attrs = &port->attrs; >+ struct devlink_port_pci_vf_attrs *pci_vf; >+ int vf_id; >+ u8 mac[ETH_ALEN]; Reverse xmas tree: https://www.kernel.org/doc/html/v6.7/process/maintainer-netdev.html#tl-dr >+ >+ if (attrs->flavour == DEVLINK_PORT_FLAVOUR_PCI_VF) { >+ pci_vf = &attrs->pci_vf; >+ vf_id = pci_vf->vf; >+ } else { >+ dev_err(dev, "Unable to get the vf id for PF %d\n", pf->hw.pf_id); Fill the extack message instead. >+ return -EADDRNOTAVAIL; >+ } >+ >+ if (!netdev) { >+ dev_err(dev, "Unable to get the netdev for PF %d\n", pf->hw.pf_id); Fill the extack message instead. >+ return -EADDRNOTAVAIL; >+ } >+ ether_addr_copy(mac, hw_addr); >+ >+ return ice_set_vf_mac(netdev, vf_id, mac); >+} >+ >+static const struct devlink_port_ops ice_devlink_vf_port_ops = { >+ .port_fn_hw_addr_get = ice_devlink_port_get_vf_mac_address, >+ .port_fn_hw_addr_set = ice_devlink_port_set_vf_mac_address, >+}; >+ > /** > * ice_devlink_create_vf_port - Create a devlink port for this VF > * @vf: the VF to create a port for >@@ -1611,7 +1697,8 @@ int ice_devlink_create_vf_port(struct ice_vf *vf) > devlink_port_attrs_set(devlink_port, &attrs); > devlink = priv_to_devlink(pf); > >- err = devlink_port_register(devlink, devlink_port, vsi->idx); >+ err = devlink_port_register_with_ops(devlink, devlink_port, >+ vsi->idx, &ice_devlink_vf_port_ops); > if (err) { > dev_err(dev, "Failed to create devlink port for VF %d, error %d\n", > vf->vf_id, err); >-- >2.39.3 (Apple Git-145) >