From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4513AC4829A for ; Tue, 13 Feb 2024 12:03:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id B7E914117D; Tue, 13 Feb 2024 12:03:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HWnG_qmk0FTn; Tue, 13 Feb 2024 12:03:42 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org A7E4240C53 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1707825822; bh=NZ6KehMlPer9e5MfjeWiWfw+C+rsE+HP0tEcJWuwNy4=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=uCkpN0+jDEL4QJGG/Oahd8drpnVnIXPXhgJJiJtPbZDPds0yQYnueBul5+IbyR6N+ x8jdkU9cNsfFdJIxY8ImNcdgTAzUs3FOocFmffidqdjPjd1Cse2FUuO/YUGkWuLM4A cK4wXDne+WKFm8msz/tRkU+v6RY4V9a1mjxc2o0o6BNlgiRTOlBrBOz/mwY5k9ZveL Otc4o0Or5ftcv0/f8jOehenOi695To5sflH8zQOBWD0woDJ9ZvaPSHzMnpXTaT92lF xNKIqnSLcJQKMlqmdKvbzu1vwIIuNcKKq01UfSSSaYre+hhyky7WlVEoXb0Z1n0tfT Ewy2jaEpelj4Q== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id A7E4240C53; Tue, 13 Feb 2024 12:03:42 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 801AA1BF421 for ; Tue, 13 Feb 2024 12:03:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 6CDE4410B2 for ; Tue, 13 Feb 2024 12:03:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7yJVGjPYd0yu for ; Tue, 13 Feb 2024 12:03:40 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=198.175.65.20; helo=mgamail.intel.com; envelope-from=michal.swiatkowski@linux.intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 98063410AF DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 98063410AF Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by smtp4.osuosl.org (Postfix) with ESMTPS id 98063410AF for ; Tue, 13 Feb 2024 12:03:40 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6600,9927,10982"; a="1704561" X-IronPort-AV: E=Sophos;i="6.06,157,1705392000"; d="scan'208";a="1704561" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2024 04:03:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10982"; a="935338476" X-IronPort-AV: E=Sophos;i="6.06,157,1705392000"; d="scan'208";a="935338476" Received: from unknown (HELO mev-dev) ([10.237.112.144]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2024 04:03:37 -0800 Date: Tue, 13 Feb 2024 13:03:34 +0100 From: Michal Swiatkowski To: Jiri Pirko Message-ID: References: <20240213072724.77275-1-michal.swiatkowski@linux.intel.com> <20240213072724.77275-7-michal.swiatkowski@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707825820; x=1739361820; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=jPD6VUJO3XrE6zwrOjtPDfOxslEHv4Z7+L1r1W3Bxes=; b=Q5lnKAOpNNxYSQDkeEbsPgYzEqMRQK4lJA3nGkTWgrc2GBEoFsetNU6J jZWK7U/EiAQybfWKK0NjB33iLNqXewBncFD+yOORidN1BLw5qvDHwuKzo 8XZDaZ4/S2AhYrBRQ3phUsCZ9RCWQXbsuFB9mLhS/Ai7LTFTQZYu+h5Ou /vbeU+tKmCFlMFI2uabYdWD5YowAFQWPruddCO/NrlJueroHMLK2NULuj 3KCFQWur78Hhck+uwfKtAvYjaO4Ns03+rxv9rgQNw5nGzEVFChz9z+AFG N/mUvc51O1YdoX4zLOyNidu7XnnN3LGgQDICirGugwQFUtV+lD3N/GbU5 Q==; X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=none (p=none dis=none) header.from=linux.intel.com X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Q5lnKAOp Subject: Re: [Intel-wired-lan] [iwl-next v1 06/15] ice: add subfunction aux driver support X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: maciej.fijalkowski@intel.com, netdev@vger.kernel.org, michal.kubiak@intel.com, intel-wired-lan@lists.osuosl.org, pio.raczynski@gmail.com, sridhar.samudrala@intel.com, jacob.e.keller@intel.com, wojciech.drewek@intel.com, Piotr Raczynski , przemyslaw.kitszel@intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Feb 13, 2024 at 12:28:19PM +0100, Jiri Pirko wrote: > Tue, Feb 13, 2024 at 10:43:00AM CET, michal.swiatkowski@linux.intel.com wrote: > >On Tue, Feb 13, 2024 at 09:57:12AM +0100, Jiri Pirko wrote: > >> Tue, Feb 13, 2024 at 08:27:15AM CET, michal.swiatkowski@linux.intel.com wrote: > >> >From: Piotr Raczynski > >> > > >> >Instead of only registering devlink port by the ice driver itself, > >> >let PF driver only register port representor for a given subfunction. > >> >Then, aux driver is supposed to register its own devlink instance and > >> >register virtual devlink port. > >> > > >> >Reviewed-by: Wojciech Drewek > >> >Signed-off-by: Piotr Raczynski > >> >Signed-off-by: Michal Swiatkowski > >> >--- > >> > .../intel/ice/devlink/ice_devlink_port.c | 52 ++++- > >> > .../intel/ice/devlink/ice_devlink_port.h | 6 + > >> > drivers/net/ethernet/intel/ice/ice_devlink.c | 28 ++- > >> > drivers/net/ethernet/intel/ice/ice_devlink.h | 3 + > >> > drivers/net/ethernet/intel/ice/ice_main.c | 9 + > >> > drivers/net/ethernet/intel/ice/ice_sf_eth.c | 214 ++++++++++++++++-- > >> > drivers/net/ethernet/intel/ice/ice_sf_eth.h | 21 ++ > >> > 7 files changed, 302 insertions(+), 31 deletions(-) > >> > >> Could you please split this. I see that you can push out 1-3 patches as > >> preparation. > > > >Do you mean 1-3 patchses from this patch, or from whole patchset? I mean, > > This patch. > > >do you want to split the patchset to two patchsets? (by splitting patch > > Yes, 2 patchsets. If convenient 3. Just do one change per patch so it is > reviewable. > > Ok, will do that. > >from the patchset I will have more than netdev maximum; 15 I think). > > > >Thanks, > >Michal