From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7E60C4345F for ; Wed, 17 Apr 2024 11:42:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 5329A6059D; Wed, 17 Apr 2024 11:42:32 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id tKPabjj-4Vxc; Wed, 17 Apr 2024 11:42:31 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5E6916088F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1713354151; bh=0Qoj272mVuVUU8ywY76KO/Wt2XEqCeWEjLpkk1RkfKg=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=wUTvF3f0tx0+AcPaP0LqyV8jem41VgwB8Oi3xEY8rb0wylC89Ui2uIj/VVFKvI8Q5 vbgPfLbPEQVxlLu9YqPmp95An5fw2rCaFkGrvdKiIHbuH0sHiieaJeumNR7Wf665L+ KRcan2XPqNdTI4hUxcWWzD48hBGq0r+aWHodoSkD0q4ibj3u9DG0BAHvQfBcUCsIwi HucP0006QoE+k1qAyFgyMQq9yPlKR03YqdK9ZF+LLJrenaHPgJHLntNmxKZKcKeWCl ckU4gfPDEqKyJev1/HxDlJNOi9BoihqNRHZPNBoSJ7/CoRjTF59Cl+QNDPMpoSUWJ4 UZkQjaVbrkPaQ== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 5E6916088F; Wed, 17 Apr 2024 11:42:31 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 969FB1BF2B7 for ; Wed, 17 Apr 2024 11:42:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 8F2FB6088F for ; Wed, 17 Apr 2024 11:42:29 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Ai5z8i-o96QP for ; Wed, 17 Apr 2024 11:42:28 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.15; helo=mgamail.intel.com; envelope-from=maciej.fijalkowski@intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 5E5306059D DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5E5306059D Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by smtp3.osuosl.org (Postfix) with ESMTPS id 5E5306059D for ; Wed, 17 Apr 2024 11:42:28 +0000 (UTC) X-CSE-ConnectionGUID: bs8eGSnpTr20ulSrTobUhw== X-CSE-MsgGUID: iSOqDIplRJ+htBr9xqblbg== X-IronPort-AV: E=McAfee;i="6600,9927,11046"; a="12625090" X-IronPort-AV: E=Sophos;i="6.07,209,1708416000"; d="scan'208";a="12625090" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2024 04:42:28 -0700 X-CSE-ConnectionGUID: ed20tlWkSC++blMn2AeVpg== X-CSE-MsgGUID: vRIOPudCT/yTXX+WGvs5cA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,209,1708416000"; d="scan'208";a="27382753" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 Apr 2024 04:42:28 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 17 Apr 2024 04:42:26 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 17 Apr 2024 04:42:26 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 17 Apr 2024 04:42:26 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 17 Apr 2024 04:42:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a2sebsc4SIxJ0ukxMbJVx1iEe7xmjiET9cQVCsMIRNm64NXgAuD0ezmdRylq0d0I6wtD1uw66kjDLF0ya8Qb4PLm+OQhlDi+MSYPtyMA/5q0LM1EoIfNjWpZ1YxVd2+C19E+70AbWMLtSA0C60QgKDbCExTSBneEWozUzaBdpc0VKNMwGfFIpe7Lg4poTGy+czAZk7HbyWfmTFDGhj4YDzFnsWvZ8kVgCA/n7UsTwZnxzt1779onYqTVcYSrQ8V3yBnX+Ntai9kHKIXRZbypDk4qKq0qYZC3cvqzoxXH8p33wd0ApM0XkdTKlHozFf37tBPa7aEkOclY4UbJTvRzwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0Qoj272mVuVUU8ywY76KO/Wt2XEqCeWEjLpkk1RkfKg=; b=PlY6JvamnVnTqfB8Oyscz9DIRM5/w7eWcFmm4Bw/MXjUOKSndN+laj6TVYJ/pgJ6Z80M2UQUgbMnvjg9UMHoIDt0Nbv0etZVloQtc8QsBF3zcoLv/0yEanYHXDXVgw2PkqYhwhL3uNbF67uQdx3Y3laoKAAlRHj4RpUqZRG0G/APmfCBIUIm7sSTGX7bR6Cmy9kyMjzlTajqot9IEU+isO5L59qKwRSiIuAaAHc+xoa2nf/b/tZTVZmJiXQESEFfIbSWB2nezdUOZMxsCv+Y36HUE7m017+BvE1N8a3PaaVrj6DBC/8pYTkaN/x5YEmgNnWcDadWPfI3kN7zgxkaOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB6117.namprd11.prod.outlook.com (2603:10b6:8:b3::19) by IA1PR11MB8175.namprd11.prod.outlook.com (2603:10b6:208:44f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.31; Wed, 17 Apr 2024 11:42:19 +0000 Received: from DM4PR11MB6117.namprd11.prod.outlook.com ([fe80::9c8d:938f:e1f4:ef4a]) by DM4PR11MB6117.namprd11.prod.outlook.com ([fe80::9c8d:938f:e1f4:ef4a%2]) with mapi id 15.20.7472.025; Wed, 17 Apr 2024 11:42:19 +0000 Date: Wed, 17 Apr 2024 13:42:13 +0200 From: Maciej Fijalkowski To: Larysa Zaremba Message-ID: References: <20240416125856.1263314-1-larysa.zaremba@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240416125856.1263314-1-larysa.zaremba@intel.com> X-ClientProxiedBy: MI1P293CA0028.ITAP293.PROD.OUTLOOK.COM (2603:10a6:290:3::20) To DM4PR11MB6117.namprd11.prod.outlook.com (2603:10b6:8:b3::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6117:EE_|IA1PR11MB8175:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ae75f91-ea30-4113-d883-08dc5ed37002 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6w7HsjLUd8rYw8cakvdtPWOq0lIPKKloiYIS27/PyxB/alVUb16b6T9Vm0c71a6R5g713joQ2UAqgo8aiFFldDAsAG64Q/lNgC4vwUUaYTRGNfO98vVSSjQ6iFaIPoX3Kc2kApIUBJ0+iYVY8PJj61UngwZH05LeqN6WWCdnVUGLGw0YzZQ8S55lowhYi8VFSaTzaewyRj8nsCsuK/VPe6Pf09wQ2QHPRgC6/UwVjhnxMiPE36F4UMqOgz1heWmwEgRNzQVv5WY+AuBf6OthHobwpQVIFg6FVmCXcVXQ3uEfyP+821FOukhNDkuWy6TfILr6RdFP5Ss8rlakt75lu5XJesPqUQqLUYauv8HQi2xEvKVypMzyj44op8jspQN06AEMGpBaS1+AJ1RFTLWjekS5mydykGLYGEnz/Lhmzh5EUuxDGS/ldMc2I2pBhzQqMFg3gm93XmeT+zrQkgxKyQXZkfjq6fWr6hFZ/+KVNce10Vh6uWu/ldVG2SaFtRV8cEcjdmVIPhzY8i/xkdgGFyZsoOpsvr5oIigDV37kLG2W0UU8Bi9sG83nS4B11KrDtGHD8EfU07A38pAK8pEoJS46ZFCcweKRIqOYC16wHKY= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6117.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LRmpf/K8Tw+3+kKaImiKvv+SRRBYCIOmsNt6uQ6jA2kzM2mMFvr0tlvMSmAn?= =?us-ascii?Q?JcwqxsOdxC7QuA6Q0n4cPTYuURWeRFVDQLP9wQ8dxD310qd2TrlKC1p57rA6?= =?us-ascii?Q?CZkpGWUppujV1KZBwpvPXi8Ht+kBuUsFWrIsSb8Kw4bpONg5cHqxV23qQOCX?= =?us-ascii?Q?4HmoZQX7lxCcyYjhfzPgMsTNMHzzHr4nOQ6QfP1shluhdH1qzVcF/rFrzfb/?= =?us-ascii?Q?nSl94HQVw0qJLLfhqLrkPRuysZh84wG/4Ex8P0C4crjfcAMi2m64jOnTkIVY?= =?us-ascii?Q?jlZqSrLk0HWLRs3D+6h+/r3Aei5ZsWe5VcMtgro56phZ1GRD4/mVwpt+3UL2?= =?us-ascii?Q?O66g8YxuhOpjpg2gkVVzcEEpNtbwZtGKSHC82T2Alhzq3e0dZTXm0Cqkw7x8?= =?us-ascii?Q?MztR5fb4WF4lao+Y6hRDQM+Xtshlr+j/piDsIltOr/bHZQMFDMJQNVAkz/49?= =?us-ascii?Q?x1+87OuzNj79m9puYIBq+TYPvcPWAY0RuZe7AkQR07OgmK/w6mSHdCYUzmFj?= =?us-ascii?Q?Rr1BeiIMnOyOPgC0/P1XAJK/xSQd4Bow1tlus3WPg8tdxZuO50ln77oQwrn2?= =?us-ascii?Q?ogg6yHGcU2246wFUQ9ngynplqSZvugtSzRaS2I2vf4G+/eUQ3sd/pXiogUW2?= =?us-ascii?Q?rbSeN9vT4j8u2h4tAyNPmleH0UBWqMMHQrn1NEtvSIHwUz3deMnIPvk2hQxt?= =?us-ascii?Q?0cXLG4f21soePt8NGrgmSuR75RNnNeUVQU7WOSe35RFZUpv82s4yczERKVwO?= =?us-ascii?Q?oSybWXlUeFW5rs0J5XJSmiBNkjVt+R7S30BKj7IJ5nIED95nsJEzeZdZWA4R?= =?us-ascii?Q?WekXBqf5ZzgmbGdTAH5yegZYaTDXJbV4shj+3ALvaeRQ/QvmDuMgZhdENZ4u?= =?us-ascii?Q?IZt6ZhzooDyrH67Ts2okBRwW63er+xC3annmpC9GOd0XCUYeuJycD4xswQIG?= =?us-ascii?Q?TdyJu9iRsegYherTLWNj6utZOXya/hND6nwDBDwCLauxiBKyc+sdIlCdAJkh?= =?us-ascii?Q?XBo8UsH+VQYyrfoLwNLbr4jySdmmxjlHhlcIMB2k+iV1peXII2TC89CUYBSa?= =?us-ascii?Q?8SVn5nelI2yQuDhEaxZ1nZzgsz989N5aCEvoLpAYzzhjT09mEBydF9b1E92l?= =?us-ascii?Q?yJ36FsdBTeKXZ0EHT74JHqacxP1XtMdqTMcA8UYwKLk+tH9h0U/HWNZCN29G?= =?us-ascii?Q?77SwxN+3ogrcGUPVxKxsf4G+zberEUb78hza19id5S9Ius/UZI3vDAd0Qj8d?= =?us-ascii?Q?oE3xLUq78FiMU/dv94z2UYPZAo5twXoxFk5qk85mzLjdUZ6aIxAGqsobbG5m?= =?us-ascii?Q?LV2D1I2CAFDsJS1YwTSio0DFnW4IVPa0fHg90+7G0bi+XMK41gm+MSGk1/gc?= =?us-ascii?Q?MrjvUNSRCMRZlnXZS04Qazs9/LhiIPbtI0lKV4c/JnJ3s+V+UcCjc2LcZ0Sx?= =?us-ascii?Q?QzRRhJRkzywzO6LYVPZ+PWGkDcQIMCXsecWmqupnXDBvkg6fdih8RsIvsSoy?= =?us-ascii?Q?xBsWQD2HNf//dM2QY4JfoXsiTu7SFw0vfoGIkkDA/s2fE3IIQERuuCRoWtl5?= =?us-ascii?Q?amW4/DBcnqcB0GL/QOYoJxb0blIFkbF4JMqtfMpNtHvBW/sY99H/FljnPKQy?= =?us-ascii?Q?cQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4ae75f91-ea30-4113-d883-08dc5ed37002 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 11:42:19.1424 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nzRvtO2qnhWl9JIrJkiP8oqV6g00kFcZupFkV8ZU8CLvegfbNmIxUJLG96pCVbaYo07QHltI6fZUkNHiKSNbZf7Cfgtj8EoHDER6x/BZqwM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB8175 X-OriginatorOrg: intel.com X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713354149; x=1744890149; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=/6u30+r4HyWTAqbxy8qd6liyRAYdYk+oIU9oItECcbE=; b=ciTTR7HKscZlrypVpnZvyNY1ZfIKcI9nHN8heoLKnb9u0gkxuTaCDUV0 SpY90rn8ska2wP79NBE0UWBamYqYmnm8mCW1PHZDoMRtS0lYXaiUr9p0X ++uE8z232Xw4LH6ylaBDPPiVvc0m3eoE8Bjf9Ju2UhDUIskHDe1jbbuyB WaRvy23fzgVp1PMypKYJlqt/f/OWOCH1yiqdTi7TTi5n2bZvnbiXKROoe llHlzAPxAOn+fKDDKr1Iilk2gmGnsVOtTtZ5prz+h6DzJqfyPOFoDGpaE VO+gYjL/Bt4I29u4IcO4iytckrZ/r7O3bGfou3Qn7le/rg78iIIErxsZL A==; X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=none dis=none) header.from=intel.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=ciTTR7HK X-Mailman-Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Subject: Re: [Intel-wired-lan] [PATCH iwl-net] ice: Interpret .set_channels() input differently X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Swiatkowski , Emil Tantilov , Lukasz Czapnik , linux-kernel@vger.kernel.org, Eric Dumazet , intel-wired-lan@lists.osuosl.org, alan.brady@intel.com, Jakub Kicinski , Tony Nguyen , Paolo Abeni , "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Apr 16, 2024 at 02:58:54PM +0200, Larysa Zaremba wrote: > A bug occurs because a safety check guarding AF_XDP-related queues in > ethnl_set_channels(), does not trigger. This happens, because kernel and > ice driver interpret the ethtool command differently. > > How the bug occurs: > 1. ethtool -l -> combined: 40 > 2. Attach AF_XDP to queue 30 > 3. ethtool -L rx 15 tx 15 > combined number is not specified, so command becomes {rx_count = 15, > tx_count = 15, combined_count = 40}. > 4. ethnl_set_channels checks, if there are any AF_XDP of queues from the > new (combined_count + rx_count) to the old one, so from 55 to 40, check > does not trigger. > 5. ice interprets `rx 15 tx 15` as 15 combined channels and deletes the > queue that AF_XDP is attached to. > > Interpret the command in a way that is more consistent with ethtool > manual [0] (--show-channels and --set-channels). > > Considering that in the ice driver only the difference between RX and TX > queues forms dedicated channels, change the correct way to set number of > channels to: > > ethtool -L combined 10 /* For symmetric queues */ > ethtool -L combined 8 tx 2 rx 0 /* For asymmetric queues */ Makes sense for usage above: Acked-by: Maciej Fijalkowski Nonetheless I still think core should not allow user to shoot himself to foot, but let's keep it as a separate thing. Thanks! > > [0] https://man7.org/linux/man-pages/man8/ethtool.8.html > > Fixes: 87324e747fde ("ice: Implement ethtool ops for channels") > Reviewed-by: Michal Swiatkowski > Signed-off-by: Larysa Zaremba > --- > drivers/net/ethernet/intel/ice/ice_ethtool.c | 22 ++++++-------------- > 1 file changed, 6 insertions(+), 16 deletions(-) > > diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c > index 78b833b3e1d7..d91f41f61bce 100644 > --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c > +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c > @@ -3593,7 +3593,6 @@ static int ice_set_channels(struct net_device *dev, struct ethtool_channels *ch) > struct ice_pf *pf = vsi->back; > int new_rx = 0, new_tx = 0; > bool locked = false; > - u32 curr_combined; > int ret = 0; > > /* do not support changing channels in Safe Mode */ > @@ -3615,22 +3614,13 @@ static int ice_set_channels(struct net_device *dev, struct ethtool_channels *ch) > return -EOPNOTSUPP; > } > > - curr_combined = ice_get_combined_cnt(vsi); > + if (!ch->combined_count) { > + netdev_err(dev, "Please specify at least 1 combined channel\n"); > + return -EINVAL; > + } > > - /* these checks are for cases where user didn't specify a particular > - * value on cmd line but we get non-zero value anyway via > - * get_channels(); look at ethtool.c in ethtool repository (the user > - * space part), particularly, do_schannels() routine > - */ > - if (ch->rx_count == vsi->num_rxq - curr_combined) > - ch->rx_count = 0; > - if (ch->tx_count == vsi->num_txq - curr_combined) > - ch->tx_count = 0; > - if (ch->combined_count == curr_combined) > - ch->combined_count = 0; > - > - if (!(ch->combined_count || (ch->rx_count && ch->tx_count))) { > - netdev_err(dev, "Please specify at least 1 Rx and 1 Tx channel\n"); > + if (ch->rx_count && ch->tx_count) { > + netdev_err(dev, "Dedicated RX or TX channels cannot be used simultaneously\n"); > return -EINVAL; > } > > -- > 2.43.0 >