From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E236CFD2FD for ; Fri, 11 Oct 2024 09:26:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 11A54812D1; Fri, 11 Oct 2024 09:26:08 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id GykLUXOPEB3o; Fri, 11 Oct 2024 09:26:07 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 704A881274 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1728638767; bh=P+YWBi/NF4XHbVVKXVfXRgwaxoIBhT12XyixnJaAsUU=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=iHzMc6EXhjAhx0h+bV7/pzLxTam7+rhKxpo8zV3Eml8cX80DB8gxxpyiATG+h6TE+ 10Ke12s8Ogm8Yqxbg70WC78zXyXwMFsDtksJfOxu9iCX+fPF6GCxXRoLAQ6QWRbfQf FHEMtIhvZAK1bWNNZo8KoSeb+hRIGL4wNB2mfQ5pd5dESfxtjxb+8kUqyl/Ki4X1uF Qv0FBB7WhVSVceP7vpyaVRnUGZhd2gp/3M8YuKQ6zd8jkvhSwslMLfLof073aOG6jN vH4Ez5kEEwnU484d350qWIZ8mIc0cZXGB4wpi8Dh+f4nYYRhQt7xpdzjPhAqQMTAfH 4HZ+8ecnjo6Pg== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 704A881274; Fri, 11 Oct 2024 09:26:07 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 500361BF85D for ; Fri, 11 Oct 2024 09:26:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 4B5CD81274 for ; Fri, 11 Oct 2024 09:26:06 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Zqu_YQ1c2tMr for ; Fri, 11 Oct 2024 09:26:05 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=vinschen@redhat.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 8253081266 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8253081266 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id 8253081266 for ; Fri, 11 Oct 2024 09:26:04 +0000 (UTC) Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-352-VevBD9oeMtySLA04I0bPKw-1; Fri, 11 Oct 2024 05:25:59 -0400 X-MC-Unique: VevBD9oeMtySLA04I0bPKw-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6531F1955EE7; Fri, 11 Oct 2024 09:25:58 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.193.246]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C4CEF19560AA; Fri, 11 Oct 2024 09:25:57 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 52DE5A809D6; Fri, 11 Oct 2024 11:25:50 +0200 (CEST) Date: Fri, 11 Oct 2024 11:25:50 +0200 From: Corinna Vinschen To: christopher.s.hall@intel.com Message-ID: Mail-Followup-To: christopher.s.hall@intel.com, intel-wired-lan@lists.osuosl.org, david.zage@intel.com, vinicius.gomes@intel.com, netdev@vger.kernel.org, rodrigo.cadore@l-acoustics.com References: <20240807003032.10300-1-christopher.s.hall@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240807003032.10300-1-christopher.s.hall@intel.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728638764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P+YWBi/NF4XHbVVKXVfXRgwaxoIBhT12XyixnJaAsUU=; b=L3ciS+Rj5kKGvDeA58bOq7ZSCpXjhj8Kh3fCCzC0CW/mh6mvCbbKAJGG1nBgwNoXY++DJ+ 9MU4KCS1vIJQMWgIqJX80nGExR16dLA4Cr/+9kH1TFp/aKVQjveYO4wPF+BQBBgUGOriMp PuFTx6LlLqJrFKBf0MqN26YeDGFgmq0= X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=redhat.com X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=L3ciS+Rj Subject: Re: [Intel-wired-lan] [PATCH iwl-net v1 0/5] igc: PTM timeout fix X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vinicius.gomes@intel.com, netdev@vger.kernel.org, david.zage@intel.com, rodrigo.cadore@l-acoustics.com, intel-wired-lan@lists.osuosl.org Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Hi Christopher, are you planning a followup to this patch series any tinme soon? Thanks, Corinna On Aug 6 17:30, christopher.s.hall@intel.com wrote: > From: Christopher S M Hall > > There have been sporadic reports of PTM timeouts using i225/i226 devices > > These timeouts have been root caused to: > > 1) Manipulating the PTM status register while PTM is enabled and triggered > 2) The hardware retrying too quickly when an inappropriate response is > received from the upstream device > > The issue can be reproduced with the following: > > $ sudo phc2sys -R 1000 -O 0 -i tsn0 -m > > Note: 1000 Hz (-R 1000) is unrealistically large, but provides a way to > quickly reproduce the issue. > > PHC2SYS exits with: > > "ioctl PTP_OFFSET_PRECISE: Connection timed out" when the PTM transaction > fails > > Christopher S M Hall (5): > igc: Ensure the PTM cycle is reliably triggered > igc: Lengthen the hardware retry time to prevent timeouts > igc: Move ktime snapshot into PTM retry loop > igc: Reduce retry count to a more reasonable number > igc: Add lock preventing multiple simultaneous PTM transactions > > drivers/net/ethernet/intel/igc/igc.h | 1 + > drivers/net/ethernet/intel/igc/igc_defines.h | 3 +- > drivers/net/ethernet/intel/igc/igc_ptp.c | 100 +++++++++++-------- > 3 files changed, 63 insertions(+), 41 deletions(-) > > -- > 2.34.1