From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A73CD41D6F for ; Tue, 12 Nov 2024 09:01:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id E3CF260778; Tue, 12 Nov 2024 09:01:36 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id KrgbIQNO4F9Q; Tue, 12 Nov 2024 09:01:34 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org CFC9160773 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1731402094; bh=EHtwsu7KBmmaL1dzIh95Y6SpDQSlw8SJ3N4itxEXOVk=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=twXckHq/xOoBWrYr/D+APDllPqnwSIAvJq6bDp6wwRPuXh/v10kntXHCvBANWKRz8 YGV2rYBKefypcTN4sCk7GvpL1vJ0L6u/qxROoIXRADN/UJOmWYb9FsF/Ywuw9ZPCZj rMLSB0419DAfPgJfzZDHnfElDavWh499dqCxWAmxxp80kjxSStD+6w6cWFAqlLwqnM nTOiCbT5j0MpfgsRzFj9FqLULMmTWTohX8s/SFpVvohIlptHifaWiNIkCnSrWYwhwv EqDDd/ANARYpxs8Mvc509QgtxbWaQ2JxA1lt5KpPpbmAZA3fooKkcsLBbiUBZiikjy BgtP5vD+FB6Sw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id CFC9160773; Tue, 12 Nov 2024 09:01:34 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists1.osuosl.org (Postfix) with ESMTP id 7AFEF6C for ; Tue, 12 Nov 2024 09:01:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 5F90B81123 for ; Tue, 12 Nov 2024 09:01:33 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id nUTvzFL4cmBA for ; Tue, 12 Nov 2024 09:01:32 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=198.175.65.17; helo=mgamail.intel.com; envelope-from=michal.swiatkowski@linux.intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 711D98111C DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 711D98111C Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by smtp1.osuosl.org (Postfix) with ESMTPS id 711D98111C for ; Tue, 12 Nov 2024 09:01:31 +0000 (UTC) X-CSE-ConnectionGUID: XYBjKyHIR72Dd3OiqMiKxQ== X-CSE-MsgGUID: H7SmwgRJSQai7v89/uOjRA== X-IronPort-AV: E=McAfee;i="6700,10204,11253"; a="31318152" X-IronPort-AV: E=Sophos;i="6.12,147,1728975600"; d="scan'208";a="31318152" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2024 01:01:03 -0800 X-CSE-ConnectionGUID: e6kJCa25TRuj03V01nh0DA== X-CSE-MsgGUID: ojG1P6OdTSyzEGAAibmwaw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,147,1728975600"; d="scan'208";a="118291844" Received: from mev-dev.igk.intel.com ([10.237.112.144]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2024 01:00:59 -0800 Date: Tue, 12 Nov 2024 09:58:18 +0100 From: Michal Swiatkowski To: Michal Schmidt Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, pawel.chmielewski@intel.com, sridhar.samudrala@intel.com, jacob.e.keller@intel.com, pio.raczynski@gmail.com, konrad.knitter@intel.com, marcin.szycik@intel.com, wojciech.drewek@intel.com, nex.sw.ncis.nat.hpm.dev@intel.com, przemyslaw.kitszel@intel.com, jiri@resnulli.us, horms@kernel.org, David.Laight@aculab.com, pmenzel@molgen.mpg.de Message-ID: References: <20241104121337.129287-1-michal.swiatkowski@linux.intel.com> <20241104121337.129287-3-michal.swiatkowski@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731402093; x=1762938093; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=J4YLsSb0ADwVaiqdgi3gHn5573IyKZUBPT1DevJVQzk=; b=lstOq3/2oMfBgPUmURnDVG6NTAJAXicq7fc2TZ+jOay58YjSbDqKKWw5 HirXC7HBgCN8SG3HiRQGjhAsx+bJ2TeHdJcJWznkkFhGeYVXMq5BwJ78D SXUHC7fqhR7dTx78wOd0tWdPFe32599nHmH3RVd71CUZUCJ++sHlqC17e paRVtmZIzIPSFn7xqYdnbDZ+G9rATTHjzWT+mKEcBnvXIyf/klMTiNsUI t6n8YsSlb4jOjm4QZ4H3itVQR+p1aHCPCOYLJpzZFLgMA6GnHEr2fxTz0 g/oVomSDzuI6ZpO1F3U8x3dgm0Ia28iu/6vcRWkz6e683X9/Hk0jJqtLt g==; X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=none (p=none dis=none) header.from=linux.intel.com X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=lstOq3/2 Subject: Re: [Intel-wired-lan] [iwl-next v7 2/9] ice: devlink PF MSI-X max and min parameter X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Nov 11, 2024 at 12:44:11PM +0100, Michal Schmidt wrote: > On Mon, Nov 4, 2024 at 1:13 PM Michal Swiatkowski > wrote: > > > > Use generic devlink PF MSI-X parameter to allow user to change MSI-X > > range. > > > > Add notes about this parameters into ice devlink documentation. > > > > Signed-off-by: Michal Swiatkowski > > --- > > Documentation/networking/devlink/ice.rst | 11 +++ > > .../net/ethernet/intel/ice/devlink/devlink.c | 83 ++++++++++++++++++- > > drivers/net/ethernet/intel/ice/ice.h | 7 ++ > > drivers/net/ethernet/intel/ice/ice_irq.c | 7 ++ > > 4 files changed, 107 insertions(+), 1 deletion(-) > > > [...] > > @@ -1648,6 +1710,7 @@ void ice_devlink_unregister(struct ice_pf *pf) > > int ice_devlink_register_params(struct ice_pf *pf) > > { > > struct devlink *devlink = priv_to_devlink(pf); > > + union devlink_param_value value; > > struct ice_hw *hw = &pf->hw; > > int status; > > > > @@ -1656,11 +1719,27 @@ int ice_devlink_register_params(struct ice_pf *pf) > > if (status) > > return status; > > > > + status = devl_params_register(devlink, ice_dvl_msix_params, > > + ARRAY_SIZE(ice_dvl_msix_params)); > > + if (status) > > + return status; > > + > > if (hw->func_caps.common_cap.tx_sched_topo_comp_mode_en) > > status = devl_params_register(devlink, ice_dvl_sched_params, > > ARRAY_SIZE(ice_dvl_sched_params)); > > + if (status) > > + return status; > > Error handling looks wrong in this function. > You have to unwind the registration of the params from above or they will leak. > Sorry I did not notice this earlier. > Right, I will send fixed version. Thanks for reviewing, Michal > Michal >