From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: <netdev-bot+sashiko@kernel.org>
Cc: <netdev@vger.kernel.org>, <kuba@kernel.org>,
<anthony.l.nguyen@intel.com>, <aleksandr.loktionov@intel.com>,
<mschmidt@redhat.com>, <intel-wired-lan@lists.osuosl.org>,
<edumazet@google.com>, <horms@kernel.org>, <pabeni@redhat.com>,
<davem@davemloft.net>
Subject: Re: [PATCH net v5 1/6] ice: skip stats handling for channel VSIs on rebuild
Date: Wed, 30 Sep 2026 13:54:04 +0200 [thread overview]
Message-ID: <a273aa18-511d-4ed8-9c3a-a7eac49b9338@intel.com> (raw)
In-Reply-To: <179069064725.434549.10623558636835220604@kernel.org>
Summary: Ignore.
> [Severity: Medium]
>
> This guard only checks the VSI type.
yes, this is a fix for a scenario reachable w/o memory failures
added with hope that bots will complain less on other patches
> Can pf->vsi_stats[vsi->idx] also be
> NULL here for a PF, VF or other non-channel VSI?
> [...]
TLDR: preexising issue for low memory conditions
>
> A later patch in this series, "ice: rebuild ring stats arrays instead of
> reallocating them in place", appears to fix this
Then please simply ignore the comment now.
Anyway, patch 1 has fixes tag for newer commit than the last.
side comment:
This was (a screenful...) report to suggest minor change in a very small
patch, normally I would do that, but with our current "new world" it
would simply mean delaying me by 3+ days.
> Sashiko AI review ·
https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260925132636.123300-1-przemyslaw.kitszel%40intel.com
next prev parent reply other threads:[~2026-09-30 11:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 13:15 [PATCH net v5 0/6] ice: fix stats array overflow via proper realloc Przemek Kitszel
2026-09-25 13:15 ` [PATCH net v5 1/6] ice: skip stats handling for channel VSIs on rebuild Przemek Kitszel
2026-09-25 14:29 ` Loktionov, Aleksandr
2026-09-29 14:04 ` netdev-bot+sashiko
2026-09-30 11:54 ` Przemek Kitszel [this message]
2026-09-29 18:02 ` Jacob Keller
2026-09-25 13:15 ` [PATCH net v5 2/6] ice: extract __ice_vsi_free_stats() Przemek Kitszel
2026-09-25 14:30 ` Loktionov, Aleksandr
2026-09-29 14:04 ` netdev-bot+sashiko
2026-09-30 11:54 ` Przemek Kitszel
2026-09-25 13:15 ` [PATCH net v5 3/6] ice: extract ice_vsi_new_stat_arrays() Przemek Kitszel
2026-09-25 14:30 ` Loktionov, Aleksandr
2026-09-25 13:15 ` [PATCH net v5 4/6] ice: extract ice_vsi_get_num_qs() Przemek Kitszel
2026-09-25 14:31 ` Loktionov, Aleksandr
2026-09-25 13:15 ` [PATCH net v5 5/6] ice: rebuild ring stats arrays instead of reallocating them in place Przemek Kitszel
2026-09-25 14:32 ` Loktionov, Aleksandr
2026-09-29 14:04 ` netdev-bot+sashiko
2026-09-30 11:54 ` Przemek Kitszel
2026-09-25 13:15 ` [PATCH net v5 6/6] ice: size ring stats arrays from the final queue count Przemek Kitszel
2026-09-25 14:32 ` Loktionov, Aleksandr
2026-09-29 14:04 ` netdev-bot+sashiko
2026-09-30 11:54 ` Przemek Kitszel
2026-09-30 11:55 ` [PATCH net v5 0/6] ice: fix stats array overflow via proper realloc Przemek Kitszel
2026-09-30 21:01 ` Jakub Kicinski
2026-09-30 21:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a273aa18-511d-4ed8-9c3a-a7eac49b9338@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=mschmidt@redhat.com \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox