From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Lukasz Plachno <lukasz.plachno@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next 1/2] ice: Remove unnecessary argument from ice_fdir_comp_rules()
Date: Tue, 5 Dec 2023 13:23:02 -0800 [thread overview]
Message-ID: <a47ee305-1318-3b32-bf26-da6342ca4513@intel.com> (raw)
In-Reply-To: <20231130055540.12692-2-lukasz.plachno@intel.com>
On 11/29/2023 9:55 PM, Lukasz Plachno wrote:
> Passing v6 argument is unnecessary as flow_type is still
> analyzed inside the function.
>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Lukasz Plachno <lukasz.plachno@intel.com>
This doesn't build cleanly.
../drivers/net/ethernet/intel/ice/ice_fdir.c: In function
‘ice_fdir_comp_rules’:
../drivers/net/ethernet/intel/ice/ice_fdir.c:1203:2: warning:
enumeration value ‘ICE_FLTR_PTYPE_NONF_NONE’ not handled in switch
[-Wswitch]
switch (flow_type) {
^~~~~~
../drivers/net/ethernet/intel/ice/ice_fdir.c:1203:2: warning:
enumeration value ‘ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_UDP’ not handled
in switch [-Wswitch]
../drivers/net/ethernet/intel/ice/ice_fdir.c:1203:2: warning:
enumeration value ‘ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_TCP’ not handled
in switch [-Wswitch]
../drivers/net/ethernet/intel/ice/ice_fdir.c:1203:2: warning:
enumeration value ‘ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_ICMP’ not handled
in switch [-Wswitch]
../drivers/net/ethernet/intel/ice/ice_fdir.c:1203:2: warning:
enumeration value ‘ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_OTHER’ not handled
in switch [-Wswitch]
../drivers/net/ethernet/intel/ice/ice_fdir.c:1203:2: warning:
enumeration value ‘ICE_FLTR_PTYPE_NONF_IPV6_GTPU_IPV6_OTHER’ not handled
in switch [-Wswitch]
...
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-12-05 21:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 5:55 [Intel-wired-lan] [PATCH iwl-next 0/2] ice: Support flow director ether type filters Lukasz Plachno
2023-11-30 5:55 ` [Intel-wired-lan] [PATCH iwl-next 1/2] ice: Remove unnecessary argument from ice_fdir_comp_rules() Lukasz Plachno
2023-12-05 21:23 ` Tony Nguyen [this message]
2023-12-06 12:30 ` Plachno, Lukasz
2023-11-30 5:55 ` [Intel-wired-lan] [PATCH iwl-next 2/2] ice: Implement 'flow-type ether' rules Lukasz Plachno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a47ee305-1318-3b32-bf26-da6342ca4513@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=lukasz.plachno@intel.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox