Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>,
	Vinicius Costa Gomes <vinicius.gomes@intel.com>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Kurt Kanzenbach <kurt@linutronix.de>,
	Eric Dumazet <edumazet@google.com>,
	netdev@vger.kernel.org, Tony Nguyen <anthony.l.nguyen@intel.com>,
	intel-wired-lan@lists.osuosl.org,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net] igc: Remove stale comment about Tx timestamping
Date: Fri, 15 Mar 2024 08:22:28 +0100	[thread overview]
Message-ID: <a52cfb3e-dae5-4f23-8625-2e489281f0e8@intel.com> (raw)
In-Reply-To: <20240314103545.Ljj-g-iS@linutronix.de>

On 3/14/24 11:35, Sebastian Andrzej Siewior wrote:
> On 2024-03-14 11:21:38 [+0100], Przemek Kitszel wrote:
>> On 3/13/24 14:03, Kurt Kanzenbach wrote:
>>> The initial igc Tx timestamping implementation used only one register for
>>> retrieving Tx timestamps. Commit 3ed247e78911 ("igc: Add support for
>>> multiple in-flight TX timestamps") added support for utilizing all four of
>>> them e.g., for multiple domain support. Remove the stale comment/FIXME.
>>>
>>> Fixes: 3ed247e78911 ("igc: Add support for multiple in-flight TX timestamps")
>>
>> I would remove fixes tag (but keep the mention in commit msg).
>> And I would also target it to iwl-next when the window will open.
>>
>> Rationale: it's really not a fix.
> 
> It is a fix as it removes something that is not accurate. But it only
> changes a comment so it has not outcome in the binary. I think what you
> mean is that you wish that it will not be backported stable. Still
> people reading the code of a v6.6 kernel might get confused.
> 
> Sebastian
> 

You are right that this will cause no harm to backport it as is too,
I'm fine with that after a second though, so:

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>

  reply	other threads:[~2024-03-15  7:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-13 13:03 [Intel-wired-lan] [PATCH iwl-net] igc: Remove stale comment about Tx timestamping Kurt Kanzenbach
2024-03-13 16:23 ` Vinicius Costa Gomes
2024-03-14 10:21 ` Przemek Kitszel
2024-03-14 10:35   ` Sebastian Andrzej Siewior
2024-03-15  7:22     ` Przemek Kitszel [this message]
2024-03-20 11:19 ` naamax.meir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a52cfb3e-dae5-4f23-8625-2e489281f0e8@intel.com \
    --to=przemyslaw.kitszel@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=bigeasy@linutronix.de \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=kurt@linutronix.de \
    --cc=muhammad.husaini.zulkifli@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=vinicius.gomes@intel.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox