From: Bowers, AndrewX <andrewx.bowers@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v3 5/9] ice: implement full NVM read from ETHTOOL_GEEPROM
Date: Mon, 16 Mar 2020 19:22:12 +0000 [thread overview]
Message-ID: <a54d52e94c83415680501cc74777b91a@intel.com> (raw)
In-Reply-To: <20200312015818.1007882-6-jacob.e.keller@intel.com>
-----Original Message-----
From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Jacob Keller
Sent: Wednesday, March 11, 2020 6:58 PM
To: Intel Wired LAN <intel-wired-lan@lists.osuosl.org>
Cc: Jakub Kicinski <kuba@kernel.org>
Subject: [Intel-wired-lan] [PATCH v3 5/9] ice: implement full NVM read from ETHTOOL_GEEPROM
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
The current implementation of .get_eeprom only enables reading from the Shadow RAM portion of the NVM contents. Implement support for reading the entire flash contents instead of only the initial portion contained in the Shadow RAM.
A complete dump can take several seconds, but the ETHTOOL_GEEPROM ioctl is capable of reading only a limited portion at a time by specifying the offset and length to read.
In order to perform the reads directly, several functions are made non static. Additionally, the unused ice_read_sr_buf_aq and ice_read_sr_buf functions are removed.
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
---
drivers/net/ethernet/intel/ice/ice_common.h | 3 -
drivers/net/ethernet/intel/ice/ice_ethtool.c | 33 ++--
drivers/net/ethernet/intel/ice/ice_nvm.c | 150 +------------------
drivers/net/ethernet/intel/ice/ice_nvm.h | 4 +
4 files changed, 26 insertions(+), 164 deletions(-)
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
next prev parent reply other threads:[~2020-03-16 19:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 1:58 [Intel-wired-lan] [PATCH v3 0/9] ice devlink support Jacob Keller
2020-03-12 1:58 ` [Intel-wired-lan] [PATCH v3 1/9] ice: use __le16 types for explicitly Little Endian values Jacob Keller
2020-03-16 19:15 ` Bowers, AndrewX
2020-03-12 1:58 ` [Intel-wired-lan] [PATCH v3 2/9] ice: create function to read a section of the NVM and Shadow RAM Jacob Keller
2020-03-16 19:17 ` Bowers, AndrewX
2020-03-12 1:58 ` [Intel-wired-lan] [PATCH v3 3/9] ice: store NVM version info in extracted format Jacob Keller
2020-03-16 19:18 ` Bowers, AndrewX
2020-03-12 1:58 ` [Intel-wired-lan] [PATCH v3 4/9] ice: discover and store size of available flash Jacob Keller
2020-03-16 19:21 ` Bowers, AndrewX
2020-03-12 1:58 ` [Intel-wired-lan] [PATCH v3 5/9] ice: implement full NVM read from ETHTOOL_GEEPROM Jacob Keller
2020-03-16 19:22 ` Bowers, AndrewX [this message]
2020-03-12 1:58 ` [Intel-wired-lan] [PATCH v3 6/9] ice: enable initial devlink support Jacob Keller
2020-03-16 20:22 ` Bowers, AndrewX
2020-03-12 1:58 ` [Intel-wired-lan] [PATCH v3 7/9] devlink: promote "fw.bundle_id" to a generic info version Jacob Keller
2020-03-12 20:17 ` Jakub Kicinski
2020-03-16 20:26 ` Bowers, AndrewX
2020-03-12 1:58 ` [Intel-wired-lan] [PATCH v3 8/9] ice: add basic handler for devlink .info_get Jacob Keller
2020-03-12 20:18 ` Jakub Kicinski
2020-03-16 20:23 ` Bowers, AndrewX
2020-03-12 1:58 ` [Intel-wired-lan] [PATCH v3 9/9] ice: add board identifier info to " Jacob Keller
2020-03-12 20:18 ` Jakub Kicinski
2020-03-16 20:24 ` Bowers, AndrewX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a54d52e94c83415680501cc74777b91a@intel.com \
--to=andrewx.bowers@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox