From: Piotr Gardocki <piotrx.gardocki@intel.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: pmenzel@molgen.mpg.de, netdev@vger.kernel.org, gal@nvidia.com,
anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org,
kuba@kernel.org, simon.horman@corigine.com,
przemyslaw.kitszel@intel.com
Subject: Re: [Intel-wired-lan] [PATCH net-next] net: fix net device address assign type
Date: Thu, 22 Jun 2023 14:42:53 +0200 [thread overview]
Message-ID: <a5ab1ef6-1bc1-3e98-7f8b-5c5a3678ca8b@intel.com> (raw)
In-Reply-To: <ZJQE4ieud5Mf8iGi@nanopsycho>
On 22.06.2023 10:22, Jiri Pirko wrote:
> Wed, Jun 21, 2023 at 03:21:06PM CEST, piotrx.gardocki@intel.com wrote:
>> Commit ad72c4a06acc introduced optimization to return from function
>
> Out of curiosity, what impact does this optimization have? Is it worth
> it to have such optimization at all? Wouldn't simple revert of the fixes
> commit do the trick? If not, see below.
Thanks for review. My main goal originally was to skip call to ndo_set_mac_address.
The benefit of this depends on how given driver handles such request. Some drivers
notify their hardware about the "change", iavf for example sends a request to PF
driver (and awaits for response). i40e and ice already had this check (I removed
them in previous patch set) and we wanted to also introduce it in iavf. But it
was suggested to move this check to core to have benefit for all drivers.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-06-22 12:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 13:21 [Intel-wired-lan] [PATCH net-next] net: fix net device address assign type Piotr Gardocki
2023-06-22 6:37 ` Simon Horman
2023-06-22 8:22 ` Jiri Pirko
2023-06-22 12:42 ` Piotr Gardocki [this message]
2023-06-22 13:37 ` Jiri Pirko
2023-06-23 3:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5ab1ef6-1bc1-3e98-7f8b-5c5a3678ca8b@intel.com \
--to=piotrx.gardocki@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=gal@nvidia.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=przemyslaw.kitszel@intel.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox