Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bowers, AndrewX <andrewx.bowers@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v2] fm10k: use txqueue parameter in fm10k_tx_timeout
Date: Mon, 6 Jan 2020 20:19:23 +0000	[thread overview]
Message-ID: <a5bd2b6577e04a46a91e9257a095bef1@intel.com> (raw)
In-Reply-To: <20191219201000.1712-1-jacob.e.keller@intel.com>

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Jacob Keller
> Sent: Thursday, December 19, 2019 12:10 PM
> To: Intel Wired LAN <intel-wired-lan@lists.osuosl.org>
> Subject: [Intel-wired-lan] [PATCH v2] fm10k: use txqueue parameter in
> fm10k_tx_timeout
> 
> Make use of the new txqueue parameter to the .ndo_tx_timeout function.
> In fm10k_tx_timeout, remove the now unnecessary loop to determine
> which Tx queue is stuck. Instead, just double check the specified queue
> 
> This could be improved further to attempt resetting only the specific queue
> that got stuck. However, that is a much larger refactor and has been left as a
> future improvement.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
> 
> Woops, sorry for the quick v2. Had missed a semicolon and apparently my
> config I used to check this after a last minute move to add the Tx queue
> warning didn't have CONFIG_FM10K enabled.. Woops.
> 
>  drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 17 ++++++++++-------
>  1 file changed, 10 insertions(+), 7 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers@intel.com>



      reply	other threads:[~2020-01-06 20:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-19 20:10 [Intel-wired-lan] [PATCH v2] fm10k: use txqueue parameter in fm10k_tx_timeout Jacob Keller
2020-01-06 20:19 ` Bowers, AndrewX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5bd2b6577e04a46a91e9257a095bef1@intel.com \
    --to=andrewx.bowers@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox