Re: [Intel-wired-lan] [PATCH iwl-next v1 1/1] igc: Refactor runtime power management flow

["naamax.meir" <naamax.meir@linux.intel.com>]

On 2/11/2024 09:30, Sasha Neftin wrote:
> Following the corresponding discussion [1] and [2] refactor the 'igc_open'
> method and avoid taking the rtnl_lock() during the 'igc_resume' method.
> The rtnl_lock is held by the upper layer and could lead to the deadlock
> during resuming from a runtime power management flow. Notify the stack of
> the actual queue counts 'netif_set_real_num_*_queues' outside the
> '_igc_open' wrapper. This notification doesn't have to be called on each
> resume.
> 
> Test:
> 1. Disconnect the ethernet cable
> 2. Enable the runtime power management via file system:
> echo auto > /sys/devices/pci0000\.../power/control
> 3. Check the device state (lspci -s <device> -vvv | grep -i Status)
> 
> Link: https://lore.kernel.org/netdev/20231206113934.8d7819857574.I2deb5804
> ef1739a2af307283d320ef7d82456494@changeid/#r [1]
> Link: https://lore.kernel.org/netdev/20211125074949.5f897431@kicinski-fedo
> ra-pc1c0hjn.dhcp.thefacebook.com/t/ [2]
> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_main.c | 32 +++++++++++------------
>   1 file changed, 15 insertions(+), 17 deletions(-)

Tested-by: Naama Meir <naamax.meir@linux.intel.com>