Re: [Intel-wired-lan] [PATCH 1/1] idpf: Add missing dependencies

[Malin Jonsson <malin.jonsson@est.tech>]

On fre, 11 jul 2025, Przemek Kitszel wrote:

> On 7/11/25 08:47, Malin Jonsson wrote:
> > The idpf driver depends on both AUXILIARY_BUS and NET_DEVLINK, but
> > they're not selected by the Kconfig. Let's fix this so idpf builds even
> > with a stripped config.
> > 
> > Reported-by: Yong Gu <yong.g.gu@ericsson.com>
> > Signed-off-by: Malin Jonsson <malin.jonsson@est.tech>
> 
> Thank you for the fix!

My pleasure!

> if you have a Link to the public report, please add it as a Closes: tag

There is no public report that I'm aware of.

> 
> Would be also great to add a Fixes: tag with the commit that introduces
> the need for given dependency/ies

I can do that.

> (there should be one tag only (per your commit), if both deps were
> introduced by the very same pull request, just use the earlier commit)
> 
> > ---
> >   drivers/net/ethernet/intel/idpf/Kconfig | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/net/ethernet/intel/idpf/Kconfig b/drivers/net/ethernet/intel/idpf/Kconfig
> > index 1f893221e2c99..5c7ce626aae16 100644
> > --- a/drivers/net/ethernet/intel/idpf/Kconfig
> > +++ b/drivers/net/ethernet/intel/idpf/Kconfig
> > @@ -8,6 +8,8 @@ config IDPF
> >   	select LIBETH
> >   	select LIBETH_CP
> >   	select LIBETH_IRQ
> > +	select AUXILIARY_BUS
> > +	select NET_DEVLINK
> 
> looks good, but please notice that we keep this list sorted

Thanks! I will fix this and resubmit.
> 
> >   	help
> >   	  This driver supports Intel(R) Infrastructure Data Path Function
> >   	  devices.
> 
> 
>