From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9018CA0EF8 for ; Thu, 21 Aug 2025 07:50:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 5F1474171B; Thu, 21 Aug 2025 07:50:29 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 7SeIUlXZvFXr; Thu, 21 Aug 2025 07:50:29 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org DB4CA41720 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1755762628; bh=dKiVVI7dxTB2KqSBmt6ytWWdgaP4+YJtf5CAboYFUAg=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=hiSLu0Bfwf8Q7bPhn8PjCN5Xg7ZVWZf6Uts/IcJ4eozRMv3vAhGBsARaTd2Wnv0SJ cBPEOQ6IR3BHE9n3DSki6VQioTgSC750bBKDPdxqQ2vDlEMnEJu4YHsIsBZOhfiWTK LizDRh889U3XuuAAfUCL/Xcl/l/MlbnBuKQZpiizG0zHgI3Os122tNkmyqqOu2+UpR IcryIdCVx1Uogrhea0uNPBbAGHW1VURMDHODyZAi1mtcco4phkuE0przHM9jWdFE2e G9EtiNTeVFWO361W/GVeX7W3nZZq1WQRFULkIUZ90UpVbVyg6YxvRBSqmVhc0bvj14 hHrL8cnU5EwFQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id DB4CA41720; Thu, 21 Aug 2025 07:50:28 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists1.osuosl.org (Postfix) with ESMTP id 73B15E0A for ; Thu, 21 Aug 2025 07:50:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 6582883F62 for ; Thu, 21 Aug 2025 07:50:28 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id OIJURtkugNGE for ; Thu, 21 Aug 2025 07:50:28 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=mlichvar@redhat.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 913B483EE8 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 913B483EE8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id 913B483EE8 for ; Thu, 21 Aug 2025 07:50:27 +0000 (UTC) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-344-NUtxdQwOPbCdUA9eDb1Jpg-1; Thu, 21 Aug 2025 03:50:23 -0400 X-MC-Unique: NUtxdQwOPbCdUA9eDb1Jpg-1 X-Mimecast-MFC-AGG-ID: NUtxdQwOPbCdUA9eDb1Jpg_1755762621 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C8CFC19560B6; Thu, 21 Aug 2025 07:50:20 +0000 (UTC) Received: from localhost (unknown [10.43.135.229]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B029719560B2; Thu, 21 Aug 2025 07:50:16 +0000 (UTC) Date: Thu, 21 Aug 2025 09:50:14 +0200 From: Miroslav Lichvar To: Jacob Keller Cc: Kurt Kanzenbach , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Vinicius Costa Gomes , Sebastian Andrzej Siewior , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Message-ID: References: <20250815-igb_irq_ts-v1-1-8c6fc0353422@linutronix.de> <81c1a391-3193-41c6-8ab7-c50c58684a22@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <81c1a391-3193-41c6-8ab7-c50c58684a22@intel.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755762626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dKiVVI7dxTB2KqSBmt6ytWWdgaP4+YJtf5CAboYFUAg=; b=D7gAUN48vpynWhYDLDTUeuw4CswWXjTWlQUERtvGZlP820bBb+jCcv7Fx2ROZzhqRYDEiV vbgRfvd1SBWt2nJH6242kkJrT0SyirEj2yKIfl/QIpNtZ12cmWl5hYSwPo1ZJeIv4hXTTK S2B+bs0lfIqIUCf7q8e2JwA5dtm+E/Q= X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=D7gAUN48 Subject: Re: [Intel-wired-lan] [PATCH iwl-next] igb: Retrieve Tx timestamp directly from interrupt X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, Aug 20, 2025 at 01:29:31PM -0700, Jacob Keller wrote: > On 8/20/2025 12:56 AM, Miroslav Lichvar wrote: > > Without the patch: > > NTP daemon TX timestamps : 35835 > > NTP kernel TX timestamps : 1410956 > > NTP hardware TX timestamps : 581575 > > > > With the patch: > > NTP daemon TX timestamps : 476908 > > NTP kernel TX timestamps : 646146 > > NTP hardware TX timestamps : 412095 > > > > When does the NTP daemon decide to go with timestamping within the > daemon vs timestamping in the kernel? It seems odd that we don't achieve > 100% kernel timestamps... Yes, it is odd. The daemon uses the best timestamp it has when the new request comes from the client asking for the TX timestamp of the previous response. With 16384 clients and 200000 requests per second, that's 12 milliseconds between two requests of a client. I tried increasing the receive buffer size of the server UDP socket and also increase the number of clients to make the server wait longer for the SW TX timestamps, but that didn't help. It looks like they are lost. Due to the way the server implements the interleaved mode, it's the first two exchanges with a client always have the TX daemon timestamp, so the "without the patch" result above has only 35835 - 2 * 16384 = 3067 missing SW or HW timestamps (1.5% of all responses), but "with the patch" it is 476908 - 2 * 16384 = 444140 (28.9% of all responses). -- Miroslav Lichvar